From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EA82C433E0 for ; Thu, 30 Jul 2020 16:04:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC40E206F5 for ; Thu, 30 Jul 2020 16:04:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l5yxfADW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729724AbgG3QEG (ORCPT ); Thu, 30 Jul 2020 12:04:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727072AbgG3QEF (ORCPT ); Thu, 30 Jul 2020 12:04:05 -0400 Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55E7CC061574; Thu, 30 Jul 2020 09:04:05 -0700 (PDT) Received: by mail-lf1-x144.google.com with SMTP id s9so15264310lfs.4; Thu, 30 Jul 2020 09:04:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3FAlPclAAJUPeaquH0F3zuzVHhEiAYktWTdgxNqLyxg=; b=l5yxfADWF+7UgfBleV9u3q2R33gIGym9UqKGzwpLmHNShotjVvgmuiW50nzpgbFJZ+ XT6svmnrorvNIfvTicqJHlBmx7/jvIrZPKMrWTxQ0zdoOsGPnw7n+xRLAe7yEit42rsC RlGZmSW6kk5vvnAokbb+wCSi16N5IlkKO3vNy6CbPGZYllrD1M1aUIJ56Awv3Ua1asdJ BJ0Hl5aVWZnKvesjJT3Qwtw38JqZhh3PUm1I3D6P8R3onO3Z7kCe1PI1k/mY5yUzsrjB a9rPj73K5nMAC17Nixi4jVv+ZpYiNFCaAb6D+82yfB4fmX7qo/1Y1gKZSa8DbJkhSA9d kYGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3FAlPclAAJUPeaquH0F3zuzVHhEiAYktWTdgxNqLyxg=; b=bNObCg4KP3RuHZr+JAKBI3SlHbbiij4jFs4+hekbX0Cgx996xuiWAib6ojPyyu4ol9 Qb9Zo8WwzKOydShhTqG+y5omPJ+PVv2KTD34uJBoLpa70zOxd5p8qGRJ9CrrOeQWs3p9 TdRy2yTUf0Q443SDAdHTakWZ6UY8DkYqU7JLqvDyugl5jkE1cu7Ky+0J4Ola/19Yq+6h 8715Y82WdPb/xhzky3U1STjBx88t39+UjTFJG2eZfoI0Crb7mT5DhcBIxGfnKFgIXi6W 8BrUvZCF+M5W44v/qF7DtNJKZWAEzmnTdf5YZV/Vc1KPARxtN1A3eGCw6l7bxUpBeb/x 6k2w== X-Gm-Message-State: AOAM5304VgffV/03E5HcnxXcUUWYUkTy8XEcSskynLfh9F0dsLlvEa2c +BXyipqETNbdf+XIbW4e/x6FSXCJeZo= X-Google-Smtp-Source: ABdhPJyA36NyGFwXgDeY3DZ9aaKOcZyAMrZLjP1m0fsxq68yN/kMGhOS2NTH+/FKpDKgAy2XnSJnTw== X-Received: by 2002:a19:1c6:: with SMTP id 189mr2064146lfb.158.1596125043611; Thu, 30 Jul 2020 09:04:03 -0700 (PDT) Received: from wasted.omprussia.ru ([2a00:1fa0:217:b665:71e9:90c2:18f2:5bd7]) by smtp.gmail.com with ESMTPSA id u12sm313074ljl.88.2020.07.30.09.04.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2020 09:04:02 -0700 (PDT) Subject: Re: [PATCH v2] ravb: Fixed the problem that rmmod can not be done To: Yuusuke Ashizuka Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20200730035649.5940-1-ashiduka@fujitsu.com> <20200730100151.7490-1-ashiduka@fujitsu.com> From: Sergei Shtylyov Message-ID: Date: Thu, 30 Jul 2020 19:04:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200730100151.7490-1-ashiduka@fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hello! On 7/30/20 1:01 PM, Yuusuke Ashizuka wrote: > ravb is a module driver, but I cannot rmmod it after insmod it. Modular. And "insmod'ing it". > ravb does mdio_init() at the time of probe, and module->refcnt is incremented > by alloc_mdio_bitbang() called after that. That seems a common pattern, inlluding the Renesas sh_eth driver... > Therefore, even if ifup is not performed, the driver is in use and rmmod cannot > be performed. No, the driver's remove() method calls ravb_mdio_release() and that one calls free_mdio_bitbang() that calls module_put(); the actual reason lies somewehre deeper than this... Unfortunately I don't have the affected hardware anymore... :-( [...] MBR, Sergei