From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC928C4338F for ; Wed, 18 Aug 2021 10:11:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B49916103A for ; Wed, 18 Aug 2021 10:11:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232954AbhHRKM2 (ORCPT ); Wed, 18 Aug 2021 06:12:28 -0400 Received: from mxout03.lancloud.ru ([45.84.86.113]:60846 "EHLO mxout03.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231218AbhHRKM2 (ORCPT ); Wed, 18 Aug 2021 06:12:28 -0400 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru 95F0920EF7AC Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH net-next v2 1/8] ravb: Add struct ravb_hw_info to driver data To: Biju Das , Geert Uytterhoeven , Sergey Shtylyov CC: "David S. Miller" , Jakub Kicinski , Sergei Shtylyov , Adam Ford , Andrew Lunn , Yuusuke Ashizuka , Yoshihiro Shimoda , netdev , Linux-Renesas , Chris Paterson , Biju Das , Prabhakar Mahadev Lad References: <20210802102654.5996-1-biju.das.jz@bp.renesas.com> <20210802102654.5996-2-biju.das.jz@bp.renesas.com> <071f3fd9-7280-f518-3e38-6456632cc11e@omp.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Wed, 18 Aug 2021 13:11:44 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hello! On 18.08.2021 9:29, Biju Das wrote: [...] >>>>>>> -----Original Message----- >>>>>>> On Mon, Aug 2, 2021 at 12:27 PM Biju Das >>>>>>> >>>>>>> wrote: >>>>>>>> The DMAC and EMAC blocks of Gigabit Ethernet IP found on RZ/G2L >>>>>>>> SoC are similar to the R-Car Ethernet AVB IP. With a few changes >>>>>>>> in the driver we can support both IPs. >>>>>>>> >>>>>>>> Currently a runtime decision based on the chip type is used to >>>>>>>> distinguish the HW differences between the SoC families. >>>>>>>> >>>>>>>> The number of TX descriptors for R-Car Gen3 is 1 whereas on R-Car >>>>>>>> Gen2 and RZ/G2L it is 2. For cases like this it is better to >>>>>>>> select the number of TX descriptors by using a structure with a >>>>>>>> value, rather than a runtime decision based on the chip type. >>>>>>>> >>>>>>>> This patch adds the num_tx_desc variable to struct ravb_hw_info >>>>>>>> and also replaces the driver data chip type with struct >>>>>>>> ravb_hw_info by moving chip type to it. >>>>>>>> >>>>>>>> Signed-off-by: Biju Das >>>>>>>> Reviewed-by: Lad Prabhakar >>>>>>>> >>>>>>> >>>>>>> Thanks for your patch! >>>>>>> >>>>>>>> --- a/drivers/net/ethernet/renesas/ravb.h >>>>>>>> +++ b/drivers/net/ethernet/renesas/ravb.h >>>>>>>> @@ -988,6 +988,11 @@ enum ravb_chip_id { >>>>>>>> RCAR_GEN3, >>>>>>>> }; >>>>>>>> >>>>>>>> +struct ravb_hw_info { >>>>>>>> + enum ravb_chip_id chip_id; >>>>>>>> + int num_tx_desc; >>>>>>> >>>>>>> Why not "unsigned int"? ... >>>>>>> This comment applies to a few more subsequent patches. >>>>>> >>>>>> To avoid signed and unsigned comparison warnings. >>>>>> >>>>>>> >>>>>>>> +}; >>>>>>>> + >>>>>>>> struct ravb_private { >>>>>>>> struct net_device *ndev; >>>>>>>> struct platform_device *pdev; @@ -1040,6 +1045,8 @@ >>>>>>>> struct ravb_private { >>>>>>>> unsigned txcidm:1; /* TX Clock Internal Delay >>>>> Mode >>>>>>> */ >>>>>>>> unsigned rgmii_override:1; /* Deprecated rgmii-*id >>>>> behavior >>>>>>> */ >>>>>>>> int num_tx_desc; /* TX descriptors per >>>> packet >>>>> */ >>>>>>> >>>>>>> ... oh, here's the original culprit. >>>>>> >>>>>> Exactly, this the reason. >>>>>> >>>>>> Do you want me to change this into unsigned int? Please let me know. >>>>> >>>>> Up to you (or the maintainer? ;-) >>>>> >>>>> For new fields (in the other patches), I would use unsigned for all >>>>> unsigned values. Signed values have more pitfalls related to >>>>> undefined behavior. >>>> >>>> Sergei, What is your thoughts here? Please let me know. >>> >>> Here is my plan. >>> >>> I will split this patch into two as Andrew suggested and >> >> If you mran changing the ravb_private::num_tx_desc to *unsigned*, it'll >> be a good cleanup. What's would be the 2nd part tho? > > OK in that case, I will split this patch into 3. > > First patch for adding struct ravb_hw_info to driver data and replace > driver data chip type with struct ravb_hw_info Couldn't this be a 2nd patch?.. > Second patch for changing ravb_private::num_tx_desc from int to unsigned int. ... and this one the 1st? > Third patch for adding aligned_tx to struct ravb_hw_info. > > Regards, > Biju MBR, Sergey