From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1296C32771 for ; Thu, 15 Sep 2022 22:41:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230054AbiIOWlo (ORCPT ); Thu, 15 Sep 2022 18:41:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229953AbiIOWlK (ORCPT ); Thu, 15 Sep 2022 18:41:10 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 793E54B0FF for ; Thu, 15 Sep 2022 15:40:48 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id k9so33183177wri.0 for ; Thu, 15 Sep 2022 15:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conchuod.ie; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=PVkvDcs5B55lPsyOSCnEvKpynvpMcBlSH4X5N0oNFYw=; b=gRt1AkHz797KUWc/T/+UBcNeA1d+rSFR0fBJW9HeAr/jWJf6nqlR5TdJ+mIZeuX8UI yJgVN4dflkmmgB2YMdBZLCn7grder4SPehiVTE4btXlWsIIkpeopEa4dpiG2mZrlm0l0 0w6VUpfTRpozUh0xAXVW+7vmdEIFTVdFhK+m5JCy+b3Y4PMWavijSoSFENWJ4B3jfMjX /085Ceh+Pf28BCHvuApHW1KzNop4Cv9fAUQeIjMEz+whZj5zJE9Jjjm7IGatgWSWuqFd 43N4YNgTI0Wq/37whV86XVx6esV/L7jA9A1tnEvQe73qLKa1qwpNlikpgQ+hA/XD+gKI 2hAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=PVkvDcs5B55lPsyOSCnEvKpynvpMcBlSH4X5N0oNFYw=; b=5ZAVXty+dFMKuRwv5bIltZTVlCkk30xEvwBnBdIZlItrszEsI1np2mrvurWNpOtL8E ftdsjU0tWNjSv0SBPNxq52/d3jppDLGzmhXfVwv5stE+rbJByBraFEZuKppyl5C+baQI 9NS5RxvxhhiRJFi9b3LXR0PP5VjR9kZI3D2Gpnr8GQ+luDDQq0IFu4zPE51B/HFklPdo 5vyjtgtrH8eviHhtbxw5FI1yzyZp4V06XLoHr9d4IFOT4bsmdN/hk/LpS3an7n4jIEAB HUee6helxIHa4ZlGP9UgdI5WKGtjRc9jcmoUCr5UlCQjl4fN3vB5/cUFjDAImZrwOJfV d54A== X-Gm-Message-State: ACrzQf1SmiLppVsbtFTPpsv77mhTsbTQLJynitWbq7qJwtzv7+iFAL44 MpBdcbcIXHVuCyIGLxD4Mq0RwQ== X-Google-Smtp-Source: AMsMyM6/ENjFaotvxFYS+1ydpbwHLtW1hKAX0fr6Of+2WoS911b5ZDjhHxgEBnOwssRrZthyt817LA== X-Received: by 2002:a5d:58d6:0:b0:22a:c38c:d2c8 with SMTP id o22-20020a5d58d6000000b0022ac38cd2c8mr1084920wrf.604.1663281636090; Thu, 15 Sep 2022 15:40:36 -0700 (PDT) Received: from [192.168.2.222] ([109.76.158.112]) by smtp.gmail.com with ESMTPSA id i17-20020a1c5411000000b003a63a3b55c3sm356513wmb.14.2022.09.15.15.40.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Sep 2022 15:40:35 -0700 (PDT) Message-ID: Date: Thu, 15 Sep 2022 23:40:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 07/10] riscv: boot: dts: r9a07g043: Add placeholder nodes Content-Language: en-US To: "Lad, Prabhakar" , Conor.Dooley@microchip.com Cc: geert+renesas@glider.be, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, heiko@sntech.de, atishp@rivosinc.com, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, biju.das.jz@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com References: <20220915181558.354737-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220915181558.354737-8-prabhakar.mahadev-lad.rj@bp.renesas.com> <3693a3a1-5a2a-4cc5-fb55-f6ad9a4b3f72@microchip.com> From: Conor Dooley In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On 15/09/2022 23:26, Lad, Prabhakar wrote: > Hi Conor, > > Thank you for the review. > > On Thu, Sep 15, 2022 at 10:36 PM wrote: >> >> On 15/09/2022 19:15, Prabhakar wrote: >>> riscv: boot: dts: r9a07g043: Add placeholder nodes >> >> nit: s/boot// >> > Will fix that. > >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> From: Lad Prabhakar >>> >>> Add empty placeholder nodes to RZ/Five (R9A07G043) SoC DTSI. >> >> Can you explain why do you need placeholder nodes for this and >> cannot just directly include the other dtsis? >> > Since the RZ/G2UL SoC is ARM64 where it has a GIC and on RZ/Five SoC > we have PLIC for interrupts. Also the interrupt numbering for RZ/Five > SoC differs from RZ/G2UL SoC hence we are not directly using the > RZ/G2UL SoC DTSI [0]. > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/renesas/r9a07g043.dtsi?h=v6.0-rc5 > > For the RZ/Five SMARC EVK I am re-using the below files [1] (SoM) and > [2] (Carrier board) as the RZ/Five SMARC EVK is pin compatible. Since > I am re-using these when trying to compile the RZ/Five DTB I get > compilation errors since the nodes dont exist (and there is no way > currently we can delete the node reference when the actual node itself > isn't present) hence these place holders. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/renesas/rzg2ul-smarc-som.dtsi?h=v6.0-rc5 > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi?h=v6.0-rc5 If this method is acceptable to Geert, this explanation 100% needs to go into the commit message. Thanks, Conor.