From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Stephen Boyd <swboyd@chromium.org>,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource/drivers/sh_mtu2: Do not loop using platform_get_irq_by_name()
Date: Wed, 16 Oct 2019 17:06:37 +0200 [thread overview]
Message-ID: <e8e88948-8dc3-5d89-c9bd-83d20de7ee16@linaro.org> (raw)
In-Reply-To: <20191016143003.28561-1-geert+renesas@glider.be>
On 16/10/2019 16:30, Geert Uytterhoeven wrote:
> As platform_get_irq_by_name() now prints an error when the interrupt
> does not exist, looping over possibly non-existing interrupts causes the
> printing of scary messages like:
>
> sh_mtu2 fcff0000.timer: IRQ tgi1a not found
> sh_mtu2 fcff0000.timer: IRQ tgi2a not found
>
> Fix this by using the platform_irq_count() helper, to avoid touching
> non-existent interrupts. Limit the returned number of interrupts to the
> maximum number of channels currently supported by the driver in a
> future-proof way, i.e. using ARRAY_SIZE() instead of a hardcoded number.
>
> Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This is a fix for v5.4.
> ---
Applied, thanks!
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2019-10-16 15:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 14:30 [PATCH] clocksource/drivers/sh_mtu2: Do not loop using platform_get_irq_by_name() Geert Uytterhoeven
2019-10-16 15:06 ` Daniel Lezcano [this message]
2019-11-14 1:49 ` [PATCH v4] ravb: implement MTU change while device is up Ulrich Hecht
2019-11-14 10:26 ` Geert Uytterhoeven
2019-11-14 20:38 ` Sergei Shtylyov
2019-11-15 2:05 ` David Miller
2019-11-18 9:20 ` Patchwork summary for: linux-renesas-soc patchwork-bot+linux-renesas-soc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8e88948-8dc3-5d89-c9bd-83d20de7ee16@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).