From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A225C4CEC5 for ; Fri, 13 Sep 2019 13:22:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8BF120CC7 for ; Fri, 13 Sep 2019 13:22:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rmH3liTh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391075AbfIMNWj (ORCPT ); Fri, 13 Sep 2019 09:22:39 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:44712 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390973AbfIMNWP (ORCPT ); Fri, 13 Sep 2019 09:22:15 -0400 Received: from [192.168.0.20] (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4300B33A; Fri, 13 Sep 2019 15:22:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1568380933; bh=9gUwoysnC3sI56b/+7CXuRddFhVU5l43f19uyNV6ulM=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=rmH3liThfXkD1hQ5EmPoL29pRPHwRWip0TQ9ZnbF1YUoYhec7PHDtE2EXrUegYGF+ 8oIkeDwmvnZqrVq1E+7PsycDtyWBSHiGu8EvO4ovBUn6nTtU9sy9GpAGHkXo0kUaj5 LBKUd1Q96y57LXSVI+Jd7MQDxpwGT5ecVI7s3HjA= Reply-To: kieran.bingham+renesas@ideasonboard.com Subject: Re: [PATCH v3 2/6] rcar-vin: Make use of V4L2_FIELD_IS_INTERLACED() macro To: =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Laurent Pinchart , linux-media@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org References: <20190904215409.30136-1-niklas.soderlund+renesas@ragnatech.se> <20190904215409.30136-3-niklas.soderlund+renesas@ragnatech.se> From: Kieran Bingham Organization: Ideas on Board Message-ID: Date: Fri, 13 Sep 2019 14:22:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190904215409.30136-3-niklas.soderlund+renesas@ragnatech.se> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On 04/09/2019 22:54, Niklas Söderlund wrote: > The V4L2_FIELD_IS_INTERLACED() can be used to make the code more > readable, use it. Definitely! > > Signed-off-by: Niklas Söderlund > Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham > --- > drivers/media/platform/rcar-vin/rcar-dma.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c > index 3cb29b2e0b2b18a9..7d40d71c863265c9 100644 > --- a/drivers/media/platform/rcar-vin/rcar-dma.c > +++ b/drivers/media/platform/rcar-vin/rcar-dma.c > @@ -557,16 +557,11 @@ static void rvin_crop_scale_comp_gen2(struct rvin_dev *vin) > rvin_write(vin, 0, VNSPPOC_REG); > rvin_write(vin, 0, VNSLPOC_REG); > rvin_write(vin, vin->format.width - 1, VNEPPOC_REG); > - switch (vin->format.field) { > - case V4L2_FIELD_INTERLACED: > - case V4L2_FIELD_INTERLACED_TB: > - case V4L2_FIELD_INTERLACED_BT: > + > + if (V4L2_FIELD_IS_INTERLACED(vin->format.field)) > rvin_write(vin, vin->format.height / 2 - 1, VNELPOC_REG); > - break; > - default: > + else > rvin_write(vin, vin->format.height - 1, VNELPOC_REG); > - break; > - } > > vin_dbg(vin, > "Pre-Clip: %ux%u@%u:%u YS: %d XS: %d Post-Clip: %ux%u@%u:%u\n", >