From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B41FC3A59E for ; Mon, 2 Sep 2019 17:12:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 438AA206BB for ; Mon, 2 Sep 2019 17:12:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="UWqWQQr4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726328AbfIBRMO (ORCPT ); Mon, 2 Sep 2019 13:12:14 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:37405 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbfIBRMO (ORCPT ); Mon, 2 Sep 2019 13:12:14 -0400 Received: by mail-lf1-f66.google.com with SMTP id w67so10876570lff.4 for ; Mon, 02 Sep 2019 10:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E7g5tM3WWBAJ5GFVwE5QOy9tpwo5F4zgFbFtuMqETxU=; b=UWqWQQr4d/4D7FyY68KrSzqJ5FAmWICdxsRrLt/6MqTqO1X0VP3Jcrxa8ez5V6Mxle GLwe6tmvpcfOjH4GVsHtWSOBhxMBSHVLtKkNKKiq49XEV8iVj441qxiYBe6fecS0gcgL ngp97u5TzHmAyOzuWek3I1DyZJS/Pi9thXo8P8fJZP/fNtw85YGADkWH0U1xPPdGbEAw m8m5PAZBWset3rWjH5+3YHGxI9gwrcYEpzM/ixjk1bjZdle0ysfkCsngKrnVa95lcjdC 9JfzDEPmuodlurtbQp118TFFEWbSAzqrnYpUVNS6pI79VL+sX4vwL1MR98biRu5FI1/T eA7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=E7g5tM3WWBAJ5GFVwE5QOy9tpwo5F4zgFbFtuMqETxU=; b=kiaBYjjyU4D6KP3zC5m1DdDUT7/N/uSc8sHZMHNFaE94X3UFShXR8yA9lkrWdfeFKi /chT5ZX9b9D6uGq3mU56+AqEnJmEfsfP+BIqZTgV4jHagEBjhuFXpJIHJ5pDtdhO6Xi0 CLCyX58674XyD7XbrUaq9AB5HJIdgUHvR09v6KUir9TU+2mwCieHx5re0/IfCpEmX7cJ l8MdC0R7c6M4+MvFeISlsNsLUfhX5ltaMhPFXmdwCz8TmA8VlEa25iH+kwq+VCZDYq6D Q8ddddSYhO1Hc3W3ONRBOJEO7enOe4dhLgA4G8iLG0uAcP0kOKc0T35nRxMkXFfpYefY ATxw== X-Gm-Message-State: APjAAAXPzX1iXW6aSoUVkP99uTYHhRj/Zr2iesZiG4RaFdlFPHTOzKmA dNN0+4wTXiV4mtBkT+YGk+fGx70lCnM= X-Google-Smtp-Source: APXvYqwdTVQmz0A+5FgQoXERvwk0lxN6oEmHMMkbrlTQvyjpnXiPRqsuZ2Kh1YESSBlrfK1oOqDBKQ== X-Received: by 2002:ac2:528c:: with SMTP id q12mr201010lfm.135.1567444332875; Mon, 02 Sep 2019 10:12:12 -0700 (PDT) Received: from wasted.cogentembedded.com ([2a00:1fa0:272:5afe:be7d:d15f:cff2:c9cf]) by smtp.gmail.com with ESMTPSA id l23sm2413295lje.106.2019.09.02.10.12.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Sep 2019 10:12:12 -0700 (PDT) From: Sergei Shtylyov Subject: Re: [net-next 1/3] ravb: correct typo in FBP field of SFO register To: Simon Horman , David Miller Cc: Magnus Damm , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Kazuya Mizuguchi References: <20190902080603.5636-1-horms+renesas@verge.net.au> <20190902080603.5636-2-horms+renesas@verge.net.au> Organization: Cogent Embedded Message-ID: Date: Mon, 2 Sep 2019 20:12:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20190902080603.5636-2-horms+renesas@verge.net.au> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hello! On 09/02/2019 11:06 AM, Simon Horman wrote: > From: Kazuya Mizuguchi > > The field name is FBP rather than FPB. > > This field is unused and could equally be removed from the driver entirely. > But there seems no harm in leaving as documentation of the presence of the > field. > > Signed-off-by: Kazuya Mizuguchi > Signed-off-by: Simon Horman Acked-by: Sergei Shtylyov > --- > v0 - Kazuya Mizuguchi > > v1 - Simon Horman > * Extracted from larger patch I'd just claim the authorship in this case (and mentioned that it's based on Mizuguchi-san's large patch right in the change log). > * Wrote changelog > > diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h > index ac9195add811..bdb051f04b0c 100644 > --- a/drivers/net/ethernet/renesas/ravb.h > +++ b/drivers/net/ethernet/renesas/ravb.h > @@ -317,7 +312,7 @@ enum UFCD_BIT { > > /* SFO */ > enum SFO_BIT { > - SFO_FPB = 0x0000003F, > + SFO_FBP = 0x0000003F, > }; > > /* RTC */ > --- This is where the actual patch starts, right? > drivers/net/ethernet/renesas/ravb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h > index ac9195add811..2596a95a4300 100644 > --- a/drivers/net/ethernet/renesas/ravb.h > +++ b/drivers/net/ethernet/renesas/ravb.h > @@ -317,7 +317,7 @@ enum UFCD_BIT { > > /* SFO */ > enum SFO_BIT { > - SFO_FPB = 0x0000003F, > + SFO_FBP = 0x0000003F, > }; > > /* RTC */ MBR, Sergei