From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>,
laurent.pinchart@ideasonboard.com, niklas.soderlund@ragnatech.se
Cc: linux-renesas-soc@vger.kernel.org
Subject: Re: [RFC 02/11] fixup! arm64: dts: renesas: salvator-x: Add MAX9286 expansion board
Date: Mon, 16 Dec 2019 22:37:17 +0000 [thread overview]
Message-ID: <f422690d-d4db-8838-d63a-0992597ef91d@ideasonboard.com> (raw)
In-Reply-To: <20191216171620.372683-3-jacopo+renesas@jmondi.org>
Hi Jacopo,
On 16/12/2019 17:16, Jacopo Mondi wrote:
> Fixes DTC warning:
> r8a7795-es1-salvator-x.dt.yaml: camera@31: reg: [[49, 65, 81]] is too short
Agreed, these should be separated.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Thanks - I'll squash this onto my gmsl/platform branch.
--
Kieran
> ---
> .../boot/dts/renesas/salvator-x-max9286.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/salvator-x-max9286.dtsi b/arch/arm64/boot/dts/renesas/salvator-x-max9286.dtsi
> index cfa3ecb6b2ae..0cc4c82b512f 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-x-max9286.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-x-max9286.dtsi
> @@ -191,7 +191,7 @@ i2c@0 {
> #ifdef MAXIM_CAMERA0
> camera@31 {
> compatible = MAXIM_CAMERA0;
> - reg = <0x31 0x41 0x51>;
> + reg = <0x31>, <0x41>, <0x51>;
>
> port {
> rdacm20_out0: endpoint {
> @@ -211,7 +211,7 @@ i2c@1 {
> #ifdef MAXIM_CAMERA1
> camera@32 {
> compatible = MAXIM_CAMERA1;
> - reg = <0x32 0x42 0x52>;
> + reg = <0x32>, <0x42>, <0x52>;
> port {
> rdacm20_out1: endpoint {
> remote-endpoint = <&max9286_in1>;
> @@ -229,7 +229,7 @@ i2c@2 {
> #ifdef MAXIM_CAMERA2
> camera@33 {
> compatible = MAXIM_CAMERA2;
> - reg = <0x33 0x43 0x53>;
> + reg = <0x33>, <0x43>, <0x53>;
> port {
> rdacm20_out2: endpoint {
> remote-endpoint = <&max9286_in2>;
> @@ -247,7 +247,7 @@ i2c@3 {
> #ifdef MAXIM_CAMERA3
> camera@34 {
> compatible = MAXIM_CAMERA3;
> - reg = <0x34 0x44 0x54>;
> + reg = <0x34>, <0x44>, <0x54>;
> port {
> rdacm20_out3: endpoint {
> remote-endpoint = <&max9286_in3>;
> @@ -326,7 +326,7 @@ i2c@0 {
> #ifdef MAXIM_CAMERA4
> camera@35 {
> compatible = MAXIM_CAMERA4;
> - reg = <0x35 0x45 0x55>;
> + reg = <0x35>, <0x45>, <0x55>;
> port {
> rdacm20_out4: endpoint {
> remote-endpoint = <&max9286_in4>;
> @@ -344,7 +344,7 @@ i2c@1 {
> #ifdef MAXIM_CAMERA5
> camera@36 {
> compatible = MAXIM_CAMERA5;
> - reg = <0x36 0x46 0x56>;
> + reg = <0x36>, <0x46>, <0x56>;
> port {
> rdacm20_out5: endpoint {
> remote-endpoint = <&max9286_in5>;
> @@ -362,7 +362,7 @@ i2c@2 {
> #ifdef MAXIM_CAMERA6
> camera@37 {
> compatible = MAXIM_CAMERA6;
> - reg = <0x37 0x47 0x57>;
> + reg = <0x37>, <0x47>, <0x57>;
> port {
> rdacm20_out6: endpoint {
> remote-endpoint = <&max9286_in6>;
> @@ -380,7 +380,7 @@ i2c@3 {
> #ifdef MAXIM_CAMERA7
> camera@38 {
> compatible = MAXIM_CAMERA7;
> - reg = <0x38 0x48 0x58>;
> + reg = <0x38>, <0x48>, <0x58>;
> port {
> rdacm20_out7: endpoint {
> remote-endpoint = <&max9286_in7>;
>
next prev parent reply other threads:[~2019-12-16 22:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 17:16 [RFC 00/11] GMSL: Initial RDACM21 support Jacopo Mondi
2019-12-16 17:16 ` [RFC 01/11] fixup! DNI: Debug Jacopo Mondi
2019-12-16 22:34 ` Kieran Bingham
2019-12-16 17:16 ` [RFC 02/11] fixup! arm64: dts: renesas: salvator-x: Add MAX9286 expansion board Jacopo Mondi
2019-12-16 22:37 ` Kieran Bingham [this message]
2019-12-16 17:16 ` [RFC 03/11] fixup! arm64: dts: renesas: eagle: Provide Eagle FAKRA dynamic overlay Jacopo Mondi
2019-12-16 22:40 ` Kieran Bingham
2019-12-16 17:16 ` [RFC 04/11] fixup! arm64: dts: renesas: eagle: Provide MAX9286 GMSL deserialiser Jacopo Mondi
2019-12-16 22:41 ` Kieran Bingham
2019-12-16 17:16 ` [RFC 05/11] fixup! dt-bindings: media: i2c: Add bindings for IMI RDACM20 Jacopo Mondi
2019-12-16 22:42 ` Laurent Pinchart
2020-02-14 9:07 ` Kieran Bingham
2019-12-16 17:16 ` [RFC 06/11] media: i2c: Break out max9271 from rdacm20 driver Jacopo Mondi
2019-12-16 17:16 ` [RFC 07/11] media: i2c: max9286: Move notifiers operations Jacopo Mondi
2019-12-16 17:16 ` [RFC 08/11] media: i2c: max9286: Move link setup to completion Jacopo Mondi
2019-12-16 17:16 ` [RFC 09/11] media: i2c: max9286: Expand reverse chanenl amplitude Jacopo Mondi
2019-12-16 17:16 ` [RFC 10/11] WIP: media: i2c: rdacm20: Add RDACM21 support Jacopo Mondi
2019-12-16 17:16 ` [RFC 11/11] arm64: boot: dts: Eagle: Enable RDACM21 Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f422690d-d4db-8838-d63a-0992597ef91d@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).