From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Chris Brandt <chris.brandt@renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Simon Horman <horms@verge.net.au>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
USB list <linux-usb@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v3 04/15] dt-bindings: rcar-gen3-phy-usb2: Document use of usb_x1
Date: Wed, 15 May 2019 11:39:19 +0300
Message-ID: <f4ceaadb-62e1-9880-e8e3-4f5bf54ce91e@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdVVu23_8=8CLwM46QAJsxUbYyN1TYQaAzoE+d2uM3YshQ@mail.gmail.com>
Hello!
On 15.05.2019 10:35, Geert Uytterhoeven wrote:
>> Document the USB_X1 input and add clock-names to identify
>> functional and USB_X1 clocks.
>>
>> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
>> --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
>> +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
>> @@ -28,7 +28,11 @@ Required properties:
>> followed by the generic version.
>>
>> - reg: offset and length of the partial USB 2.0 Host register block.
>> -- clocks: clock phandle and specifier pair(s).
>> +- clocks: clock phandle and specifier pair(s). For SoCs that have a separate
>> + dedicated USB_X1 input for the PLL, that is also listed.
>> +- clock-names: Name of the clocks. The functional clock shall be called "fclk"
>
> Names?
And I think the module clock name was "fck", not "fclk"...
[...]
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
next prev parent reply index
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 14:55 [PATCH v3 00/15] usb: Add host and device support for RZ/A2 Chris Brandt
2019-05-14 14:55 ` [PATCH v3 01/15] ARM: dts: r7s9210: Add USB clock Chris Brandt
2019-05-15 7:38 ` Geert Uytterhoeven
2019-05-15 7:52 ` Simon Horman
2019-05-14 14:55 ` [PATCH v3 02/15] ARM: dts: rza2mevb: Add 48MHz " Chris Brandt
2019-05-15 7:43 ` Geert Uytterhoeven
2019-05-15 7:53 ` Simon Horman
2019-05-14 14:55 ` [PATCH v3 03/15] phy: renesas: rcar-gen3-usb2: detect usb_x1 clock Chris Brandt
2019-05-15 7:32 ` Yoshihiro Shimoda
2019-05-15 8:02 ` Simon Horman
2019-05-15 8:30 ` Kuninori Morimoto
2019-05-14 14:55 ` [PATCH v3 04/15] dt-bindings: rcar-gen3-phy-usb2: Document use of usb_x1 Chris Brandt
2019-05-14 19:29 ` Rob Herring
2019-05-15 7:33 ` Yoshihiro Shimoda
2019-05-15 7:35 ` Geert Uytterhoeven
2019-05-15 8:39 ` Sergei Shtylyov [this message]
2019-05-15 9:03 ` Geert Uytterhoeven
2019-05-15 7:57 ` Simon Horman
2019-05-14 14:55 ` [PATCH v3 05/15] phy: renesas: rcar-gen3-usb2: Check dr_mode when not using OTG Chris Brandt
2019-05-15 7:34 ` Yoshihiro Shimoda
2019-05-15 8:01 ` Simon Horman
2019-05-14 14:55 ` [PATCH v3 06/15] dt-bindings: rcar-gen3-phy-usb2: Document dr_mode Chris Brandt
2019-05-14 19:29 ` Rob Herring
2019-05-15 7:36 ` Yoshihiro Shimoda
2019-05-15 7:56 ` Simon Horman
2019-05-14 14:55 ` [PATCH v3 07/15] dt-bindings: rcar-gen3-phy-usb2: Add r7s9210 support Chris Brandt
2019-05-14 19:30 ` Rob Herring
2019-05-15 7:37 ` Yoshihiro Shimoda
2019-05-15 7:56 ` Simon Horman
2019-05-14 14:55 ` [PATCH v3 08/15] usb: renesas_usbhs: move flags to param Chris Brandt
2019-05-15 7:45 ` Yoshihiro Shimoda
2019-05-15 7:55 ` Simon Horman
2019-05-14 14:55 ` [PATCH v3 09/15] usb: renesas_usbhs: add support for CNEN bit Chris Brandt
2019-05-15 7:46 ` Yoshihiro Shimoda
2019-05-15 7:55 ` Simon Horman
2019-05-14 14:56 ` [PATCH v3 10/15] usb: renesas_usbhs: support byte addressable CFIFO Chris Brandt
2019-05-15 7:48 ` Yoshihiro Shimoda
2019-05-15 7:57 ` Yoshihiro Shimoda
2019-05-15 8:05 ` Simon Horman
2019-05-14 14:56 ` [PATCH v3 11/15] usb: renesas_usbhs: Add support for RZ/A2 Chris Brandt
2019-05-15 7:52 ` Yoshihiro Shimoda
2019-05-15 13:09 ` Chris Brandt
2019-05-15 8:06 ` Simon Horman
2019-05-15 8:26 ` Kuninori Morimoto
2019-05-15 14:18 ` Chris Brandt
2019-05-14 14:56 ` [PATCH v3 12/15] dt-bindings: usb: renesas_usbhs: Add support for r7s9210 Chris Brandt
2019-05-14 19:30 ` Rob Herring
2019-05-15 7:53 ` Yoshihiro Shimoda
2019-05-15 8:00 ` Geert Uytterhoeven
2019-05-15 13:11 ` Chris Brandt
2019-05-15 8:07 ` Simon Horman
2019-05-14 14:56 ` [PATCH v3 13/15] ARM: dts: r7s9210: Add USB Host support Chris Brandt
2019-05-15 7:59 ` Geert Uytterhoeven
2019-05-15 13:38 ` Chris Brandt
2019-05-15 9:05 ` Geert Uytterhoeven
2019-05-14 14:56 ` [PATCH v3 14/15] ARM: dts: r7s9210: Add USB Device support Chris Brandt
2019-05-15 8:02 ` Geert Uytterhoeven
2019-05-14 14:56 ` [PATCH v3 15/15] ARM: dts: rza2mevb: Add USB host support Chris Brandt
2019-05-15 8:21 ` Geert Uytterhoeven
2019-05-15 14:03 ` Chris Brandt
2019-05-15 14:33 ` Geert Uytterhoeven
2019-05-15 14:54 ` Chris Brandt
Reply instructions:
You may reply publically to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4ceaadb-62e1-9880-e8e3-4f5bf54ce91e@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=chris.brandt@renesas.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-Renesas-SoC Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
public-inbox-index linux-renesas-soc
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc
AGPL code for this site: git clone https://public-inbox.org/ public-inbox