From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms+renesas@verge.net.au>,
David Miller <davem@davemloft.net>
Cc: Magnus Damm <magnus.damm@gmail.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Subject: Re: [net-next 2/3] ravb: Remove undocumented processing
Date: Mon, 2 Sep 2019 20:41:14 +0300 [thread overview]
Message-ID: <f54e244a-2d9d-7ba8-02fb-af5572b3a191@cogentembedded.com> (raw)
In-Reply-To: <20190902080603.5636-3-horms+renesas@verge.net.au>
On 09/02/2019 11:06 AM, Simon Horman wrote:
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> This patch removes the use of the undocumented registers
> CDCR, LCCR, CERCR, CEECR and the undocumented BOC bit of the CCC register.
The driver has many more #define's marked as undocumented. It's not clear
why you crammed the counters and the endianness bit in one patch. It clearly
needs to be split -- one patch for the MAC counters and one patch for the
AVB-DMAC bit.
> Current documentation for EtherAVB (ravb) describes the offset of
> what the driver uses as the BOC bit as reserved and that only a value of
> 0 should be written. Furthermore, the offsets used for the undocumented
> registers are also considered reserved nd should not be written to.
>
> After some internal investigation with Renesas it remains unclear
> why this driver accesses these fields but regardless of what the historical
> reasons are the current code is considered incorrect.
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
[...]
MBR, Sergei
next prev parent reply other threads:[~2019-09-02 17:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 8:06 [net-next 0/3] ravb: Remove use of undocumented registers Simon Horman
2019-09-02 8:06 ` [net-next 1/3] ravb: correct typo in FBP field of SFO register Simon Horman
2019-09-02 10:47 ` Yoshihiro Shimoda
2019-09-02 17:12 ` Sergei Shtylyov
2019-09-02 18:33 ` David Miller
2019-09-05 8:34 ` Simon Horman
2019-09-02 8:06 ` [net-next 2/3] ravb: Remove undocumented processing Simon Horman
2019-09-02 10:49 ` Yoshihiro Shimoda
2019-09-02 17:41 ` Sergei Shtylyov [this message]
2019-09-05 8:34 ` Simon Horman
2019-09-02 8:06 ` [net-next 3/3] ravb: TROCR register is only present on R-Car Gen3 Simon Horman
2019-09-02 10:51 ` Yoshihiro Shimoda
2019-09-02 17:54 ` Sergei Shtylyov
2019-09-02 8:16 ` [net-next 0/3] ravb: Remove use of undocumented registers Geert Uytterhoeven
2019-09-02 13:16 ` Chris Paterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f54e244a-2d9d-7ba8-02fb-af5572b3a191@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=horms+renesas@verge.net.au \
--cc=kazuya.mizuguchi.ks@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).