From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D23D0C43603 for ; Fri, 20 Dec 2019 15:50:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5C40222C2 for ; Fri, 20 Dec 2019 15:50:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727270AbfLTPus (ORCPT ); Fri, 20 Dec 2019 10:50:48 -0500 Received: from mail02.asahi-net.or.jp ([202.224.55.14]:52738 "EHLO mail02.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727233AbfLTPus (ORCPT ); Fri, 20 Dec 2019 10:50:48 -0500 X-Greylist: delayed 514 seconds by postgrey-1.27 at vger.kernel.org; Fri, 20 Dec 2019 10:50:47 EST Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail02.asahi-net.or.jp (Postfix) with ESMTPA id 2E01D9EAA7; Sat, 21 Dec 2019 00:42:10 +0900 (JST) Received: from localhost.ysato.name (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id 58C3524008E; Sat, 21 Dec 2019 00:42:07 +0900 (JST) Date: Sat, 21 Dec 2019 00:42:02 +0900 Message-ID: From: Yoshinori Sato To: Kuninori Morimoto Cc: Rich Felker , Karl Nasrallah , Linux-SH , Linux-Renesas , Geert Uytterhoeven Subject: Re: [PATCH v2 0/3] sh: fixup strncpy() In-Reply-To: <87woatyutt.wl-kuninori.morimoto.gx@renesas.com> References: <87woatyutt.wl-kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (arm-unknown-linux-androideabi) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Thu, 19 Dec 2019 10:20:46 +0900, Kuninori Morimoto wrote: > > > Hi Sato-san, Rich > > These are strncpy() fixup patches, but using different solutions. > Karl's patches are updating current strncpy(), but using 2 patterns. > Kuninori's patch is using generic strncpy(). > > We don't know which is the best, but we can follow > SH maintainer's selection. > > Karl Nasrallah (2): > sh: fixup strncpy() warning and add missing padding > sh: fixup strncpy() warning and add missing padding > > Kuninori Morimoto (4): > sh: use generic strncpy() > > Thank you for your help !! > Best regards > --- > Kuninori Morimoto I think the generic version is better, but I want to decide after comparing what code is generated. If it is not very inefficient, I would like to make it a generic version. -- Yoshinori Sato