linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sboyd@kernel.org (Stephen Boyd)
To: linux-riscv@lists.infradead.org
Subject: [PATCH v2 2/3] dt-bindings: clk: add documentation for the SiFive PRCI driver
Date: Tue, 06 Nov 2018 09:33:32 -0800	[thread overview]
Message-ID: <154152561238.88331.13239370518226908068@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181020135024.28573-3-paul.walmsley@sifive.com>

Quoting Paul Walmsley (2018-10-20 06:50:23)
> diff --git a/Documentation/devicetree/bindings/clock/sifive/fu540-prci.txt b/Documentation/devicetree/bindings/clock/sifive/fu540-prci.txt
> new file mode 100644
> index 000000000000..d7c1e83fa5ed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/sifive/fu540-prci.txt
> @@ -0,0 +1,43 @@
> +SiFive FU540 PRCI bindings
> +
> +On the FU540 family of SoCs, most system-wide clock and reset integration
> +is via the PRCI IP block.
> +
> +Required properties:
> +- compatible: Should be "sifive,<chip>-prci<version>".  As of the time this
> +              file was written, only one value is supported:

I don't think we need the "As of the time" sentence. It will become out
of date almost immediately so why not just say "The list of supported
values is:"?

> +             "sifive,fu540-c000-prci0"
> +- reg: Should describe the PRCI's register target physical address region
> +- clocks: Should point to the hfclk device tree node and the rtcclk
> +          device tree node.  The RTC clock here is not a time-of-day clock,
> +         but is instead a high-stability clock source for system timers
> +         and cycle counters.
> +- #clock-cells: Should be <1>

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Paul Walmsley <paul.walmsley@sifive.com>,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Paul Walmsley <paul@pwsan.com>, Megan Wachs <megan@sifive.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Palmer Dabbelt <palmer@sifive.com>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 2/3] dt-bindings: clk: add documentation for the SiFive PRCI driver
Date: Tue, 06 Nov 2018 09:33:32 -0800	[thread overview]
Message-ID: <154152561238.88331.13239370518226908068@swboyd.mtv.corp.google.com> (raw)
Message-ID: <20181106173332.ghIl0Rk9R919ApcTZuvktdk7DFqG9nKEkbtz7yFsJUU@z> (raw)
In-Reply-To: <20181020135024.28573-3-paul.walmsley@sifive.com>

Quoting Paul Walmsley (2018-10-20 06:50:23)
> diff --git a/Documentation/devicetree/bindings/clock/sifive/fu540-prci.txt b/Documentation/devicetree/bindings/clock/sifive/fu540-prci.txt
> new file mode 100644
> index 000000000000..d7c1e83fa5ed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/sifive/fu540-prci.txt
> @@ -0,0 +1,43 @@
> +SiFive FU540 PRCI bindings
> +
> +On the FU540 family of SoCs, most system-wide clock and reset integration
> +is via the PRCI IP block.
> +
> +Required properties:
> +- compatible: Should be "sifive,<chip>-prci<version>".  As of the time this
> +              file was written, only one value is supported:

I don't think we need the "As of the time" sentence. It will become out
of date almost immediately so why not just say "The list of supported
values is:"?

> +             "sifive,fu540-c000-prci0"
> +- reg: Should describe the PRCI's register target physical address region
> +- clocks: Should point to the hfclk device tree node and the rtcclk
> +          device tree node.  The RTC clock here is not a time-of-day clock,
> +         but is instead a high-stability clock source for system timers
> +         and cycle counters.
> +- #clock-cells: Should be <1>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2018-11-06 17:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-20 13:50 [PATCH v2 0/3] clk: add driver for the SiFive FU540 PRCI and PLLs it controls Paul Walmsley
2018-10-20 13:50 ` Paul Walmsley
2018-10-20 13:50 ` [PATCH v2 2/3] dt-bindings: clk: add documentation for the SiFive PRCI driver Paul Walmsley
2018-10-20 13:50   ` Paul Walmsley
2018-10-24 18:47   ` Rob Herring
2018-10-24 18:47     ` Rob Herring
2018-11-16 23:18     ` Paul Walmsley
2018-11-16 23:18       ` Paul Walmsley
2018-11-06 17:33   ` Stephen Boyd [this message]
2018-11-06 17:33     ` Stephen Boyd
2018-11-07  2:00     ` Paul Walmsley
2018-11-07  2:00       ` Paul Walmsley
2018-10-20 13:50 ` [PATCH v2 3/3] clk: sifive: add a driver for the SiFive FU540 PRCI IP block Paul Walmsley
2018-10-20 13:50   ` Paul Walmsley
2018-11-21 16:35   ` Stephen Boyd
2018-11-21 16:35     ` Stephen Boyd
2018-11-27 23:24     ` Paul Walmsley
2018-11-27 23:24       ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154152561238.88331.13239370518226908068@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).