From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5159C43218 for ; Sat, 27 Apr 2019 01:02:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A33E320873 for ; Sat, 27 Apr 2019 01:02:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KrSM4WH/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="yesemrRi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A33E320873 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Message-ID:To:Subject:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tYBz+BccbbSwWrpUXihZ0dJ/flJABoqUMqn8FEmYwMM=; b=KrSM4WH/c16kyD ldEuIR2NXH7Zpvj89QQQTeWujLdjjftwQEvMmRnQ0b7xwPct0EHvHxxdFlv83XbHzI0yIiImHNAsU OqtWxZ3rTO0Gk4pSjojq0fcDKndXT26snqyKg6oJeeylaqZFwlxvE31oLrXEHEFEcJM8bkIN7Lh+n I/8sFv60moW8fgU9dDyrEIHBdwPEkixwqDzbVLxtF783s4cCT0OZa2lzmgzPL+4Nin/j7cvjxVOxM MfG3biVxHVfO1spU+lXwRwt8Tvot5jKexUmETiEcrjE1a/G9PGUmWMm5PDyAhjV8fmTVSHbwqUpN9 u3+wQ+YBWsbqCgrrOGiA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hKBj6-0004hj-7R; Sat, 27 Apr 2019 01:02:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hKBj2-0004gw-QO for linux-riscv@lists.infradead.org; Sat, 27 Apr 2019 01:01:58 +0000 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DEEA020873; Sat, 27 Apr 2019 01:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556326912; bh=w7xtzG77bIQLj4EH5p8XHdnkslc2MaHBi4pBdgv/a/8=; h=In-Reply-To:References:From:Subject:To:Cc:Date:From; b=yesemrRi5X8RA3qSogY0wR6IFNjsCuGDf94v+yi87TNw8NANAtH5SyyTyyza35Wci KMu3bYH7HVPRzyCL0CiyD5manlKpF5+mnOZoQkSC5dAkls3RyulJUOnANgv0mbkPsF 7PYeN9bu0hlAknmYFA7R2QisNwcHeOH0e7f4VqPQ= MIME-Version: 1.0 In-Reply-To: <20190411082733.3736-2-paul.walmsley@sifive.com> References: <20190411082733.3736-2-paul.walmsley@sifive.com> From: Stephen Boyd Subject: Re: [PATCH v3 1/3] clk: analogbits: add Wide-Range PLL library To: Paul Walmsley , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Message-ID: <155632691100.168659.14460051101205812433@swboyd.mtv.corp.google.com> User-Agent: alot/0.8 Date: Fri, 26 Apr 2019 18:01:51 -0700 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190426_180156_874327_D8B7F51E X-CRM114-Status: UNSURE ( 9.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Walmsley , Wesley Terpstra , Michael Turquette , Palmer Dabbelt , Paul Walmsley , Megan Wachs Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org Quoting Paul Walmsley (2019-04-11 01:27:32) > Add common library code for the Analog Bits Wide-Range PLL (WRPLL) IP > block, as implemented in TSMC CLN28HPC. > > There is no bus interface or register target associated with this PLL. > This library is intended to be used by drivers for IP blocks that > expose registers connected to the PLL configuration and status > signals. > > Based on code originally written by Wesley Terpstra > : > https://github.com/riscv/riscv-linux/commit/999529edf517ed75b56659d456d221b2ee56bb60 > > This version incorporates several changes requested by Stephen > Boyd . > > Signed-off-by: Paul Walmsley > Signed-off-by: Paul Walmsley > Cc: Wesley Terpstra > Cc: Palmer Dabbelt > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Megan Wachs > Cc: linux-clk@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- I haven't deeply reviewed at all, but I already get two problems when compile testing these patches. I can fix them up if nothing else needs fixing. drivers/clk/analogbits/wrpll-cln28hpc.c:165 __wrpll_calc_divq() warn: should 'target_rate << divq' be a 64 bit type? drivers/clk/sifive/fu540-prci.c:214:16: error: return expression in void function _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv