Linux-RISC-V Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] clk: sifive: restrict Kconfig scope for the FU540 PRCI driver
@ 2019-05-13 20:07 Paul Walmsley
  2019-05-13 20:22 ` Stephen Boyd
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Walmsley @ 2019-05-13 20:07 UTC (permalink / raw)
  To: sboyd, mturquette, pavel
  Cc: linux-riscv, Paul Walmsley, Paul Walmsley, linux-kernel, linux-clk

Restrict Kconfig scope for SiFive clock and reset IP block drivers
such that they won't appear on most configurations that are unlikely
to support them.  This is based on a suggestion from Pavel Machek
<pavel@ucw.cz>.  Ideally this should be dependent on
CONFIG_ARCH_SIFIVE, but since that Kconfig directive does not yet
exist, add dependencies on RISCV or COMPILE_TEST for now.

Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>
---
 drivers/clk/sifive/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/sifive/Kconfig b/drivers/clk/sifive/Kconfig
index 8db4a3eb4782..27a8fe531357 100644
--- a/drivers/clk/sifive/Kconfig
+++ b/drivers/clk/sifive/Kconfig
@@ -2,6 +2,7 @@
 
 menuconfig CLK_SIFIVE
 	bool "SiFive SoC driver support"
+	depends on RISCV || COMPILE_TEST
 	help
 	  SoC drivers for SiFive Linux-capable SoCs.
 
@@ -10,6 +11,7 @@ if CLK_SIFIVE
 config CLK_SIFIVE_FU540_PRCI
 	bool "PRCI driver for SiFive FU540 SoCs"
 	select CLK_ANALOGBITS_WRPLL_CLN28HPC
+	depends on RISCV || COMPILE_TEST
 	help
 	  Supports the Power Reset Clock interface (PRCI) IP block found in
 	  FU540 SoCs.  If this kernel is meant to run on a SiFive FU540 SoC,
-- 
2.20.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: sifive: restrict Kconfig scope for the FU540 PRCI driver
  2019-05-13 20:07 [PATCH] clk: sifive: restrict Kconfig scope for the FU540 PRCI driver Paul Walmsley
@ 2019-05-13 20:22 ` Stephen Boyd
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2019-05-13 20:22 UTC (permalink / raw)
  To: Paul Walmsley, mturquette, pavel
  Cc: linux-riscv, Paul Walmsley, Paul Walmsley, linux-kernel, linux-clk

Quoting Paul Walmsley (2019-05-13 13:07:58)
> Restrict Kconfig scope for SiFive clock and reset IP block drivers
> such that they won't appear on most configurations that are unlikely
> to support them.  This is based on a suggestion from Pavel Machek
> <pavel@ucw.cz>.  Ideally this should be dependent on
> CONFIG_ARCH_SIFIVE, but since that Kconfig directive does not yet
> exist, add dependencies on RISCV or COMPILE_TEST for now.
> 
> Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Pavel Machek <pavel@ucw.cz>

Reported-by?

> ---
>  drivers/clk/sifive/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/sifive/Kconfig b/drivers/clk/sifive/Kconfig
> index 8db4a3eb4782..27a8fe531357 100644
> --- a/drivers/clk/sifive/Kconfig
> +++ b/drivers/clk/sifive/Kconfig
> @@ -2,6 +2,7 @@
>  
>  menuconfig CLK_SIFIVE
>         bool "SiFive SoC driver support"
> +       depends on RISCV || COMPILE_TEST
>         help
>           SoC drivers for SiFive Linux-capable SoCs.
>  
> @@ -10,6 +11,7 @@ if CLK_SIFIVE
>  config CLK_SIFIVE_FU540_PRCI
>         bool "PRCI driver for SiFive FU540 SoCs"
>         select CLK_ANALOGBITS_WRPLL_CLN28HPC
> +       depends on RISCV || COMPILE_TEST

This isn't needed? The config already implicitly depends on CLK_SIFIVE
which depends on RISCV || COMPILE_TEST. This line should be removed.


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13 20:07 [PATCH] clk: sifive: restrict Kconfig scope for the FU540 PRCI driver Paul Walmsley
2019-05-13 20:22 ` Stephen Boyd

Linux-RISC-V Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-riscv/0 linux-riscv/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-riscv linux-riscv/ https://lore.kernel.org/linux-riscv \
		linux-riscv@lists.infradead.org infradead-linux-riscv@archiver.kernel.org
	public-inbox-index linux-riscv

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-riscv


AGPL code for this site: git clone https://public-inbox.org/ public-inbox