* [PATCH v2 0/2] Update ethernet compatible string for SiFive FU540
@ 2019-08-27 5:06 Yash Shah
2019-08-27 5:06 ` [PATCH v2 1/2] macb: bindings doc: update sifive fu540-c000 binding Yash Shah
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Yash Shah @ 2019-08-27 5:06 UTC (permalink / raw)
To: davem, netdev, devicetree, linux-kernel, linux-riscv
Cc: mark.rutland, palmer, nicolas.ferre, sachin.ghadi, Yash Shah,
robh+dt, paul.walmsley, ynezz
This patch series renames the compatible property to a more appropriate
string. The patchset is based on Linux-5.3-rc6 and tested on SiFive
Unleashed board
Change history:
Since v1:
- Dropped PATCH3 because it's already merged
- Change the reference url in the patch descriptions to point to a
'lore.kernel.org' link instead of 'lkml.org'
Yash Shah (2):
macb: bindings doc: update sifive fu540-c000 binding
macb: Update compatibility string for SiFive FU540-C000
Documentation/devicetree/bindings/net/macb.txt | 4 ++--
drivers/net/ethernet/cadence/macb_main.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
--
1.9.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] macb: bindings doc: update sifive fu540-c000 binding
2019-08-27 5:06 [PATCH v2 0/2] Update ethernet compatible string for SiFive FU540 Yash Shah
@ 2019-08-27 5:06 ` Yash Shah
2019-08-27 5:06 ` [PATCH v2 2/2] macb: Update compatibility string for SiFive FU540-C000 Yash Shah
2019-08-28 21:06 ` [PATCH v2 0/2] Update ethernet compatible string for SiFive FU540 David Miller
2 siblings, 0 replies; 5+ messages in thread
From: Yash Shah @ 2019-08-27 5:06 UTC (permalink / raw)
To: davem, netdev, devicetree, linux-kernel, linux-riscv
Cc: mark.rutland, palmer, nicolas.ferre, sachin.ghadi, Yash Shah,
robh+dt, paul.walmsley, ynezz
As per the discussion with Nicolas Ferre[0], rename the compatible property
to a more appropriate and specific string.
[0] https://lore.kernel.org/netdev/CAJ2_jOFEVZQat0Yprg4hem4jRrqkB72FKSeQj4p8P5KA-+rgww@mail.gmail.com/
Signed-off-by: Yash Shah <yash.shah@sifive.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/net/macb.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
index 63c73fa..0b61a90 100644
--- a/Documentation/devicetree/bindings/net/macb.txt
+++ b/Documentation/devicetree/bindings/net/macb.txt
@@ -15,10 +15,10 @@ Required properties:
Use "atmel,sama5d4-gem" for the GEM IP (10/100) available on Atmel sama5d4 SoCs.
Use "cdns,zynq-gem" Xilinx Zynq-7xxx SoC.
Use "cdns,zynqmp-gem" for Zynq Ultrascale+ MPSoC.
- Use "sifive,fu540-macb" for SiFive FU540-C000 SoC.
+ Use "sifive,fu540-c000-gem" for SiFive FU540-C000 SoC.
Or the generic form: "cdns,emac".
- reg: Address and length of the register set for the device
- For "sifive,fu540-macb", second range is required to specify the
+ For "sifive,fu540-c000-gem", second range is required to specify the
address and length of the registers for GEMGXL Management block.
- interrupts: Should contain macb interrupt
- phy-mode: See ethernet.txt file in the same directory.
--
1.9.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] macb: Update compatibility string for SiFive FU540-C000
2019-08-27 5:06 [PATCH v2 0/2] Update ethernet compatible string for SiFive FU540 Yash Shah
2019-08-27 5:06 ` [PATCH v2 1/2] macb: bindings doc: update sifive fu540-c000 binding Yash Shah
@ 2019-08-27 5:06 ` Yash Shah
2019-08-28 21:06 ` [PATCH v2 0/2] Update ethernet compatible string for SiFive FU540 David Miller
2 siblings, 0 replies; 5+ messages in thread
From: Yash Shah @ 2019-08-27 5:06 UTC (permalink / raw)
To: davem, netdev, devicetree, linux-kernel, linux-riscv
Cc: mark.rutland, palmer, nicolas.ferre, sachin.ghadi, Yash Shah,
robh+dt, paul.walmsley, ynezz
Update the compatibility string for SiFive FU540-C000 as per the new
string updated in the binding doc.
Reference:
https://lore.kernel.org/netdev/CAJ2_jOFEVZQat0Yprg4hem4jRrqkB72FKSeQj4p8P5KA-+rgww@mail.gmail.com/
Signed-off-by: Yash Shah <yash.shah@sifive.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>
Tested-by: Paul Walmsley <paul.walmsley@sifive.com>
---
drivers/net/ethernet/cadence/macb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 5ca17e6..35b59b5 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4154,7 +4154,7 @@ static int fu540_c000_init(struct platform_device *pdev)
{ .compatible = "cdns,emac", .data = &emac_config },
{ .compatible = "cdns,zynqmp-gem", .data = &zynqmp_config},
{ .compatible = "cdns,zynq-gem", .data = &zynq_config },
- { .compatible = "sifive,fu540-macb", .data = &fu540_c000_config },
+ { .compatible = "sifive,fu540-c000-gem", .data = &fu540_c000_config },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, macb_dt_ids);
--
1.9.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 0/2] Update ethernet compatible string for SiFive FU540
2019-08-27 5:06 [PATCH v2 0/2] Update ethernet compatible string for SiFive FU540 Yash Shah
2019-08-27 5:06 ` [PATCH v2 1/2] macb: bindings doc: update sifive fu540-c000 binding Yash Shah
2019-08-27 5:06 ` [PATCH v2 2/2] macb: Update compatibility string for SiFive FU540-C000 Yash Shah
@ 2019-08-28 21:06 ` David Miller
2019-08-29 9:54 ` Yash Shah
2 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2019-08-28 21:06 UTC (permalink / raw)
To: yash.shah
Cc: mark.rutland, devicetree, netdev, palmer, linux-kernel,
nicolas.ferre, sachin.ghadi, robh+dt, paul.walmsley, linux-riscv,
ynezz
From: Yash Shah <yash.shah@sifive.com>
Date: Tue, 27 Aug 2019 10:36:02 +0530
> This patch series renames the compatible property to a more appropriate
> string. The patchset is based on Linux-5.3-rc6 and tested on SiFive
> Unleashed board
You should always base changes off of "net" or "net-next" and be explicitly
in your Subject lines which of those two trees your changes are for f.e.:
Subject: [PATCH v2 net-next N/M] ...
>
> Change history:
> Since v1:
> - Dropped PATCH3 because it's already merged
> - Change the reference url in the patch descriptions to point to a
> 'lore.kernel.org' link instead of 'lkml.org'
Series applied to 'net'.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 0/2] Update ethernet compatible string for SiFive FU540
2019-08-28 21:06 ` [PATCH v2 0/2] Update ethernet compatible string for SiFive FU540 David Miller
@ 2019-08-29 9:54 ` Yash Shah
0 siblings, 0 replies; 5+ messages in thread
From: Yash Shah @ 2019-08-29 9:54 UTC (permalink / raw)
To: David Miller
Cc: Mark Rutland, devicetree, netdev, Palmer Dabbelt,
linux-kernel@vger.kernel.org List, Nicolas Ferre, Sachin Ghadi,
Rob Herring, Paul Walmsley, linux-riscv, Petr Štetiar
On Thu, Aug 29, 2019 at 2:36 AM David Miller <davem@davemloft.net> wrote:
>
> From: Yash Shah <yash.shah@sifive.com>
> Date: Tue, 27 Aug 2019 10:36:02 +0530
>
> > This patch series renames the compatible property to a more appropriate
> > string. The patchset is based on Linux-5.3-rc6 and tested on SiFive
> > Unleashed board
>
> You should always base changes off of "net" or "net-next" and be explicitly
> in your Subject lines which of those two trees your changes are for f.e.:
>
> Subject: [PATCH v2 net-next N/M] ...
I will keep this in mind for future patches.
>
> >
> > Change history:
> > Since v1:
> > - Dropped PATCH3 because it's already merged
> > - Change the reference url in the patch descriptions to point to a
> > 'lore.kernel.org' link instead of 'lkml.org'
>
> Series applied to 'net'.
Thanks!
- Yash
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-08-29 9:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-27 5:06 [PATCH v2 0/2] Update ethernet compatible string for SiFive FU540 Yash Shah
2019-08-27 5:06 ` [PATCH v2 1/2] macb: bindings doc: update sifive fu540-c000 binding Yash Shah
2019-08-27 5:06 ` [PATCH v2 2/2] macb: Update compatibility string for SiFive FU540-C000 Yash Shah
2019-08-28 21:06 ` [PATCH v2 0/2] Update ethernet compatible string for SiFive FU540 David Miller
2019-08-29 9:54 ` Yash Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).