From: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
To: linux-kernel@vger.kernel.org
Cc: andrew@lunn.ch, peter@korsgaard.com, aou@eecs.berkeley.edu,
palmer@dabbelt.com, linux-i2c@vger.kernel.org,
paul.walmsley@sifive.com, linux-riscv@lists.infradead.org,
Sagar Shrikant Kadam <sagar.kadam@sifive.com>
Subject: [PATCH v2 1/1] i2c: ocores: fix polling mode workaround on FU540-C000 SoC
Date: Fri, 9 Oct 2020 08:39:40 -0700 [thread overview]
Message-ID: <1602257980-375157-2-git-send-email-sagar.kadam@sifive.com> (raw)
In-Reply-To: <1602257980-375157-1-git-send-email-sagar.kadam@sifive.com>
The FU540-C000 has a broken IRQ and support was added earlier
so that it will operate in polling mode, but seems to work only
in case interrupts property is missing from the i2c0 dt-node.
This should not be the case and the driver should handle polling
mode with the interrupt property present in i2c0 node of the
device tree.
So check if it's the FU540-C000 soc and enable polling mode master
xfers, as the IRQ for this chip is broken.
Fixes commit c45d4ba86731 ("i2c: ocores: add polling mode workaround
for Sifive FU540-C000 SoC")
Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
---
drivers/i2c/busses/i2c-ocores.c | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index f5fc75b..9b3d1ab 100644
--- a/drivers/i2c/busses/i2c-ocores.c
+++ b/drivers/i2c/busses/i2c-ocores.c
@@ -686,17 +686,21 @@ static int ocores_i2c_probe(struct platform_device *pdev)
init_waitqueue_head(&i2c->wait);
+ /*
+ * Set OCORES_FLAG_BROKEN_IRQ to enable workaround for
+ * FU540-C000 SoC in polling mode.
+ * Since the SoC does have interrupt it's dt has the interrupt
+ * defined but it should be bypassed in driver as this SoC has
+ * a broken IRQ, hence update the master_xfer to use polling
+ * transfers.
+ */
+ if (of_device_is_compatible(pdev->dev.of_node,
+ "sifive,fu540-c000-i2c"))
+ i2c->flags |= OCORES_FLAG_BROKEN_IRQ;
+
irq = platform_get_irq(pdev, 0);
- if (irq == -ENXIO) {
+ if (i2c->flags & OCORES_FLAG_BROKEN_IRQ || irq == -ENXIO) {
ocores_algorithm.master_xfer = ocores_xfer_polling;
-
- /*
- * Set in OCORES_FLAG_BROKEN_IRQ to enable workaround for
- * FU540-C000 SoC in polling mode.
- */
- match = of_match_node(ocores_i2c_match, pdev->dev.of_node);
- if (match && (long)match->data == TYPE_SIFIVE_REV0)
- i2c->flags |= OCORES_FLAG_BROKEN_IRQ;
} else {
if (irq < 0)
return irq;
--
2.7.4
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2020-10-09 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 15:39 [PATCH v2 0/1] fix i2c polling mode workaround for FU540-C000 SoC Sagar Shrikant Kadam
2020-10-09 15:39 ` Sagar Shrikant Kadam [this message]
2020-10-09 18:24 ` [PATCH v2 1/1] i2c: ocores: fix polling mode workaround on " Andreas Schwab
2020-10-12 15:49 ` Sagar Kadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1602257980-375157-2-git-send-email-sagar.kadam@sifive.com \
--to=sagar.kadam@sifive.com \
--cc=andrew@lunn.ch \
--cc=aou@eecs.berkeley.edu \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).