From: Sean Anderson <seanga2@gmail.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Cc: Anup Patel <anup@brainfault.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Atish Patra <Atish.Patra@wdc.com>
Subject: Re: [PATCH] riscv: Set text_offset correctly for M-Mode
Date: Thu, 22 Oct 2020 16:30:54 -0400 [thread overview]
Message-ID: <1c2e3498-e633-3018-3c49-053e9011ac30@gmail.com> (raw)
In-Reply-To: <BL0PR04MB651474C90B702F1B72A68490E71E0@BL0PR04MB6514.namprd04.prod.outlook.com>
On 10/18/20 8:08 PM, Damien Le Moal wrote:
> On 2020/10/18 3:29, Sean Anderson wrote:
>> M-Mode Linux is loaded at the start of RAM, not 2MB later. Perhaps this
>> should be calculated based on PAGE_OFFSET somehow? Even better would be to
>> deprecate text_offset and instead introduce something absolute.
>>
>> Signed-off-by: Sean Anderson <seanga2@gmail.com>
>> ---
>>
>> arch/riscv/kernel/head.S | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/riscv/kernel/head.S b/arch/riscv/kernel/head.S
>> index 0a4e81b8dc79..74679f338c65 100644
>> --- a/arch/riscv/kernel/head.S
>> +++ b/arch/riscv/kernel/head.S
>> @@ -27,12 +27,17 @@ ENTRY(_start)
>> /* reserved */
>> .word 0
>> .balign 8
>> +#ifdef CONFIG_RISCV_S_MODE
>
> Shouldn't this be:
>
> #ifndef CONFIG_RISCV_M_MODE
>
> CONFIG_RISCV_S_MODE does not exist.
>
>> #if __riscv_xlen == 64
>> /* Image load offset(2MB) from start of RAM */
>> .dword 0x200000
>> #else
>> /* Image load offset(4MB) from start of RAM */
>> .dword 0x400000
>> +#endif
>> +#else
>> + /* Image load offset (0MB) from start of RAM for M-mode */
>> + .dword 0
>> #endif
>> /* Effective size of kernel image */
>> .dword _end - _start
>>
>
> Otherwise, looks good to me.
>
Thanks for spotting that. Should be fixed in v2.
--Sean
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2020-10-22 20:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 18:28 [PATCH] riscv: Set text_offset correctly for M-Mode Sean Anderson
2020-10-19 0:08 ` Damien Le Moal
2020-10-22 20:30 ` Sean Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c2e3498-e633-3018-3c49-053e9011ac30@gmail.com \
--to=seanga2@gmail.com \
--cc=Atish.Patra@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).