Linux-RISC-V Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h
@ 2018-11-08 19:07 david.abdurachmanov
  2018-11-08 19:07 ` David Abdurachmanov
  2018-11-08 19:32 ` palmer
  0 siblings, 2 replies; 8+ messages in thread
From: david.abdurachmanov @ 2018-11-08 19:07 UTC (permalink / raw)
  To: linux-riscv

Fixes warning: 'struct module' declared inside parameter list will not be
visible outside of this definition or declaration

Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
---
 arch/riscv/include/asm/module.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/riscv/include/asm/module.h b/arch/riscv/include/asm/module.h
index 349df33808c4..cd2af4b013e3 100644
--- a/arch/riscv/include/asm/module.h
+++ b/arch/riscv/include/asm/module.h
@@ -8,6 +8,7 @@
 
 #define MODULE_ARCH_VERMAGIC    "riscv"
 
+struct module;
 u64 module_emit_got_entry(struct module *mod, u64 val);
 u64 module_emit_plt_entry(struct module *mod, u64 val);
 
-- 
2.19.1

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h
  2018-11-08 19:07 [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h david.abdurachmanov
@ 2018-11-08 19:07 ` David Abdurachmanov
  2018-11-08 19:32 ` palmer
  1 sibling, 0 replies; 8+ messages in thread
From: David Abdurachmanov @ 2018-11-08 19:07 UTC (permalink / raw)
  To: palmer, aou, linux-riscv, linux-kernel; +Cc: David Abdurachmanov

Fixes warning: 'struct module' declared inside parameter list will not be
visible outside of this definition or declaration

Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
---
 arch/riscv/include/asm/module.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/riscv/include/asm/module.h b/arch/riscv/include/asm/module.h
index 349df33808c4..cd2af4b013e3 100644
--- a/arch/riscv/include/asm/module.h
+++ b/arch/riscv/include/asm/module.h
@@ -8,6 +8,7 @@
 
 #define MODULE_ARCH_VERMAGIC    "riscv"
 
+struct module;
 u64 module_emit_got_entry(struct module *mod, u64 val);
 u64 module_emit_plt_entry(struct module *mod, u64 val);
 
-- 
2.19.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h
  2018-11-08 19:07 [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h david.abdurachmanov
  2018-11-08 19:07 ` David Abdurachmanov
@ 2018-11-08 19:32 ` palmer
  2018-11-08 19:32   ` Palmer Dabbelt
  2018-11-17  3:09   ` olof
  1 sibling, 2 replies; 8+ messages in thread
From: palmer @ 2018-11-08 19:32 UTC (permalink / raw)
  To: linux-riscv

On Thu, 08 Nov 2018 11:07:00 PST (-0800), david.abdurachmanov at gmail.com wrote:
> Fixes warning: 'struct module' declared inside parameter list will not be
> visible outside of this definition or declaration
>
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> ---
>  arch/riscv/include/asm/module.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/include/asm/module.h b/arch/riscv/include/asm/module.h
> index 349df33808c4..cd2af4b013e3 100644
> --- a/arch/riscv/include/asm/module.h
> +++ b/arch/riscv/include/asm/module.h
> @@ -8,6 +8,7 @@
>
>  #define MODULE_ARCH_VERMAGIC    "riscv"
>
> +struct module;
>  u64 module_emit_got_entry(struct module *mod, u64 val);
>  u64 module_emit_plt_entry(struct module *mod, u64 val);

Works for me.  Looks like arm64 might have exactly the same issue.  I'll roll 
it up into the next RC.

Thanks!

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h
  2018-11-08 19:32 ` palmer
@ 2018-11-08 19:32   ` Palmer Dabbelt
  2018-11-17  3:09   ` olof
  1 sibling, 0 replies; 8+ messages in thread
From: Palmer Dabbelt @ 2018-11-08 19:32 UTC (permalink / raw)
  To: david.abdurachmanov; +Cc: linux-riscv, aou, linux-kernel, david.abdurachmanov

On Thu, 08 Nov 2018 11:07:00 PST (-0800), david.abdurachmanov@gmail.com wrote:
> Fixes warning: 'struct module' declared inside parameter list will not be
> visible outside of this definition or declaration
>
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> ---
>  arch/riscv/include/asm/module.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/include/asm/module.h b/arch/riscv/include/asm/module.h
> index 349df33808c4..cd2af4b013e3 100644
> --- a/arch/riscv/include/asm/module.h
> +++ b/arch/riscv/include/asm/module.h
> @@ -8,6 +8,7 @@
>
>  #define MODULE_ARCH_VERMAGIC    "riscv"
>
> +struct module;
>  u64 module_emit_got_entry(struct module *mod, u64 val);
>  u64 module_emit_plt_entry(struct module *mod, u64 val);

Works for me.  Looks like arm64 might have exactly the same issue.  I'll roll 
it up into the next RC.

Thanks!

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h
  2018-11-08 19:32 ` palmer
  2018-11-08 19:32   ` Palmer Dabbelt
@ 2018-11-17  3:09   ` olof
  2018-11-17  3:09     ` Olof Johansson
  2018-11-19 17:36     ` palmer
  1 sibling, 2 replies; 8+ messages in thread
From: olof @ 2018-11-17  3:09 UTC (permalink / raw)
  To: linux-riscv

On Thu, Nov 8, 2018 at 11:32 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>
> On Thu, 08 Nov 2018 11:07:00 PST (-0800), david.abdurachmanov at gmail.com wrote:
> > Fixes warning: 'struct module' declared inside parameter list will not be
> > visible outside of this definition or declaration
> >
> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> > ---
> >  arch/riscv/include/asm/module.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/riscv/include/asm/module.h b/arch/riscv/include/asm/module.h
> > index 349df33808c4..cd2af4b013e3 100644
> > --- a/arch/riscv/include/asm/module.h
> > +++ b/arch/riscv/include/asm/module.h
> > @@ -8,6 +8,7 @@
> >
> >  #define MODULE_ARCH_VERMAGIC    "riscv"
> >
> > +struct module;
> >  u64 module_emit_got_entry(struct module *mod, u64 val);
> >  u64 module_emit_plt_entry(struct module *mod, u64 val);
>
> Works for me.  Looks like arm64 might have exactly the same issue.  I'll roll
> it up into the next RC.

Looks like it's still here in -next. So, patch:

Acked-by: Olof Johansson <olof@lixom.net>

(and it'd be great to pickup together with the 32-bit build fix).


-Olof

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h
  2018-11-17  3:09   ` olof
@ 2018-11-17  3:09     ` Olof Johansson
  2018-11-19 17:36     ` palmer
  1 sibling, 0 replies; 8+ messages in thread
From: Olof Johansson @ 2018-11-17  3:09 UTC (permalink / raw)
  To: Palmer Dabbelt
  Cc: linux-riscv, Albert Ou, Linux Kernel Mailing List, David Abdurachmanov

On Thu, Nov 8, 2018 at 11:32 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>
> On Thu, 08 Nov 2018 11:07:00 PST (-0800), david.abdurachmanov@gmail.com wrote:
> > Fixes warning: 'struct module' declared inside parameter list will not be
> > visible outside of this definition or declaration
> >
> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
> > ---
> >  arch/riscv/include/asm/module.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/riscv/include/asm/module.h b/arch/riscv/include/asm/module.h
> > index 349df33808c4..cd2af4b013e3 100644
> > --- a/arch/riscv/include/asm/module.h
> > +++ b/arch/riscv/include/asm/module.h
> > @@ -8,6 +8,7 @@
> >
> >  #define MODULE_ARCH_VERMAGIC    "riscv"
> >
> > +struct module;
> >  u64 module_emit_got_entry(struct module *mod, u64 val);
> >  u64 module_emit_plt_entry(struct module *mod, u64 val);
>
> Works for me.  Looks like arm64 might have exactly the same issue.  I'll roll
> it up into the next RC.

Looks like it's still here in -next. So, patch:

Acked-by: Olof Johansson <olof@lixom.net>

(and it'd be great to pickup together with the 32-bit build fix).


-Olof

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h
  2018-11-17  3:09   ` olof
  2018-11-17  3:09     ` Olof Johansson
@ 2018-11-19 17:36     ` palmer
  2018-11-19 17:36       ` Palmer Dabbelt
  1 sibling, 1 reply; 8+ messages in thread
From: palmer @ 2018-11-19 17:36 UTC (permalink / raw)
  To: linux-riscv

On Fri, 16 Nov 2018 19:09:36 PST (-0800), Olof Johansson wrote:
> On Thu, Nov 8, 2018 at 11:32 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>>
>> On Thu, 08 Nov 2018 11:07:00 PST (-0800), david.abdurachmanov at gmail.com wrote:
>> > Fixes warning: 'struct module' declared inside parameter list will not be
>> > visible outside of this definition or declaration
>> >
>> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
>> > ---
>> >  arch/riscv/include/asm/module.h | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/arch/riscv/include/asm/module.h b/arch/riscv/include/asm/module.h
>> > index 349df33808c4..cd2af4b013e3 100644
>> > --- a/arch/riscv/include/asm/module.h
>> > +++ b/arch/riscv/include/asm/module.h
>> > @@ -8,6 +8,7 @@
>> >
>> >  #define MODULE_ARCH_VERMAGIC    "riscv"
>> >
>> > +struct module;
>> >  u64 module_emit_got_entry(struct module *mod, u64 val);
>> >  u64 module_emit_plt_entry(struct module *mod, u64 val);
>>
>> Works for me.  Looks like arm64 might have exactly the same issue.  I'll roll
>> it up into the next RC.
>
> Looks like it's still here in -next. So, patch:
>
> Acked-by: Olof Johansson <olof@lixom.net>
>
> (and it'd be great to pickup together with the 32-bit build fix).

Sorry, I must have managed to screw something up here and drop both of these 
from my fixes list.  Not sure how they managed to make it into -next without 
being in the list, but it's been on my TODO list to fix up my workflow scripts 
for a while anyway...

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h
  2018-11-19 17:36     ` palmer
@ 2018-11-19 17:36       ` Palmer Dabbelt
  0 siblings, 0 replies; 8+ messages in thread
From: Palmer Dabbelt @ 2018-11-19 17:36 UTC (permalink / raw)
  To: Olof Johansson; +Cc: linux-riscv, aou, linux-kernel, david.abdurachmanov

On Fri, 16 Nov 2018 19:09:36 PST (-0800), Olof Johansson wrote:
> On Thu, Nov 8, 2018 at 11:32 AM Palmer Dabbelt <palmer@sifive.com> wrote:
>>
>> On Thu, 08 Nov 2018 11:07:00 PST (-0800), david.abdurachmanov@gmail.com wrote:
>> > Fixes warning: 'struct module' declared inside parameter list will not be
>> > visible outside of this definition or declaration
>> >
>> > Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
>> > ---
>> >  arch/riscv/include/asm/module.h | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/arch/riscv/include/asm/module.h b/arch/riscv/include/asm/module.h
>> > index 349df33808c4..cd2af4b013e3 100644
>> > --- a/arch/riscv/include/asm/module.h
>> > +++ b/arch/riscv/include/asm/module.h
>> > @@ -8,6 +8,7 @@
>> >
>> >  #define MODULE_ARCH_VERMAGIC    "riscv"
>> >
>> > +struct module;
>> >  u64 module_emit_got_entry(struct module *mod, u64 val);
>> >  u64 module_emit_plt_entry(struct module *mod, u64 val);
>>
>> Works for me.  Looks like arm64 might have exactly the same issue.  I'll roll
>> it up into the next RC.
>
> Looks like it's still here in -next. So, patch:
>
> Acked-by: Olof Johansson <olof@lixom.net>
>
> (and it'd be great to pickup together with the 32-bit build fix).

Sorry, I must have managed to screw something up here and drop both of these 
from my fixes list.  Not sure how they managed to make it into -next without 
being in the list, but it's been on my TODO list to fix up my workflow scripts 
for a while anyway...

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, back to index

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-08 19:07 [PATCH] riscv: fix warning in arch/riscv/include/asm/module.h david.abdurachmanov
2018-11-08 19:07 ` David Abdurachmanov
2018-11-08 19:32 ` palmer
2018-11-08 19:32   ` Palmer Dabbelt
2018-11-17  3:09   ` olof
2018-11-17  3:09     ` Olof Johansson
2018-11-19 17:36     ` palmer
2018-11-19 17:36       ` Palmer Dabbelt

Linux-RISC-V Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-riscv/0 linux-riscv/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-riscv linux-riscv/ https://lore.kernel.org/linux-riscv \
		linux-riscv@lists.infradead.org infradead-linux-riscv@archiver.kernel.org
	public-inbox-index linux-riscv


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-riscv


AGPL code for this site: git clone https://public-inbox.org/ public-inbox