From: Quentin Schulz <quentin.schulz@bootlin.com>
To: Andreas Schwab <schwab@suse.de>
Cc: andrew@lunn.ch, alexandre.belloni@bootlin.com,
f.fainelli@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, allan.nielsen@microchip.com,
thomas.petazzoni@bootlin.com, linux-riscv@lists.infradead.org,
davem@davemloft.net
Subject: Re: [PATCH] net: phy: mscc: fix locking in vsc85xx_default_config
Date: Tue, 20 Nov 2018 14:55:08 +0100 [thread overview]
Message-ID: <20181120135508.paxzs63cqy2llc7d@qschulz> (raw)
Message-ID: <20181120135508.IQQwu-9g7Ggl1Z_d8up1OJSJDZQkV_xIkhIFMU99QLQ@z> (raw)
In-Reply-To: <mvma7m3n9l6.fsf_-_@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 781 bytes --]
Hi Andreas,
On Tue, Nov 20, 2018 at 02:48:37PM +0100, Andreas Schwab wrote:
> Don't use locking phy_read/phy_write functions while inside
> phy_select_patch/phy_restore_page region.
>
> Fixes: 6a0bfbbe20 ("net: phy: mscc: migrate to phy_select/restore_page functions")
> Signed-off-by: Andreas Schwab <schwab@suse.de>
Have you tested this patch? Does it solve your issue?
Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com>
anyway since it's to be done.
You need to send your patch as a mail separate to this patch series.
You also need to prefix your patch with [PATCH net-next] instead of only
[PATCH]. This is specific to the net subsystem.
Use scripts/get_maintainer.pl on your patch to get the people to put in
Cc and in To.
Thanks,
Quentin
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2018-11-20 17:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181008100728.24959-1-quentin.schulz@bootlin.com>
[not found] ` <20181008100728.24959-2-quentin.schulz@bootlin.com>
2018-11-19 14:57 ` [PATCH net-next v3 1/6] net: phy: mscc: migrate to phy_select/restore_page functions Andreas Schwab
2018-11-19 14:57 ` Andreas Schwab
2018-11-19 15:10 ` Andrew Lunn
2018-11-19 15:10 ` Andrew Lunn
2018-11-19 15:13 ` Andreas Schwab
2018-11-19 15:13 ` Andreas Schwab
2018-11-19 15:28 ` Andrew Lunn
2018-11-19 15:28 ` Andrew Lunn
2018-11-19 15:40 ` Alexandre Belloni
2018-11-19 15:40 ` Alexandre Belloni
2018-11-19 15:50 ` Andreas Schwab
2018-11-19 15:50 ` Andreas Schwab
2018-11-19 16:12 ` Andrew Lunn
2018-11-19 16:12 ` Andrew Lunn
2018-11-19 16:14 ` Andreas Schwab
2018-11-19 16:14 ` Andreas Schwab
2018-11-19 16:25 ` Andrew Lunn
2018-11-19 16:25 ` Andrew Lunn
2018-11-19 16:32 ` Andreas Schwab
2018-11-19 16:32 ` Andreas Schwab
2018-11-19 16:44 ` Andrew Lunn
2018-11-19 16:44 ` Andrew Lunn
2018-11-20 11:39 ` Andreas Schwab
2018-11-20 11:39 ` Andreas Schwab
2018-11-20 13:20 ` Quentin Schulz
2018-11-20 13:20 ` Quentin Schulz
2018-11-20 13:48 ` [PATCH] net: phy: mscc: fix locking in vsc85xx_default_config Andreas Schwab
2018-11-20 13:48 ` Andreas Schwab
2018-11-20 13:55 ` Quentin Schulz [this message]
2018-11-20 13:55 ` Quentin Schulz
2018-11-20 14:01 ` Andreas Schwab
2018-11-20 14:01 ` Andreas Schwab
2018-11-20 14:17 ` Quentin Schulz
2018-11-20 14:17 ` Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120135508.paxzs63cqy2llc7d@qschulz \
--to=quentin.schulz@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=schwab@suse.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).