Re: [PATCH v2 00/15] Prepare for PTRACE_GET_SYSCALL_INFO

From: Paul Moore <paul@paul-moore.com>
To: ldv@altlinux.org
Cc: alexey.brodkin@synopsys.com, jcmvbkbc@gmail.com,
	linux-riscv@lists.infradead.org, deanbo422@gmail.com,
	linux-c6x-dev@linux-c6x.org, ysato@users.sourceforge.jp,
	linux-hexagon@vger.kernel.org, lineprinter@altlinux.org,
	palmer@sifive.com, msalter@redhat.com, geert@linux-m68k.org,
	linux-snps-arc@lists.infradead.org,
	uclinux-h8-devel@lists.sourceforge.jp,
	linux-xtensa@linux-xtensa.org, aou@eecs.berkeley.edu,
	jacquiot.aurelien@gmail.com, linux-m68k@lists.linux-m68k.org,
	green.hu@gmail.com, luto@kernel.org,
	nios2-dev@lists.rocketboards.org, chris@zankel.net,
	vgupta@synopsys.com, linux-kernel@vger.kernel.org,
	Eric Paris <eparis@redhat.com>,
	rkuo@codeaurora.org, linux-audit@redhat.com, lftan@altera.com
Subject: Re: [PATCH v2 00/15] Prepare for PTRACE_GET_SYSCALL_INFO
Date: Tue, 20 Nov 2018 15:26:53 -0500	[thread overview]
Message-ID: <CAHC9VhQDs8cMuR4PXDB2VZ9TEtDydyBF_EqBGvjML+NN8+2LNw@mail.gmail.com> (raw)
Message-ID: <20181120202653.YddIJSzHoMQD2_jDqLIw3b_7zIUVCFd_W23JJXHhBqY@z> (raw)
In-Reply-To: <20181120001128.GA11300@altlinux.org>

On Mon, Nov 19, 2018 at 7:11 PM Dmitry V. Levin <ldv@altlinux.org> wrote:
>
> syscall_get_arch() is required to be implemented on all architectures
> in order to extend the generic ptrace API with PTRACE_GET_SYSCALL_INFO
> request.
>
> The primary intent is that the triple (audit_arch, syscall_nr, arg1..arg6)
> should describe what system call is being called and what its arguments are.

No real comment from me, most of this is arch specific code so I'll
let the individual arch folks comment on that; they know far better
than I do what is correct.

That said, anything that gets us closer to being able to offer syscall
auditing for these arches gets a big thumbs up from me - thanks!

> Dmitry V. Levin (15):
>   Move EM_HEXAGON to uapi/linux/elf-em.h
>   Move EM_ARCOMPACT and EM_ARCV2 to uapi/linux/elf-em.h
>   Move EM_UNICORE to uapi/linux/elf-em.h
>   elf-em.h: add EM_NDS32
>   elf-em.h: add EM_XTENSA
>   m68k: define syscall_get_arch()
>   arc: define syscall_get_arch()
>   c6x: define syscall_get_arch()
>   h8300: define syscall_get_arch()
>   hexagon: define syscall_get_arch()
>   nds32: define syscall_get_arch()
>   nios2: define syscall_get_arch()
>   riscv: define syscall_get_arch()
>   unicore32: define syscall_get_arch()
>   xtensa: define syscall_get_arch()
>
>  arch/arc/include/asm/elf.h           |  6 +-----
>  arch/arc/include/asm/syscall.h       | 10 ++++++++++
>  arch/c6x/include/asm/syscall.h       |  7 +++++++
>  arch/h8300/include/asm/syscall.h     |  5 +++++
>  arch/hexagon/include/asm/elf.h       |  6 +-----
>  arch/hexagon/include/asm/syscall.h   |  8 ++++++++
>  arch/m68k/include/asm/syscall.h      | 12 ++++++++++++
>  arch/nds32/include/asm/syscall.h     |  8 ++++++++
>  arch/nios2/include/asm/syscall.h     |  6 ++++++
>  arch/riscv/include/asm/syscall.h     | 10 ++++++++++
>  arch/unicore32/include/asm/elf.h     |  3 +--
>  arch/unicore32/include/asm/syscall.h | 12 ++++++++++++
>  arch/xtensa/include/asm/syscall.h    |  7 +++++++
>  include/uapi/linux/audit.h           | 15 +++++++++++++++
>  include/uapi/linux/elf-em.h          |  7 +++++++
>  15 files changed, 110 insertions(+), 12 deletions(-)
>  create mode 100644 arch/m68k/include/asm/syscall.h
>  create mode 100644 arch/unicore32/include/asm/syscall.h

-- 
paul moore
www.paul-moore.com

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv