Linux-RISC-V Archive on lore.kernel.org
 help / Atom feed
* [PATCH] RISC-V: asm/page.h: fix spelling mistake "CONFIG_64BITS" -> "CONFIG_64BIT"
@ 2019-01-08 19:45 Antony Pavlov
  2019-01-15 13:57 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Antony Pavlov @ 2019-01-08 19:45 UTC (permalink / raw)
  To: linux-riscv; +Cc: Palmer Dabbelt, Albert Ou

There is no CONFIG_64BITS Kconfig macro.
Please see arch/riscv/Kconfig for details, e.g.

  linux$ git grep -HnA 1 "config 64BIT" arch/riscv/Kconfig
  arch/riscv/Kconfig:6:config 64BIT
  arch/riscv/Kconfig-7-        bool

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 arch/riscv/include/asm/page.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/include/asm/page.h b/arch/riscv/include/asm/page.h
index 06cfbb3aacbb0..2a546a52f02a0 100644
--- a/arch/riscv/include/asm/page.h
+++ b/arch/riscv/include/asm/page.h
@@ -80,7 +80,7 @@ typedef struct page *pgtable_t;
 #define __pgd(x)	((pgd_t) { (x) })
 #define __pgprot(x)	((pgprot_t) { (x) })
 
-#ifdef CONFIG_64BITS
+#ifdef CONFIG_64BIT
 #define PTE_FMT "%016lx"
 #else
 #define PTE_FMT "%08lx"
-- 
2.20.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] RISC-V: asm/page.h: fix spelling mistake "CONFIG_64BITS" -> "CONFIG_64BIT"
  2019-01-08 19:45 [PATCH] RISC-V: asm/page.h: fix spelling mistake "CONFIG_64BITS" -> "CONFIG_64BIT" Antony Pavlov
@ 2019-01-15 13:57 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2019-01-15 13:57 UTC (permalink / raw)
  To: Antony Pavlov; +Cc: linux-riscv, Palmer Dabbelt, Albert Ou

On Tue, Jan 08, 2019 at 10:45:38PM +0300, Antony Pavlov wrote:
> There is no CONFIG_64BITS Kconfig macro.
> Please see arch/riscv/Kconfig for details, e.g.
> 
>   linux$ git grep -HnA 1 "config 64BIT" arch/riscv/Kconfig
>   arch/riscv/Kconfig:6:config 64BIT
>   arch/riscv/Kconfig-7-        bool
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>

This looks correct.  But I wonder why we even bother with the explicit
width and don't just use "%lx" directly without the macro.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-08 19:45 [PATCH] RISC-V: asm/page.h: fix spelling mistake "CONFIG_64BITS" -> "CONFIG_64BIT" Antony Pavlov
2019-01-15 13:57 ` Christoph Hellwig

Linux-RISC-V Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-riscv/0 linux-riscv/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-riscv linux-riscv/ https://lore.kernel.org/linux-riscv \
		linux-riscv@lists.infradead.org infradead-linux-riscv@archiver.kernel.org
	public-inbox-index linux-riscv


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-riscv


AGPL code for this site: git clone https://public-inbox.org/ public-inbox