From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Yash Shah <yash.shah@sifive.com>
Cc: mark.rutland@arm.com, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, palmer@sifive.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
sachin.ghadi@sifive.com, thierry.reding@gmail.com,
paul.walmsley@sifive.com, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v5 1/2] pwm: sifive: Add DT documentation for SiFive PWM Controller
Date: Wed, 30 Jan 2019 09:14:11 +0100 [thread overview]
Message-ID: <20190130081411.5rva7cpwoy2l5qjd@pengutronix.de> (raw)
In-Reply-To: <1548762199-7065-2-git-send-email-yash.shah@sifive.com>
On Tue, Jan 29, 2019 at 05:13:18PM +0530, Yash Shah wrote:
> DT documentation for PWM controller added.
>
> Signed-off-by: Wesley W. Terpstra <wesley@sifive.com>
> [Atish: Compatible string update]
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
> Signed-off-by: Yash Shah <yash.shah@sifive.com>
> ---
> .../devicetree/bindings/pwm/pwm-sifive.txt | 33 ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sifive.txt
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-sifive.txt b/Documentation/devicetree/bindings/pwm/pwm-sifive.txt
> new file mode 100644
> index 0000000..8dcb40d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/pwm-sifive.txt
> @@ -0,0 +1,33 @@
> +SiFive PWM controller
> +
> +Unlike most other PWM controllers, the SiFive PWM controller currently only
> +supports one period for all channels in the PWM. This is set globally in DTS.
You can simply drop this if the first user can set this using the usual
interface. Don't you like this suggestion that I already made a few
times now?
Did you consider to make the driver support only a single output with a
more flexible period setting?
> +The period also has significant restrictions on the values it can achieve,
> +which the driver rounds to the nearest achievable frequency.
Rounding a period to a frequency sounds wrong.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-01-30 8:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 11:43 [PATCH v5 0/2] PWM support for HiFive Unleashed Yash Shah
2019-01-29 11:43 ` [PATCH v5 1/2] pwm: sifive: Add DT documentation for SiFive PWM Controller Yash Shah
2019-01-30 8:14 ` Uwe Kleine-König [this message]
2019-02-06 10:48 ` Yash Shah
2019-02-06 11:07 ` Uwe Kleine-König
2019-02-06 12:40 ` Thierry Reding
2019-02-06 15:38 ` Uwe Kleine-König
2019-02-06 16:16 ` Thierry Reding
2019-02-06 16:35 ` Uwe Kleine-König
2019-01-29 11:43 ` [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM Yash Shah
2019-02-05 8:21 ` kbuild test robot
2019-02-05 17:25 ` kbuild test robot
2019-02-06 12:44 ` Thierry Reding
2019-02-07 8:24 ` Yash Shah
2019-02-07 10:16 ` Uwe Kleine-König
2019-02-11 11:26 ` Yash Shah
2019-02-11 12:29 ` Uwe Kleine-König
2019-02-13 12:34 ` Thierry Reding
2019-02-13 17:39 ` Uwe Kleine-König
2019-02-13 12:37 ` Thierry Reding
2019-02-14 15:59 ` Uwe Kleine-König
2019-03-12 7:27 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130081411.5rva7cpwoy2l5qjd@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sachin.ghadi@sifive.com \
--cc=thierry.reding@gmail.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).