From: Alistair Francis <Alistair.Francis@wdc.com>
To: "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>
Cc: "alistair23@gmail.com" <alistair23@gmail.com>,
"palmer@sifive.com" <palmer@sifive.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] riscv: Partially revert "Remove stat64 family from default syscall set"
Date: Thu, 7 Feb 2019 22:55:57 +0000 [thread overview]
Message-ID: <20190207225531.19219-1-alistair.francis@wdc.com> (raw)
To fix systemd/sysVinit crashes enable __ARCH_WANT_STAT64.
systemd failed to start with this error for 32-bit RISC-V:
[ 2.833864] Run /sbin/init as init process
/sbin/init: error while loading shared libraries: libsystemd-shared-239.so: cannot stat shared object: Error 38
[ 2.933593] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00007f00
[ 2.934120] CPU: 0 PID: 1 Comm: init Not tainted 5.0.0-rc4-yoctodev-standard #1
[ 2.934589] Call Trace:
[ 2.934919] [<c0048a30>] walk_stackframe+0x0/0xa0
[ 2.935243] [<c0048c14>] show_stack+0x28/0x32
[ 2.935518] [<c05fa418>] dump_stack+0x68/0x88
[ 2.935788] [<c004de48>] panic+0xf0/0x252
[ 2.936041] [<c0051780>] do_exit+0x7de/0x7fc
[ 2.936387] [<c00517f4>] do_group_exit+0x2a/0x82
[ 2.936674] [<c005185e>] __wake_up_parent+0x0/0x22
[ 2.936982] [<c00475fa>] ret_from_syscall+0x0/0xe
[ 2.937673] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00007f00 ]---
sysVinit had a similar problem as well. By enabling __ARCH_WANT_STAT64
for 32-bit RISC-V the problem disapears and 32-bit RISC-V is able to
boot.
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
This was tested with this fork of glibc to enable 32-bit RISC-V support:
https://github.com/riscv/riscv-glibc/tree/riscv-glibc-2.29
commit: 04fdd476160a55792a75375ba2bf56c761f811c2
I'm not sure if this is a glibc problem or a kernel problem, but this
commit caused the breakage between the 4.19 and 4.20 kernel so I'm
sending out a patch. Let me know your thoughts
arch/riscv/include/uapi/asm/unistd.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/riscv/include/uapi/asm/unistd.h b/arch/riscv/include/uapi/asm/unistd.h
index 1f3bd3ebbb0d..031b7d78e11c 100644
--- a/arch/riscv/include/uapi/asm/unistd.h
+++ b/arch/riscv/include/uapi/asm/unistd.h
@@ -20,6 +20,9 @@
#endif /* __LP64__ */
#include <asm-generic/unistd.h>
+#if __BITS_PER_LONG == 32
+#define __ARCH_WANT_STAT64
+#endif
/*
* Allows the instruction cache to be flushed from userspace. Despite RISC-V
--
2.20.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2019-02-07 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 22:55 Alistair Francis [this message]
2019-02-07 23:03 ` [PATCH] riscv: Partially revert "Remove stat64 family from default syscall set" David Abdurachmanov
2019-02-07 23:12 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207225531.19219-1-alistair.francis@wdc.com \
--to=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).