From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A522C10F04 for ; Thu, 14 Feb 2019 15:59:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08142218EA for ; Thu, 14 Feb 2019 15:59:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GmtI475y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08142218EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wey0872RFmc9vBFBSrsaKPU4Jrg1nPT1SkBFkP7fqlI=; b=GmtI475ypbF7tT UHmbUXI6isrygGUub21ypiHt63KEfmUIEgSI7TSTZ2C5Un3m8dlIfbkT+z0t4KjCmEKW7IWBW+aC6 UC689v4Snc23Oh7b5m5wrXHQpSzIUI2LDiX4pwhIA5ryh1iw20FJQWLWDNOSX+jz9sUhx/NZKb3Mb vK3cRY5lYZ47wDHW1ir35Uju6VklTBCocftf34/EFs+CWevx8Q/9MBeUTycpl8QX/gJRgtsslPdYM 2qFk4tEzfVnp1/acXm0nwGocB73igdTmA0yLQz/Rp0Bh68U5lwYuJbqsJgeY31K9Fj0KuVybJDIPL 3yJZMsAPeYYtXstSRMkw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1guJPr-000275-3N; Thu, 14 Feb 2019 15:59:11 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1guJPn-00026g-UI for linux-riscv@lists.infradead.org; Thu, 14 Feb 2019 15:59:09 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1guJPk-0005T9-Uj; Thu, 14 Feb 2019 16:59:04 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1guJPj-0004KM-Rg; Thu, 14 Feb 2019 16:59:04 +0100 Date: Thu, 14 Feb 2019 16:59:03 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Thierry Reding Subject: Re: [PATCH v5 2/2] pwm: sifive: Add a driver for SiFive SoC PWM Message-ID: <20190214155903.7h3b7v3nbhj57uy2@pengutronix.de> References: <1548762199-7065-1-git-send-email-yash.shah@sifive.com> <1548762199-7065-3-git-send-email-yash.shah@sifive.com> <20190207101657.rfzcq6xdv6ocvubg@pengutronix.de> <20190213123703.GE647@ulmo> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190213123703.GE647@ulmo> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-riscv@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190214_075908_135041_7D60F997 X-CRM114-Status: GOOD ( 14.11 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, palmer@sifive.com, linux-kernel@vger.kernel.org, sachin.ghadi@sifive.com, Yash Shah , robh+dt@kernel.org, paul.walmsley@sifive.com, linux-riscv@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Feb 13, 2019 at 01:37:03PM +0100, Thierry Reding wrote: > On Thu, Feb 07, 2019 at 11:16:57AM +0100, Uwe Kleine-K=F6nig wrote: > > On Tue, Jan 29, 2019 at 05:13:19PM +0530, Yash Shah wrote: > [...] > > > diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c > [...] > > > + writel(val, pwm->regs + PWM_SIFIVE_PWMCFG); > > > + > > > + writel(frac, pwm->regs + PWM_SIFIVE_PWMCMP0 + dev->hwpwm * SIZE_PWM= CMP); > > > + > > > + val &=3D ~(1 << PWM_SIFIVE_PWMCFG_DEGLITCH); > > > + writel(val, pwm->regs + PWM_SIFIVE_PWMCFG); > > > + > > > + pwm_sifive_get_state(chip, dev, state); > > = > > Thierry: This changes the pwm_state. Is this how this should be done? > = > Yes, I think that's fine. The PWM state should always reflect the > current hardware state. If the configuration that we program does not > reflect the state that was requested, that should be reflected in the > PWM state. I'm not sure you blessed what is really done here. If I do: state.duty_cycle =3D state.period; pwm_apply_state(pwm, &state); the call in question doesn't only result in pwm->state.duty_cycle < pwm->state.period, but it also corrects my local state variable (i.e. I have state.duty_cycle < state.period afterwards). Is this what you thought to be fine? Also note that v6 dropped that call because of my doubts. Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv