From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31156C43381 for ; Fri, 22 Mar 2019 13:33:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00DC02083D for ; Fri, 22 Mar 2019 13:33:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hhEEib90" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00DC02083D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/ZBOklNGbHn+kwQm2E+7G84v5ZDlkdHWUDqlt14WGcE=; b=hhEEib90+EQmfB eY7DSe+5iBFmQULK2QFyLCuBfZujoP+vzUDLFYEBfDmUL/LNzyZw7T1w70s34k6u3/h2NZqRciplt JJgFbIjYj6urUTBORD89A6rG5FnPWSFari3zSHBC5tUCMBy3P4CK8k5YEMGd19BQ4RHB/e1TG6YuN iVMn3NqeS9E03X5921l3VfZ8ETNB8Qs5cLoQnxFTxr29qv48G9lAznkvcYHmpMSXkQ1HL/GecMEv8 1mgjRlauWqxEOxY0/MHnFGxL6/uLsvrr/lPyeDUCmYyvlzhFJNabCjaFw4qr7agm0LujWjfOExy/P OhSbNfs34t+TQMSfYjrA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h7KIe-0002qU-9A; Fri, 22 Mar 2019 13:33:32 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1h7KIc-0002q8-QA; Fri, 22 Mar 2019 13:33:30 +0000 Date: Fri, 22 Mar 2019 06:33:30 -0700 From: Christoph Hellwig To: Anup Patel Subject: Re: [PATCH v2 4/5] RISC-V: Remove redundant trampoline page table Message-ID: <20190322133330.GB32464@infradead.org> References: <20190321094710.16552-1-anup.patel@wdc.com> <20190321094710.16552-5-anup.patel@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190321094710.16552-5-anup.patel@wdc.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Albert Ou , Palmer Dabbelt , "linux-kernel@vger.kernel.org" , Mike Rapoport , Christoph Hellwig , Atish Patra , Paul Walmsley , "linux-riscv@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org > > - /* Compute satp for kernel page tables, but don't load it yet */ > + /* Compute satp for kernel page directory, but don't load it yet */ > /* > - * Load trampoline page directory, which will cause us to trap to > + * Load kernel page directory, which will cause us to trap to > * stvec if VA != PA, or simply fall through if VA == PA > */ If we want to nitpick comments I think this should take about the page table root or something like that. Otherwise the idea looks good, but I really think we should do this before all the changes to the setup_vm code. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv