From: Borislav Petkov <bp@alien8.de>
To: Paul Walmsley <paul.walmsley@sifive.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
aou@eecs.berkeley.edu, palmer@sifive.com,
linux-kernel@vger.kernel.org, sachin.ghadi@sifive.com,
Yash Shah <yash.shah@sifive.com>,
robh+dt@kernel.org, linux-riscv@lists.infradead.org,
mchehab@kernel.org, linux-edac@vger.kernel.org
Subject: Re: [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip
Date: Mon, 25 Mar 2019 07:57:37 +0100 [thread overview]
Message-ID: <20190325065737.GD12016@zn.tnic> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1903241558210.8028@viisi.sifive.com>
On Sun, Mar 24, 2019 at 05:23:27PM -0700, Paul Walmsley wrote:
> > + if (!IS_ENABLED(CONFIG_EDAC_DEBUG))
> > + return;
>
> Can all of these debugfs functions be wrapped with an #if ... #endif such
> that, if CONFIG_EDAC_DEBUG is not set, they will all be stripped out by
> the preprocessor?
Why would you make the code more ugly with ifdeffery?
Do you have any serious code size constraints so that you absolutely
need to remove a couple of KBs?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-03-25 6:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 11:52 [PATCH 0/2] EDAC Support for SiFive SoCs Yash Shah
2019-03-20 11:52 ` [PATCH 1/2] edac: sifive: Add DT documentation for SiFive EDAC driver and subcomponent Yash Shah
2019-03-25 0:20 ` Paul Walmsley
2019-03-20 11:52 ` [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip Yash Shah
2019-03-21 13:33 ` Borislav Petkov
2019-03-22 6:00 ` Yash Shah
2019-03-25 0:23 ` Paul Walmsley
2019-03-25 6:57 ` Borislav Petkov [this message]
2019-03-25 21:26 ` Paul Walmsley
2019-03-25 21:50 ` Borislav Petkov
2019-03-29 19:45 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325065737.GD12016@zn.tnic \
--to=bp@alien8.de \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sachin.ghadi@sifive.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).