From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB17CC4360F for ; Thu, 4 Apr 2019 14:27:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A35FB20882 for ; Thu, 4 Apr 2019 14:27:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OfKVOWF2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A35FB20882 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NpHXfTuVYIz1pqvKJawbT2rfOJs1o2GnA6X9IuTSIjY=; b=OfKVOWF2wJl7j6 JyoKw2qvMefDHGLjkiDRdPxEfGuD0I8O5FLY3objFasinMHJcSXuJNoHVv+0MOShrvBj9M3MtN2m7 fjG/kh0O72lNYpoakuojnJP1NQZJ5d62KhvEj4MSmAQHLixtlSD/C/nLmLVUYnaw6MDx67lwDrlmv 62vTzODb92wO9QW2wRL8SVhI10q5mB0mZFr9Kz1ShSyv3p05Hi/t3ZFhp4CJgdoAeUMtKUczbfyhl +04svdc7Pm4Uz4g0oZTHZw6pHB10DB6vdLXcSdeS+kJz+EI+qkbJwCTyvJ7SyrdF3vEEhJpSXejlX w59N0xuZfoAtIKikNzLA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hC3KW-00082n-9V; Thu, 04 Apr 2019 14:27:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hC3KT-00082A-Ac for linux-riscv@lists.infradead.org; Thu, 04 Apr 2019 14:26:59 +0000 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95E882171F; Thu, 4 Apr 2019 14:26:54 +0000 (UTC) Date: Thu, 4 Apr 2019 10:26:53 -0400 From: Steven Rostedt To: "Dmitry V. Levin" Subject: Re: [PATCH 3/6 v3] riscv: Fix syscall_get_arguments() and syscall_set_arguments() Message-ID: <20190404102653.705456df@gandalf.local.home> In-Reply-To: <20190404140210.GC4962@altlinux.org> References: <20190401134104.676620247@goodmis.org> <20190401134420.958530155@goodmis.org> <20190404140210.GC4962@altlinux.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190404_072657_380607_EFA39E60 X-CRM114-Status: GOOD ( 13.36 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Gustavo A. R. Silva" , Peter Zijlstra , Palmer Dabbelt , Dominik Brodowski , Oleg Nesterov , "H. Peter Anvin" , linux-riscv@lists.infradead.org, Ingo Molnar , linux-arch@vger.kernel.org, x86@kernel.org, Ingo Molnar , Albert Ou , Kees Cook , Roland McGrath , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Will Drewry , linux-kernel@vger.kernel.org, Andy Lutomirski , "Eric W. Biederman" , Andrew Morton , Linus Torvalds Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, 4 Apr 2019 17:02:10 +0300 "Dmitry V. Levin" wrote: > On Mon, Apr 01, 2019 at 09:41:07AM -0400, Steven Rostedt wrote: > > From: "Dmitry V. Levin" > > > > RISC-V syscall arguments are located in orig_a0,a1..a5 fields > > of struct pt_regs. > > > > Due to an off-by-one bug and a bug in pointer arithmetic > > syscall_get_arguments() was reading s3..s7 fields instead of a1..a5. > > Likewise, syscall_set_arguments() was writing s3..s7 fields > > instead of a1..a5. > > > > Link: http://lkml.kernel.org/r/20190329171221.GA32456@altlinux.org > > > > Fixes: e2c0cdfba7f69 ("RISC-V: User-facing API") > > Cc: Ingo Molnar > > Cc: Kees Cook > > Cc: Andy Lutomirski > > Cc: Will Drewry > > Cc: Palmer Dabbelt > > Cc: Albert Ou > > Cc: linux-riscv@lists.infradead.org > > Cc: stable@vger.kernel.org # v4.15+ > > Signed-off-by: Dmitry V. Levin > > Signed-off-by: Steven Rostedt (VMware) > > According to > https://lore.kernel.org/lkml/mhng-8e9b547b-7fe3-43d2-9dea-b217de923605@palmer-si-x1c4/ > the following tag could be added to this patch: > > Acked-by: Palmer Dabbelt That link isn't actually an ack. Palmer, you OK if I add it? -- Steve _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv