From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEF72C10F13 for ; Thu, 11 Apr 2019 16:17:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 866532146F for ; Thu, 11 Apr 2019 16:17:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qF9uwyWH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 866532146F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s5EDc9gRhB7d/O8NYf5yxBTikz0hjFu8+qCcS0H94JQ=; b=qF9uwyWHNSS/1S kHh7CYPw+z3WPzLsZHQIAh18VPGK6wCSaieYr/k035PLyZJJ0x7hy9JlqcQKZ4oQNnUy6rZ5miNwP 0C9mUEXnHAoG6HD5wlK8GTvbxJ0mKCED8TFou5gx7YfbbR2z0PAFTxn8M6wSLNjJdwc9CcmQWRFka obLcFAhfToCzhD0i0SULowlLxyfgEkh/e4AH5so9U9Kc0CXtcY2HJIJ136SuFoEcWzQ+bqBbLWII3 f5a5aofLGjo5wmDASmdOGTGgdgR3rhLG+E6fTUeLuCy+BbW8MEupOzp4tSPsbb5gOQFWCMF9IA21F 7MQyjNcejBNRDmiMELWA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEcOA-000737-HY; Thu, 11 Apr 2019 16:17:22 +0000 Received: from verein.lst.de ([213.95.11.211] helo=newverein.lst.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEcO7-00071a-3p for linux-riscv@lists.infradead.org; Thu, 11 Apr 2019 16:17:20 +0000 Received: by newverein.lst.de (Postfix, from userid 2407) id 78B7768AFE; Thu, 11 Apr 2019 18:17:06 +0200 (CEST) Date: Thu, 11 Apr 2019 18:17:06 +0200 From: Christoph Hellwig To: Nick Kossifidis Subject: Re: [PATCH 7/9] riscv: remove duplicate macros from ptrace.h Message-ID: <20190411161706.GA25465@lst.de> References: <20190411115623.5749-1-hch@lst.de> <20190411115623.5749-8-hch@lst.de> <25d179157667295a1cb1bf53e5eb66ee@mailhost.ics.forth.gr> <8e0db47120668612b1814504a7054462@mailhost.ics.forth.gr> <2a436f2edd8c1ad0ae32ec05415475e9@mailhost.ics.forth.gr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2a436f2edd8c1ad0ae32ec05415475e9@mailhost.ics.forth.gr> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_091719_298382_EEC1BCC7 X-CRM114-Status: UNSURE ( 8.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-riscv@lists.infradead.org, Palmer Dabbelt , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Apr 11, 2019 at 07:03:48PM +0300, Nick Kossifidis wrote: > I'm sorry I added the Reviewed-by tag too soon, I'm all in for the cleanup > but I > believe it's much simpler, all of these are re-defined on > include/asm-generic/ptrace.h anyway, all we have to do is define GET_FP and > GET_USP > (or rename regs->sp to regs->usp). We don't use include/asm-generic/ptrace.h on RISC-V, and I don't really see a good reason to start using it. Quite to the contrary, I think we can remove that file and apply a similar cleanup as in this patch to the few architectures currently using it. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv