From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E096C28CC2 for ; Wed, 29 May 2019 15:53:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 600FD23C7F for ; Wed, 29 May 2019 15:53:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GBweS2BG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="h6PS64mr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 600FD23C7F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=T5UjEhb1Z9vhQxe14fTrhPTmUd1+qC6kT3Xwp0MkZ5I=; b=GBweS2BG8ofNu4 vP7li+8EyGafFBMbWK3d95y4C2jLOWf4K5RrN/EQCaMVp76l6g768nsXKKcnje4M3/fOe9TnQoWGr SESP586wpIoxuagibfKRIBkce63dfsUFT/BKJfPYWLwHoyEgY/rSdPt/X9jJSnXTp7yPCllm9JBld K6vIJBotg46dMBmvn/TGyO7yV/R6b9tN2H1ip3L37V0UsxfpeFHITmDi49fODRVdR4LqSAweEP0zk s4jGhZEAM/A4CDO+dVwQmNELJ6AT2JC1mcas4PS6Va81QSi55Hp+tnvxHAROkMdu6cyh0DZEnh96h LP5vR3HPeHek01Sk3wDw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hW0tn-0002Fg-7R; Wed, 29 May 2019 15:53:55 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hW0tk-0002FI-CZ for linux-riscv@lists.infradead.org; Wed, 29 May 2019 15:53:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=im4MQHdQK9abJhFH96Zbr5c+k47agNl/ENbT8u/aulo=; b=h6PS64mrTgGbG4Ret1T5AIq1SJ qHzYF0KVZCnABwd26ouHy3ZvILTLsxHkVtScmLehUBNV89GfAYMmnYIN31/q+rAaVxVxch1BfhByN 2UvZUV41MEuFMLA4xnOneyoI72Z27dGowbwwN8RN8JF+KYyuRRSvsvVVft/pw0UQz79U=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hW0te-0000n6-6j; Wed, 29 May 2019 17:53:46 +0200 Date: Wed, 29 May 2019 17:53:46 +0200 From: Andrew Lunn To: Sagar Shrikant Kadam Subject: Re: [PATCH v8 3/3] i2c-ocores: sifive: add polling mode workaround for FU540-C000 SoC. Message-ID: <20190529155346.GA18059@lunn.ch> References: <1559104047-13920-1-git-send-email-sagar.kadam@sifive.com> <1559104047-13920-4-git-send-email-sagar.kadam@sifive.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1559104047-13920-4-git-send-email-sagar.kadam@sifive.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190529_085352_582936_0EF55BE1 X-CRM114-Status: UNSURE ( 9.81 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, peter@korsgaard.com, palmer@sifive.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-i2c@vger.kernel.org, paul.walmsley@sifive.com, linux-riscv@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, May 29, 2019 at 09:57:27AM +0530, Sagar Shrikant Kadam wrote: > The i2c-ocore driver already has a polling mode interface.But it needs > a workaround for FU540 Chipset on HiFive unleashed board (RevA00). > There is an erratum in FU540 chip that prevents interrupt driven i2c > transfers from working, and also the I2C controller's interrupt bit > cannot be cleared if set, due to this the existing i2c polling mode > interface added in mainline earlier doesn't work, and CPU stall's > infinitely, when-ever i2c transfer is initiated. > > Ref: > commit dd7dbf0eb090 ("i2c: ocores: refactor setup for polling") > > The workaround / fix under OCORES_FLAG_BROKEN_IRQ is particularly for > FU540-COOO SoC. > > The polling function identifies a SiFive device based on the device node > and enables the workaround. > > Signed-off-by: Sagar Shrikant Kadam Hi Sagar When you repost, you are supposed to add any reviewed-by, or acked-by tags you received. Andrew _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv