From: "hch@lst.de" <hch@lst.de>
To: Atish Patra <Atish.Patra@wdc.com>
Cc: "linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"palmer@sifive.com" <palmer@sifive.com>,
"hch@lst.de" <hch@lst.de>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>
Subject: Re: [PATCH 5/8] riscv: actually clear icache_stale_mask for all harts in mm_cpumask
Date: Mon, 26 Aug 2019 13:41:23 +0200 [thread overview]
Message-ID: <20190826114123.GF15002@lst.de> (raw)
In-Reply-To: <53f59546a691888c07bfb16780c6d5550b4be4fe.camel@wdc.com>
On Thu, Aug 22, 2019 at 06:29:35PM +0000, Atish Patra wrote:
> I guess you have added cpu_possible_mask keeping cpu hotplug in mind
> for future.
>
> I think it should be cpu_present_mask instead of cpu_possible_mask as
> they can be different in case where some cpus are just waiting in the
> boot loader.
I don't think it matters. The only place where we actually check
icache_stale_mask is in flush_icache_deferred, which only does
a cpumask_test_cpu for the currently running CPU. So I'd rather
opt for setting a few more bits and prepare for cpu hotplug.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-08-26 11:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 6:56 sys_riscv_flush_icache Christoph Hellwig
2019-08-22 6:56 ` [PATCH 1/8] riscv: fix the flags argument type for riscv_riscv_flush_icache Christoph Hellwig
2019-08-22 6:56 ` [PATCH 2/8] riscv: remove SYS_RISCV_FLUSH_ICACHE_LOCAL #define Christoph Hellwig
2019-08-22 6:56 ` [PATCH 3/8] riscv: move sys_riscv_flush_icache to cacheflush.c Christoph Hellwig
2019-08-22 6:56 ` [PATCH 4/8] riscv: remove the active_mm check in sys_riscv_flush_icache Christoph Hellwig
2019-08-22 6:56 ` [PATCH 5/8] riscv: actually clear icache_stale_mask for all harts in mm_cpumask Christoph Hellwig
2019-08-22 18:29 ` Atish Patra
2019-08-26 11:41 ` hch [this message]
2019-08-22 6:56 ` [PATCH 6/8] riscv: use get_cpu and put_cpu in sys_riscv_flush_icache Christoph Hellwig
2019-08-22 17:49 ` Atish Patra
2019-08-26 11:38 ` hch
2019-08-27 18:42 ` Atish Patra
2019-08-22 6:56 ` [PATCH 7/8] riscv: improve the local flushing logic " Christoph Hellwig
2019-08-22 17:34 ` Atish Patra
2019-08-26 11:36 ` hch
2019-08-22 6:56 ` [PATCH 8/8] riscv: ignore the SYS_RISCV_FLUSH_ICACHE_LOCAL flag Christoph Hellwig
2019-08-28 1:10 ` Palmer Dabbelt
2019-08-28 6:09 ` Christoph Hellwig
2019-09-03 18:46 ` Palmer Dabbelt
2019-09-06 17:07 ` Christoph Hellwig
2019-09-13 19:44 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826114123.GF15002@lst.de \
--to=hch@lst.de \
--cc=Atish.Patra@wdc.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).