From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF166C3A5A3 for ; Wed, 28 Aug 2019 03:07:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B362C214DA for ; Wed, 28 Aug 2019 03:07:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BMm09zv6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B362C214DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nTv3jIF23uoeaiEtg8+vjvqw5PNJAW+uJSJBL7cRwTQ=; b=BMm09zv635aio3 Tu4wRTXozgHJ7RQBUBwgen0XiIqztf1GwzFS2kDqgkDS7vfjqlcXPk705xxTnvibr50uJhwfwGFa6 29AQvXaGwBKLY0MZYzhmBsItVGJbpQvEpvvZTkkidbJ+pBLSlPxNXn2LDTZ2prLWAwZYAibGQ9jXc k3OfGF+f6luGnz+7wPvm2fuyO2RJU37uP3ccn7F1VrAZx9GLl6oi32we9AdBCRwy45G7xSEYPNHiz 84jXJnQpqfvhCmABDy1Rw21vovPzHc6LMjHF5UfsIkJuVc3BEnvdQnMl0x78qcJ38nT5c2sMLzRys t3uK+0B5rDPCF5Tv/THQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2oJ9-00066h-7G; Wed, 28 Aug 2019 03:07:39 +0000 Received: from 59-120-53-16.hinet-ip.hinet.net ([59.120.53.16] helo=ATCSQR.andestech.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2oJ5-000662-Dv for linux-riscv@lists.infradead.org; Wed, 28 Aug 2019 03:07:37 +0000 Received: from mail.andestech.com (atcpcs16.andestech.com [10.0.1.222]) by ATCSQR.andestech.com with ESMTP id x7S2s7NW017694; Wed, 28 Aug 2019 10:54:07 +0800 (GMT-8) (envelope-from nickhu@andestech.com) Received: from andestech.com (10.0.15.65) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.123.3; Wed, 28 Aug 2019 11:06:44 +0800 Date: Wed, 28 Aug 2019 11:06:44 +0800 From: Nick Hu To: Andrey Ryabinin , Paul Walmsley Subject: Re: [PATCH 1/2] riscv: Add memmove string operation. Message-ID: <20190828030644.GA20064@andestech.com> References: <09d5108e-f0ba-13d3-be9e-119f49f6bd85@virtuozzo.com> <20190827090738.GA22972@andestech.com> <92dd5f5f-c8a2-53c3-4d61-44acc4366844@virtuozzo.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <92dd5f5f-c8a2-53c3-4d61-44acc4366844@virtuozzo.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.0.15.65] X-DNSRBL: X-MAIL: ATCSQR.andestech.com x7S2s7NW017694 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190827_200735_733062_CB67B306 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "aou@eecs.berkeley.edu" , Alan Quey-Liang =?utf-8?B?S2FvKOmrmOmtgeiJryk=?= , "atish.patra@wdc.com" , "gregkh@linuxfoundation.org" , "palmer@sifive.com" , "linux-kernel@vger.kernel.org" , "kasan-dev@googlegroups.com" , =?utf-8?B?6Zui6IG3Wm9uZyBab25nLVhpYW4gTGko5p2O5a6X5oayKQ==?= , "alexios.zavras@intel.com" , "Anup.Patel@wdc.com" , "glider@google.com" , "green.hu@gmail.com" , "paul.walmsley@sifive.com" , "tglx@linutronix.de" , "deanbo422@gmail.com" , "linux-riscv@lists.infradead.org" , "dvyukov@google.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org Hi Paul, On Tue, Aug 27, 2019 at 05:33:11PM +0800, Andrey Ryabinin wrote: > > > On 8/27/19 12:07 PM, Nick Hu wrote: > > Hi Andrey > > > > On Thu, Aug 22, 2019 at 11:59:02PM +0800, Andrey Ryabinin wrote: > >> On 8/7/19 10:19 AM, Nick Hu wrote: > >>> There are some features which need this string operation for compilation, > >>> like KASAN. So the purpose of this porting is for the features like KASAN > >>> which cannot be compiled without it. > >>> > >> > >> Compilation error can be fixed by diff bellow (I didn't test it). > >> If you don't need memmove very early (before kasan_early_init()) than arch-specific not-instrumented memmove() > >> isn't necessary to have. > >> > >> --- > >> mm/kasan/common.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/mm/kasan/common.c b/mm/kasan/common.c > >> index 6814d6d6a023..897f9520bab3 100644 > >> --- a/mm/kasan/common.c > >> +++ b/mm/kasan/common.c > >> @@ -107,6 +107,7 @@ void *memset(void *addr, int c, size_t len) > >> return __memset(addr, c, len); > >> } > >> > >> +#ifdef __HAVE_ARCH_MEMMOVE > >> #undef memmove > >> void *memmove(void *dest, const void *src, size_t len) > >> { > >> @@ -115,6 +116,7 @@ void *memmove(void *dest, const void *src, size_t len) > >> > >> return __memmove(dest, src, len); > >> } > >> +#endif > >> > >> #undef memcpy > >> void *memcpy(void *dest, const void *src, size_t len) > >> -- > >> 2.21.0 > >> > >> > >> > > I have confirmed that the string operations are not used before kasan_early_init(). > > But I can't make sure whether other ARCHs would need it before kasan_early_init(). > > Do you have any idea to check that? Should I cc all other ARCH maintainers? > > > This doesn't affect other ARCHes in any way. If other arches have their own not-instrumented > memmove implementation (and they do), they will continue to be able to use it early. I prefer Andrey's method since porting the generic string operations with newlib ones should be a separated patch from KASAN. Nick _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv