* [PATCH -next] pwm: sifive: Remove redundant dev_err call in pwm_sifive_probe()
@ 2019-09-04 11:18 Wei Yongjun
2019-09-04 12:10 ` Yash Shah
2019-09-04 16:35 ` Uwe Kleine-König
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2019-09-04 11:18 UTC (permalink / raw)
To: Thierry Reding, Palmer Dabbelt, Paul Walmsley
Cc: kernel-janitors, linux-pwm, linux-riscv, Wei Yongjun
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/pwm/pwm-sifive.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c
index a7c107f19e66..8fcd05e74581 100644
--- a/drivers/pwm/pwm-sifive.c
+++ b/drivers/pwm/pwm-sifive.c
@@ -250,10 +250,8 @@ static int pwm_sifive_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
ddata->regs = devm_ioremap_resource(dev, res);
- if (IS_ERR(ddata->regs)) {
- dev_err(dev, "Unable to map IO resources\n");
+ if (IS_ERR(ddata->regs))
return PTR_ERR(ddata->regs);
- }
ddata->clk = devm_clk_get(dev, NULL);
if (IS_ERR(ddata->clk)) {
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] pwm: sifive: Remove redundant dev_err call in pwm_sifive_probe()
2019-09-04 11:18 [PATCH -next] pwm: sifive: Remove redundant dev_err call in pwm_sifive_probe() Wei Yongjun
@ 2019-09-04 12:10 ` Yash Shah
2019-09-04 16:35 ` Uwe Kleine-König
1 sibling, 0 replies; 3+ messages in thread
From: Yash Shah @ 2019-09-04 12:10 UTC (permalink / raw)
To: Wei Yongjun
Cc: linux-pwm, Palmer Dabbelt, kernel-janitors, Thierry Reding,
Paul Walmsley, linux-riscv
On Wed, Sep 4, 2019 at 4:31 PM Wei Yongjun <weiyongjun1@huawei.com> wrote:
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/pwm/pwm-sifive.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Reviewed-by: Yash Shah <yash.shah@sifive.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] pwm: sifive: Remove redundant dev_err call in pwm_sifive_probe()
2019-09-04 11:18 [PATCH -next] pwm: sifive: Remove redundant dev_err call in pwm_sifive_probe() Wei Yongjun
2019-09-04 12:10 ` Yash Shah
@ 2019-09-04 16:35 ` Uwe Kleine-König
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2019-09-04 16:35 UTC (permalink / raw)
To: Wei Yongjun
Cc: linux-pwm, Palmer Dabbelt, kernel-janitors, Thierry Reding,
Paul Walmsley, linux-riscv
Hello,
On Wed, Sep 04, 2019 at 11:18:36AM +0000, Wei Yongjun wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
that's right
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-04 16:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-04 11:18 [PATCH -next] pwm: sifive: Remove redundant dev_err call in pwm_sifive_probe() Wei Yongjun
2019-09-04 12:10 ` Yash Shah
2019-09-04 16:35 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).