* [PATCH 0/2] Enable Goldfish RTC for RISC-V
@ 2019-09-25 4:29 Anup Patel
2019-09-25 4:30 ` [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV Anup Patel
2019-09-25 4:30 ` [PATCH 2/2] RISC-V: defconfig: Enable Goldfish RTC driver Anup Patel
0 siblings, 2 replies; 7+ messages in thread
From: Anup Patel @ 2019-09-25 4:29 UTC (permalink / raw)
To: Palmer Dabbelt, Paul Walmsley, Albert Ou, Greg Kroah-Hartman,
Roman Kiryanov
Cc: Anup Patel, Anup Patel, linux-kernel, Christoph Hellwig,
Atish Patra, Alistair Francis, linux-riscv
We will be using Goldfish RTC device real date-time on QEMU RISC-V virt
machine so this series:
1. Allows GOLDFISH kconfig option to be enabled for RISC-V
2. Enables GOLDFISH RTC driver in RISC-V defconfigs
This series can be found in goldfish_rtc_v1 branch at:
https//github.com/avpatel/linux.git
For the QEMU patches adding Goldfish RTC to virt machine refer:
https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg05465.html
Anup Patel (2):
platform: goldfish: Allow goldfish virtual platform drivers for RISCV
RISC-V: defconfig: Enable Goldfish RTC driver
arch/riscv/configs/defconfig | 3 +++
arch/riscv/configs/rv32_defconfig | 3 +++
drivers/platform/goldfish/Kconfig | 2 +-
3 files changed, 7 insertions(+), 1 deletion(-)
--
2.17.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV
2019-09-25 4:29 [PATCH 0/2] Enable Goldfish RTC for RISC-V Anup Patel
@ 2019-09-25 4:30 ` Anup Patel
2019-09-25 4:43 ` Greg Kroah-Hartman
2019-09-25 4:30 ` [PATCH 2/2] RISC-V: defconfig: Enable Goldfish RTC driver Anup Patel
1 sibling, 1 reply; 7+ messages in thread
From: Anup Patel @ 2019-09-25 4:30 UTC (permalink / raw)
To: Palmer Dabbelt, Paul Walmsley, Albert Ou, Greg Kroah-Hartman,
Roman Kiryanov
Cc: Anup Patel, Anup Patel, linux-kernel, Christoph Hellwig,
Atish Patra, Alistair Francis, linux-riscv
We will be using some of the Goldfish virtual platform devices (such
as RTC) on QEMU RISC-V virt machine so this patch enables goldfish
kconfig option for RISC-V architecture.
Signed-off-by: Anup Patel <anup.patel@wdc.com>
---
drivers/platform/goldfish/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/goldfish/Kconfig b/drivers/platform/goldfish/Kconfig
index 77b35df3a801..0ba825030ffe 100644
--- a/drivers/platform/goldfish/Kconfig
+++ b/drivers/platform/goldfish/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
menuconfig GOLDFISH
bool "Platform support for Goldfish virtual devices"
- depends on X86_32 || X86_64 || ARM || ARM64 || MIPS
+ depends on X86_32 || X86_64 || ARM || ARM64 || MIPS || RISCV
depends on HAS_IOMEM
help
Say Y here to get to see options for the Goldfish virtual platform.
--
2.17.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] RISC-V: defconfig: Enable Goldfish RTC driver
2019-09-25 4:29 [PATCH 0/2] Enable Goldfish RTC for RISC-V Anup Patel
2019-09-25 4:30 ` [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV Anup Patel
@ 2019-09-25 4:30 ` Anup Patel
1 sibling, 0 replies; 7+ messages in thread
From: Anup Patel @ 2019-09-25 4:30 UTC (permalink / raw)
To: Palmer Dabbelt, Paul Walmsley, Albert Ou, Greg Kroah-Hartman,
Roman Kiryanov
Cc: Anup Patel, Anup Patel, linux-kernel, Christoph Hellwig,
Atish Patra, Alistair Francis, linux-riscv
We have Goldfish RTC device available on QEMU RISC-V virt machine
hence enable required driver in RV32 and RV64 defconfigs.
Signed-off-by: Anup Patel <anup.patel@wdc.com>
---
arch/riscv/configs/defconfig | 3 +++
arch/riscv/configs/rv32_defconfig | 3 +++
2 files changed, 6 insertions(+)
diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
index 3efff552a261..57b4f67b0c0b 100644
--- a/arch/riscv/configs/defconfig
+++ b/arch/riscv/configs/defconfig
@@ -73,7 +73,10 @@ CONFIG_USB_STORAGE=y
CONFIG_USB_UAS=y
CONFIG_MMC=y
CONFIG_MMC_SPI=y
+CONFIG_RTC_CLASS=y
+CONFIG_RTC_DRV_GOLDFISH=y
CONFIG_VIRTIO_MMIO=y
+CONFIG_GOLDFISH=y
CONFIG_EXT4_FS=y
CONFIG_EXT4_FS_POSIX_ACL=y
CONFIG_AUTOFS4_FS=y
diff --git a/arch/riscv/configs/rv32_defconfig b/arch/riscv/configs/rv32_defconfig
index 7da93e494445..50716c1395aa 100644
--- a/arch/riscv/configs/rv32_defconfig
+++ b/arch/riscv/configs/rv32_defconfig
@@ -69,7 +69,10 @@ CONFIG_USB_OHCI_HCD=y
CONFIG_USB_OHCI_HCD_PLATFORM=y
CONFIG_USB_STORAGE=y
CONFIG_USB_UAS=y
+CONFIG_RTC_CLASS=y
+CONFIG_RTC_DRV_GOLDFISH=y
CONFIG_VIRTIO_MMIO=y
+CONFIG_GOLDFISH=y
CONFIG_SIFIVE_PLIC=y
CONFIG_EXT4_FS=y
CONFIG_EXT4_FS_POSIX_ACL=y
--
2.17.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV
2019-09-25 4:30 ` [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV Anup Patel
@ 2019-09-25 4:43 ` Greg Kroah-Hartman
2019-09-25 5:00 ` Anup Patel
0 siblings, 1 reply; 7+ messages in thread
From: Greg Kroah-Hartman @ 2019-09-25 4:43 UTC (permalink / raw)
To: Anup Patel
Cc: Albert Ou, Anup Patel, Palmer Dabbelt, linux-kernel,
Christoph Hellwig, Atish Patra, Alistair Francis, Paul Walmsley,
Roman Kiryanov, linux-riscv
On Wed, Sep 25, 2019 at 04:30:03AM +0000, Anup Patel wrote:
> We will be using some of the Goldfish virtual platform devices (such
> as RTC) on QEMU RISC-V virt machine so this patch enables goldfish
> kconfig option for RISC-V architecture.
>
> Signed-off-by: Anup Patel <anup.patel@wdc.com>
> ---
> drivers/platform/goldfish/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/goldfish/Kconfig b/drivers/platform/goldfish/Kconfig
> index 77b35df3a801..0ba825030ffe 100644
> --- a/drivers/platform/goldfish/Kconfig
> +++ b/drivers/platform/goldfish/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> menuconfig GOLDFISH
> bool "Platform support for Goldfish virtual devices"
> - depends on X86_32 || X86_64 || ARM || ARM64 || MIPS
> + depends on X86_32 || X86_64 || ARM || ARM64 || MIPS || RISCV
Why does this depend on any of these? Can't we just have:
> depends on HAS_IOMEM
And that's it?
thanks,
greg k-h
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV
2019-09-25 4:43 ` Greg Kroah-Hartman
@ 2019-09-25 5:00 ` Anup Patel
2019-09-25 5:06 ` Greg Kroah-Hartman
0 siblings, 1 reply; 7+ messages in thread
From: Anup Patel @ 2019-09-25 5:00 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Palmer Dabbelt, Anup Patel, linux-kernel, Christoph Hellwig,
Atish Patra, Albert Ou, Alistair Francis, Paul Walmsley,
Roman Kiryanov, linux-riscv
On Wed, Sep 25, 2019 at 10:13 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Sep 25, 2019 at 04:30:03AM +0000, Anup Patel wrote:
> > We will be using some of the Goldfish virtual platform devices (such
> > as RTC) on QEMU RISC-V virt machine so this patch enables goldfish
> > kconfig option for RISC-V architecture.
> >
> > Signed-off-by: Anup Patel <anup.patel@wdc.com>
> > ---
> > drivers/platform/goldfish/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/goldfish/Kconfig b/drivers/platform/goldfish/Kconfig
> > index 77b35df3a801..0ba825030ffe 100644
> > --- a/drivers/platform/goldfish/Kconfig
> > +++ b/drivers/platform/goldfish/Kconfig
> > @@ -1,7 +1,7 @@
> > # SPDX-License-Identifier: GPL-2.0-only
> > menuconfig GOLDFISH
> > bool "Platform support for Goldfish virtual devices"
> > - depends on X86_32 || X86_64 || ARM || ARM64 || MIPS
> > + depends on X86_32 || X86_64 || ARM || ARM64 || MIPS || RISCV
>
> Why does this depend on any of these? Can't we just have:
May be Goldfish drivers were compile tested/tried on these architectures only.
>
> > depends on HAS_IOMEM
>
> And that's it?
I think it should be just "depends on HAS_IOMEM && HAS_DMA" just like
VirtIO MMIO. Agree ??
Regards,
Anup
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV
2019-09-25 5:00 ` Anup Patel
@ 2019-09-25 5:06 ` Greg Kroah-Hartman
2019-09-25 5:16 ` Anup Patel
0 siblings, 1 reply; 7+ messages in thread
From: Greg Kroah-Hartman @ 2019-09-25 5:06 UTC (permalink / raw)
To: Anup Patel
Cc: Palmer Dabbelt, Anup Patel, linux-kernel, Christoph Hellwig,
Atish Patra, Albert Ou, Alistair Francis, Paul Walmsley,
Roman Kiryanov, linux-riscv
On Wed, Sep 25, 2019 at 10:30:00AM +0530, Anup Patel wrote:
> On Wed, Sep 25, 2019 at 10:13 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Sep 25, 2019 at 04:30:03AM +0000, Anup Patel wrote:
> > > We will be using some of the Goldfish virtual platform devices (such
> > > as RTC) on QEMU RISC-V virt machine so this patch enables goldfish
> > > kconfig option for RISC-V architecture.
> > >
> > > Signed-off-by: Anup Patel <anup.patel@wdc.com>
> > > ---
> > > drivers/platform/goldfish/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/platform/goldfish/Kconfig b/drivers/platform/goldfish/Kconfig
> > > index 77b35df3a801..0ba825030ffe 100644
> > > --- a/drivers/platform/goldfish/Kconfig
> > > +++ b/drivers/platform/goldfish/Kconfig
> > > @@ -1,7 +1,7 @@
> > > # SPDX-License-Identifier: GPL-2.0-only
> > > menuconfig GOLDFISH
> > > bool "Platform support for Goldfish virtual devices"
> > > - depends on X86_32 || X86_64 || ARM || ARM64 || MIPS
> > > + depends on X86_32 || X86_64 || ARM || ARM64 || MIPS || RISCV
> >
> > Why does this depend on any of these? Can't we just have:
>
> May be Goldfish drivers were compile tested/tried on these architectures only.
True, but that does not mean a driver should only have a specific list
of arches. This should only be needed if you _know_ it doesn't work on
a specific arch, not the other way around.
> > > depends on HAS_IOMEM
> >
> > And that's it?
>
> I think it should be just "depends on HAS_IOMEM && HAS_DMA" just like
> VirtIO MMIO. Agree ??
No idea, but if that's what is needed for building, then sure :)
thanks,
greg k-h
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV
2019-09-25 5:06 ` Greg Kroah-Hartman
@ 2019-09-25 5:16 ` Anup Patel
0 siblings, 0 replies; 7+ messages in thread
From: Anup Patel @ 2019-09-25 5:16 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Palmer Dabbelt, Anup Patel, linux-kernel, Christoph Hellwig,
Atish Patra, Albert Ou, Alistair Francis, Paul Walmsley,
Roman Kiryanov, linux-riscv
On Wed, Sep 25, 2019 at 10:37 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Sep 25, 2019 at 10:30:00AM +0530, Anup Patel wrote:
> > On Wed, Sep 25, 2019 at 10:13 AM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Wed, Sep 25, 2019 at 04:30:03AM +0000, Anup Patel wrote:
> > > > We will be using some of the Goldfish virtual platform devices (such
> > > > as RTC) on QEMU RISC-V virt machine so this patch enables goldfish
> > > > kconfig option for RISC-V architecture.
> > > >
> > > > Signed-off-by: Anup Patel <anup.patel@wdc.com>
> > > > ---
> > > > drivers/platform/goldfish/Kconfig | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/platform/goldfish/Kconfig b/drivers/platform/goldfish/Kconfig
> > > > index 77b35df3a801..0ba825030ffe 100644
> > > > --- a/drivers/platform/goldfish/Kconfig
> > > > +++ b/drivers/platform/goldfish/Kconfig
> > > > @@ -1,7 +1,7 @@
> > > > # SPDX-License-Identifier: GPL-2.0-only
> > > > menuconfig GOLDFISH
> > > > bool "Platform support for Goldfish virtual devices"
> > > > - depends on X86_32 || X86_64 || ARM || ARM64 || MIPS
> > > > + depends on X86_32 || X86_64 || ARM || ARM64 || MIPS || RISCV
> > >
> > > Why does this depend on any of these? Can't we just have:
> >
> > May be Goldfish drivers were compile tested/tried on these architectures only.
>
> True, but that does not mean a driver should only have a specific list
> of arches. This should only be needed if you _know_ it doesn't work on
> a specific arch, not the other way around.
No problem, I will drop depends on various architectures line
>
> > > > depends on HAS_IOMEM
> > >
> > > And that's it?
> >
> > I think it should be just "depends on HAS_IOMEM && HAS_DMA" just like
> > VirtIO MMIO. Agree ??
>
> No idea, but if that's what is needed for building, then sure :)
The Goldfish framebuffer can do DMA access so I add dependency on
HAS_DMA.
Refer, https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT
I will send v2 as-per above.
Regards,
Anup
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-09-25 5:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-25 4:29 [PATCH 0/2] Enable Goldfish RTC for RISC-V Anup Patel
2019-09-25 4:30 ` [PATCH 1/2] platform: goldfish: Allow goldfish virtual platform drivers for RISCV Anup Patel
2019-09-25 4:43 ` Greg Kroah-Hartman
2019-09-25 5:00 ` Anup Patel
2019-09-25 5:06 ` Greg Kroah-Hartman
2019-09-25 5:16 ` Anup Patel
2019-09-25 4:30 ` [PATCH 2/2] RISC-V: defconfig: Enable Goldfish RTC driver Anup Patel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).