From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27358CA9EA0 for ; Fri, 18 Oct 2019 16:00:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFE6721897 for ; Fri, 18 Oct 2019 16:00:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L4qTrfWW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFE6721897 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xnOqo+EFcytJywMslEAxgfCdm8RSzP0/iEkc2QpLDoc=; b=L4qTrfWWSzuro3 SzvflB6EfMmEyjY3WeuDIx/X+3DpuLUWCrOQBln1pbtMphkye1P0rE4pAyT2wNko7LdtcVHJkqtpK TCYOjI4LuCOIYaflAnkg2PXDyyBQ8NiL8MZA8Hv7cEa/HP3ot0xLMGhLKIxEHosvmIg6nUOywiMj0 I/6SZNl0CHZ8nFodg+fSBR46l4nOEcOsqPjWi5jefNtZJAEsxMaDmWeXRpEiMD9o9+XSCEfDuwDmD 77KbBlHHE/KrXRX+Ql5HkP8Y9AuTv/tUEYMo+VUwkX4M/9WFBOD4CvRH+pKF4z75/u7OrsRmau42A n6bSYOs6yeHCeza46maA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLUfX-0001eF-Gn; Fri, 18 Oct 2019 15:59:59 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLUcN-00079R-Og; Fri, 18 Oct 2019 15:56:43 +0000 Date: Fri, 18 Oct 2019 08:56:43 -0700 From: Christoph Hellwig To: Paul Walmsley Subject: Re: [PATCH v3 8/8] riscv: for C functions called only from assembly, mark with __visible Message-ID: <20191018155643.GF25386@infradead.org> References: <20191018080841.26712-1-paul.walmsley@sifive.com> <20191018080841.26712-9-paul.walmsley@sifive.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191018080841.26712-9-paul.walmsley@sifive.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Luc Van Oostenryck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Oct 18, 2019 at 01:08:41AM -0700, Paul Walmsley wrote: > Rather than adding prototypes for C functions called only by assembly > code, mark them as __visible. This avoids adding prototypes that will > never be used by the callers. Resolves the following sparse warnings: > > arch/riscv/kernel/ptrace.c:151:6: warning: symbol 'do_syscall_trace_enter' was not declared. Should it be static? > arch/riscv/kernel/ptrace.c:175:6: warning: symbol 'do_syscall_trace_exit' was not declared. Should it be static? > > Based on a suggestion from Luc Van Oostenryck. > > Signed-off-by: Paul Walmsley > Cc: Luc Van Oostenryck Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv