From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B1BACA9EA0 for ; Fri, 18 Oct 2019 16:00:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27EC52082C for ; Fri, 18 Oct 2019 16:00:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L9XSVEEM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27EC52082C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9sR8pMmUUBiRuHr/hP3cusfo4DyIwG6Hy71WXDiuR5E=; b=L9XSVEEMsOmJEc K5SDee9fmvNfB9uEgVCKN6PlTDeVTMQovUlFP8+yBsWttdW7qK8CDNksKm2zlKCcry/Iy0iK+h7Mh euJXGOgemeIW5uQvW+7HqIHWb44tT2UGZ5EI343h5qWIwikoVZI+VdamB+AmJ5BEoXcLk6Oi37SEs d1XhuBOuSYlo7Tk2TvSzj4nZAJM/nc+0k4E6ahgrN7fovPhoFSveBXFU9PUO6PtGSFdc8q6tmktRb MOd56O+LPCOXYAUo4YAwgHJ0tL9NMHiBge61a9RAXQolARs0JyH/GflIyV8RtZwdfBuJVk9HNR7Bg ok948fGlqiP4/M18URYA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLUfb-0001jW-Q4; Fri, 18 Oct 2019 16:00:03 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLUdL-00086G-K0; Fri, 18 Oct 2019 15:57:43 +0000 Date: Fri, 18 Oct 2019 08:57:43 -0700 From: Christoph Hellwig To: Steven Price Subject: Re: [PATCH v12 07/22] riscv: mm: Add p?d_leaf() definitions Message-ID: <20191018155743.GG25386@infradead.org> References: <20191018101248.33727-1-steven.price@arm.com> <20191018101248.33727-8-steven.price@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191018101248.33727-8-steven.price@arm.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm@kvack.org, Albert Ou , "H. Peter Anvin" , linux-riscv@lists.infradead.org, Will Deacon , "Liang, Kan" , Alexandre Ghiti , x86@kernel.org, Ingo Molnar , Palmer Dabbelt , Arnd Bergmann , =?iso-8859-1?B?Suly9G1l?= Glisse , Borislav Petkov , Andy Lutomirski , Paul Walmsley , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , linux-kernel@vger.kernel.org, James Morse , Andrew Morton Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org > + return pud_present(pud) > + && (pud_val(pud) & (_PAGE_READ | _PAGE_WRITE | _PAGE_EXEC)); > +} The operators always need to go before the line break, not after it per linux coding style. There are a few more spots like this, so please audit the whole series for it. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv