From: Rob Herring <robh@kernel.org>
To: Paul Walmsley <paul.walmsley@sifive.com>, Christoph Hellwig <hch@lst.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
peter.maydell@linaro.org, Sebastian Reichel <sre@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: power: reset: document the QEMU RISC-V virt machine poweroff device
Date: Wed, 13 Nov 2019 19:44:25 -0600 [thread overview]
Message-ID: <20191114014425.GA1748@bogus> (raw)
In-Reply-To: <alpine.DEB.2.21.9999.1911071431390.8918@viisi.sifive.com>
On Thu, Nov 07, 2019 at 02:32:01PM -0800, Paul Walmsley wrote:
> On Thu, 7 Nov 2019, Christoph Hellwig wrote:
>
> > Add the binding for the trivial Qemu RISC-V poweroff mechanism, which is
>
> There's nothing RISC-V specific here. This IP isn't defined in the RISC-V
> specifications, or anything like that.
Does the VM have a spec or anything? Would be nice if it did. Would be
nicer still to just copy Arm's virt machine.
> Apparently it's a SiFive IP block which now has a virtual IP
> implementation in QEMU in hw/riscv/sifive_test.c. But since there's
> nothing RISC-V specific about this IP block, any QEMU system, with any CPU
> implementation, should be able to use this virtual IP, and this Linux
> driver.
>
> For these reasons, it's better if "RISC-V" is just removed from everywhere
> in this driver. If something needs to go in its place, "SiFive" may be
> better.
IIRC, there's already syscon poweroff binding. You could probably use
that.
>
>
> - Paul
>
>
> > just a single MMIO register exposed through the DT.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> > .../power/reset/qemu-riscv-virt-poweroff.txt | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/power/reset/qemu-riscv-virt-poweroff.txt
> >
> > diff --git a/Documentation/devicetree/bindings/power/reset/qemu-riscv-virt-poweroff.txt b/Documentation/devicetree/bindings/power/reset/qemu-riscv-virt-poweroff.txt
> > new file mode 100644
> > index 000000000000..80ff6fd4e3b7
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/reset/qemu-riscv-virt-poweroff.txt
> > @@ -0,0 +1,16 @@
> > +QEMU RISC-V virt machine poweroff device
> > +
> > +This is a device in Qemu that can signal successful or error exit
> > +by writing two magic numbers to a trivial mmio register.
> > +A Linux poweroff is implemented as successful exit.
> > +
> > +Required Properties:
> > +-compatible: "sifive,test0"
> > +-reg: Specifies the physical address of the register
> > +
> > +Example:
> > +
> > + test@100000 {
> > + compatible = "sifive,test0";
> > + reg = <0x100000 0x1000>;
> > + };
> > --
> > 2.20.1
> >
> >
>
>
> - Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-11-14 1:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 21:24 QEMU RISC-V virt machine poweroff driver Christoph Hellwig
2019-11-07 21:24 ` [PATCH 1/2] dt-bindings: power: reset: document the QEMU RISC-V virt machine poweroff device Christoph Hellwig
2019-11-07 21:52 ` Palmer Dabbelt
2019-11-07 22:32 ` Paul Walmsley
2019-11-14 1:44 ` Rob Herring [this message]
2019-11-07 21:24 ` [PATCH 2/2] power: reset: add a QEMU RISC-V virt machine poweroff driver Christoph Hellwig
2019-11-07 21:53 ` Palmer Dabbelt
2019-11-07 22:33 ` Paul Walmsley
2019-11-07 21:56 ` Palmer Dabbelt
2019-11-11 11:36 ` Anup Patel
2019-11-11 16:12 ` Christoph Hellwig
2019-11-11 17:20 ` Paul Walmsley
2019-11-12 4:16 ` Anup Patel
2019-11-14 1:50 ` Rob Herring
2019-11-15 22:14 ` Nick Kossifidis
2019-11-18 6:12 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114014425.GA1748@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-pm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peter.maydell@linaro.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).