From: Guru Das Srinagesh <gurus@codeaurora.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: "Kate Stewart" <kstewart@linuxfoundation.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
linux-fbdev@vger.kernel.org, "David Airlie" <airlied@linux.ie>,
"Wesley W. Terpstra" <wesley@sifive.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Kamil Debski" <kamil@wypas.org>,
dri-devel@lists.freedesktop.org,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Atish Patra" <atish.patra@wdc.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
linux-riscv@lists.infradead.org,
"Lee Jones" <lee.jones@linaro.org>,
linux-clk@vger.kernel.org,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Axel Lin" <axel.lin@ingics.com>, "Arnd Bergmann" <arnd@arndb.de>,
"Alexander Shiyan" <shc_work@mail.ru>,
"Fabio Estevam" <festevam@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Mukesh Ojha" <mojha@codeaurora.org>,
"Gerald Baeza" <gerald.baeza@st.com>,
intel-gfx@lists.freedesktop.org,
"Dan Carpenter" <dan.carpenter@oracle.com>,
linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
"Jean Delvare" <jdelvare@suse.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Mark Brown" <broonie@kernel.org>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Subbaraman Narayanamurthy" <subbaram@codeaurora.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Fabrice Gasnier" <fabrice.gasnier@st.com>,
"Ding Xiang" <dingxiang@cmss.chinamobile.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Allison Randal" <allison@lohutok.net>,
linux-hwmon@vger.kernel.org,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Anson Huang" <Anson.Huang@nxp.com>,
"Richard Fontana" <rfontana@redhat.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
linux-kernel@vger.kernel.org, "Yash Shah" <yash.shah@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Shawn Guo" <shawnguo@kernel.org>
Subject: Re: [PATCH v10 00/12] Convert PWM period and duty cycle to u64
Date: Tue, 31 Mar 2020 12:59:40 -0700 [thread overview]
Message-ID: <20200331195939.GA25781@codeaurora.org> (raw)
In-Reply-To: <20200331134804.xxrjaestztcazalc@holly.lan>
On Tue, Mar 31, 2020 at 02:48:04PM +0100, Daniel Thompson wrote:
> On Mon, Mar 30, 2020 at 02:00:12PM -0700, Guru Das Srinagesh wrote:
> > On Mon, Mar 30, 2020 at 09:26:36PM +0100, Daniel Thompson wrote:
> > > On Mon, Mar 30, 2020 at 12:15:07PM -0700, Guru Das Srinagesh wrote:
> > > > On Sat, Mar 21, 2020 at 02:47:03PM +0300, Dan Carpenter wrote:
> > > > > This is a giant CC list.
> > > >
> > > > Yes, this is because I received feedback [1] on an earlier patchset
> > > > directing me to add the reviewers of patches to the cover letter as
> > > > well so that they get some context for the patch.
> > > > ...
> > > > [1] https://www.spinics.net/lists/linux-pwm/msg11735.html
> > >
> > > Strictly speaking I only asked for backlight maintainers to be Cc:ed.
> > > I was fairly careful to be specific since I'm aware there are a variety
> > > of differing habits when putting together the Cc: list for covering
> > > letters.
> > >
> > > With the original patch header the purpose of the patch I was Cc:ed on
> > > was impossible to determine without the covering letter.
> >
> > I suspect this might be the case for all the other reviewers as well -
> > that they also would appreciate context for the specific patch they are
> > being added to review.
> >
> > I wasn't entirely sure what the convention was, so I applied your
> > suggestion to all the files. How do you suggest I handle this in my next
> > patchset? I fully agree that such a large CC list does look really
> > ungainly.
>
> IHMO there should not be a mechanical convention. Instead your goal
> needs to be how to make it as easy as possible to review your patches.
>
> Think about it this way: Each person in the To: of a patch (and maybe
> also Cc: depending on how you construct things) is a person you are
> asking to review and comment on the patch. If that person will find it
> easier to review the patch if they are included in the cover letter then
> either they should be included or you should improve the patch
> description of the patch itself (sometimes both).
>
> Either way it is about optimizing the patchset for readability. More
> people read them than write them.
Thank you for the explanation! I shall keep your suggestions in mind
while sending out future patchsets.
Thank you.
Guru Das.
prev parent reply other threads:[~2020-03-31 19:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 20:50 [PATCH v10 00/12] Convert PWM period and duty cycle to u64 Guru Das Srinagesh
2020-03-19 20:50 ` [PATCH v10 07/12] pwm: sifive: Use 64-bit division macro Guru Das Srinagesh
2020-03-21 11:47 ` [PATCH v10 00/12] Convert PWM period and duty cycle to u64 Dan Carpenter
2020-03-30 19:15 ` Guru Das Srinagesh
2020-03-30 20:26 ` Daniel Thompson
2020-03-30 21:00 ` Guru Das Srinagesh
2020-03-31 13:48 ` Daniel Thompson
2020-03-31 19:59 ` Guru Das Srinagesh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331195939.GA25781@codeaurora.org \
--to=gurus@codeaurora.org \
--cc=Anson.Huang@nxp.com \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@st.com \
--cc=allison@lohutok.net \
--cc=arnd@arndb.de \
--cc=atish.patra@wdc.com \
--cc=axel.lin@ingics.com \
--cc=b.zolnierkie@samsung.com \
--cc=benjamin.gaignard@linaro.org \
--cc=broonie@kernel.org \
--cc=chris@chris-wilson.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=daniel.thompson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dingxiang@cmss.chinamobile.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabrice.gasnier@st.com \
--cc=festevam@gmail.com \
--cc=gerald.baeza@st.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=jingoohan1@gmail.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kamil@wypas.org \
--cc=kernel@pengutronix.de \
--cc=kstewart@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mojha@codeaurora.org \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rfontana@redhat.com \
--cc=rodrigo.vivi@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=shc_work@mail.ru \
--cc=subbaram@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=uwe@kleine-koenig.org \
--cc=ville.syrjala@linux.intel.com \
--cc=wens@csie.org \
--cc=wesley@sifive.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).