Linux-RISC-V Archive on lore.kernel.org
 help / color / Atom feed
From: Tobias Klauser <tklauser@distanz.ch>
To: "Björn Töpel" <bjorn.topel@gmail.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
	Andreas Schwab <schwab@suse.de>,
	Atish Patra <atish.patra@wdc.com>,
	syzkaller <syzkaller@googlegroups.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	Dmitry Vyukov <dvyukov@google.com>
Subject: Re: syzkaller on risc-v
Date: Wed, 1 Jul 2020 15:52:09 +0200
Message-ID: <20200701135207.pvypbsf3nxwd2j7h@distanz.ch> (raw)
In-Reply-To: <CAJ+HfNjOtCvNZpLGoRaxJn7nfx+hW=cwoyveiu-pwhTjp3-avg@mail.gmail.com>

On 2020-07-01 at 12:43:43 +0200, Björn Töpel <bjorn.topel@gmail.com> wrote:
> On Wed, 1 Jul 2020 at 12:42, Björn Töpel <bjorn.topel@gmail.com> wrote:
> >
> > On Tue, 30 Jun 2020 at 15:27, Dmitry Vyukov <dvyukov@google.com> wrote:
> > >
> > > On Tue, Jun 30, 2020 at 3:14 PM Andreas Schwab <schwab@suse.de> wrote:
> > > >
> > > > On Jun 30 2020, Dmitry Vyukov wrote:
> > > >
> > > > > KASAN would be a prerequisite for testing risc-v on syzbot.
> > > >
> > > > You need to implement the GCC support first.
> > >
> > > Interesting. Björn claimed KASAN works already.  And there is:
> > >
> > > commit 8ad8b72721d0f07fa02dbe71f901743f9c71c8e6
> > > Author: Nick Hu
> > > Date:   Mon Jan 6 10:38:32 2020 -0800
> > >     riscv: Add KASAN support
> > >
> > > Is there any known issue with gcc?
> > > Did anyone try clang? AddressSanitizer pass in clang is
> > > arch-independent. Not sure about gcc... it looked mostly
> > > arch-independent.
> >
> > Weird. Did a quick bisect (just "does it boot with KASAN or not"
> > test), and this fell out:
> >
> > --
> > efca13989250c3edebaf8fcaa8ca7c966739c65a is the first bad commit
> > commit efca13989250c3edebaf8fcaa8ca7c966739c65a
> > Author: Atish Patra <atish.patra@wdc.com>
> > Date:   Tue Mar 17 18:11:37 2020 -0700
> >
> >     RISC-V: Introduce a new config for SBI v0.1
> >
> >     We now have SBI v0.2 which is more scalable and extendable to handle
> >     future needs for RISC-V supervisor interfaces.
> >
> >     Introduce a new config and move all SBI v0.1 code under that config.
> >     This allows to implement the new replacement SBI extensions cleanly
> >     and remove v0.1 extensions easily in future. Currently, the config
> >     is enabled by default. Once all M-mode software, with v0.1, is no
> >     longer in use, this config option and all relevant code can be easily
> >     removed.
> >
> >     Signed-off-by: Atish Patra <atish.patra@wdc.com>
> >     Reviewed-by: Anup Patel <anup@brainfault.org>
> >     Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
> >
> >  arch/riscv/Kconfig           |   7 +++
> >  arch/riscv/include/asm/sbi.h |   2 +
> >  arch/riscv/kernel/sbi.c      | 132 +++++++++++++++++++++++++++++++++++--------
> >  3 files changed, 118 insertions(+), 23 deletions(-)
> > --
> >
> > I'll dig a bit more.
> >
> 
> Oh, forgot one thing; I'm booting the kernel with OpenSBI (OpenSBI
> v0.8-3-gec3e5b14d52a) and not the Berkley loader.

Thanks for the hint regarding OpenSDBI. I just tried it for booting a
kernel built from the riscv for-next branch at commit a2693fe254e7
("RISC-V: Use a local variable instead of smp_processor_id()") with the
following two additional patches:

  https://lore.kernel.org/linux-riscv/20200626124056.29708-1-tklauser@distanz.ch/
  https://lore.kernel.org/linux-riscv/20200627105050.11088-1-tklauser@distanz.ch/

As soon as I enable KASAN (regardless of CONFIG_KCOV being set or not),
it seems to hang after the OpenSBI boot messages, same as when using BBL.

FWIW I sent an update to the syzkaller docs to use OpenSBI instead of
BBL, since that seems to be the recommended way to boot now:

  https://github.com/google/syzkaller/pull/1888

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply index

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30 12:48 Dmitry Vyukov
2020-06-30 12:57 ` Andreas Schwab
2020-06-30 13:26   ` Dmitry Vyukov
2020-06-30 13:33     ` Andreas Schwab
2020-06-30 13:40       ` Dmitry Vyukov
2020-06-30 13:45         ` Andreas Schwab
2020-06-30 13:49           ` Dmitry Vyukov
2020-06-30 13:52             ` Andreas Schwab
2020-07-01 10:42     ` Björn Töpel
2020-07-01 10:43       ` Björn Töpel
2020-07-01 11:34         ` Dmitry Vyukov
2020-07-01 13:52         ` Tobias Klauser [this message]
2020-06-30 13:03 ` Andreas Schwab
2020-06-30 13:26   ` David Abdurachmanov
2020-06-30 13:37     ` Colin Ian King
2020-06-30 13:57       ` David Abdurachmanov
2020-06-30 14:55         ` Andreas Schwab
2020-07-06 10:12         ` Colin Ian King
2020-07-14  1:21           ` Palmer Dabbelt
2020-06-30 13:07 ` Andreas Schwab
2020-06-30 13:20   ` David Abdurachmanov
2020-06-30 13:23     ` Dmitry Vyukov
2020-06-30 13:30     ` Andreas Schwab
2020-06-30 13:35       ` David Abdurachmanov
2020-06-30 13:43         ` Andreas Schwab
2020-07-02 22:00           ` Aurelien Jarno
2020-07-06  8:14             ` Andreas Schwab
2020-06-30 15:10 ` Tobias Klauser
2020-07-01 10:03   ` Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200701135207.pvypbsf3nxwd2j7h@distanz.ch \
    --to=tklauser@distanz.ch \
    --cc=aou@eecs.berkeley.edu \
    --cc=atish.patra@wdc.com \
    --cc=bjorn.topel@gmail.com \
    --cc=dvyukov@google.com \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=schwab@suse.de \
    --cc=syzkaller@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RISC-V Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-riscv/0 linux-riscv/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-riscv linux-riscv/ https://lore.kernel.org/linux-riscv \
		linux-riscv@lists.infradead.org
	public-inbox-index linux-riscv

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-riscv


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git