From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE839C433E0 for ; Sat, 18 Jul 2020 01:39:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5BE12073E for ; Sat, 18 Jul 2020 01:39:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ViTLu/N1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E/K1EvJ3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5BE12073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qxffASI1GaT4n1oug6YQzJtP3rl02B5fawFMYL4GiNU=; b=ViTLu/N1ZwKwsfCmFY7umFwB/ 2r1yZBSyLx6/512C8WuKBmO/1KLgLIfjjYyqNFpwGIixon96Cwp4UMSceP+Od3+ipWx6SmdVvgfId OQbCem2147psLPM8oD31IPW/EXK6ZCK8VJBfuZCV4g2S8ZGOTk9iwU1b/XJA0+R4D91OF62Q9JaB8 2a0hGV5LWDxE1Kla4fIxFAPQt4Sfua69cjbvS6gEB266qWoZDM8Ov7ACMdofGJIUrm/7WFcBdg2DK SBvkk019KLq/Vqpl1PiRUGAgVyWhdb0e0rKA94wS9I/XVAJoB+UGxS5lzbNhvHnnu5aVeJmtbUcw8 1Xegppo/Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwboY-0002OK-3Z; Sat, 18 Jul 2020 01:38:58 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwboV-0002NR-Ds for linux-riscv@lists.infradead.org; Sat, 18 Jul 2020 01:38:56 +0000 Received: by mail-pg1-x543.google.com with SMTP id m22so7461632pgv.9 for ; Fri, 17 Jul 2020 18:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KteNnStqsCqAGcdw9ggpAGeghm53Iiz3RiOfiuEXth4=; b=E/K1EvJ3aO75BbPCj25vCwPKo5cuXB1IMfNWuZqLQUUZdcKcW+OOezlyKt7z/rmQRj tCMRekDZ6z+3Ltmp7EuLj8k1OTEotX0tP04sQu5QyPvVrpLMc3rpstGFhxqeuSGBj0WG HDh2NJzrY16Izwqybb6of8r0gEjZYyw5+rc5nitix2/Bf25quq6STbHvx4VQROHC3hXT nqfZVqIpqZ8ieDjomLko80TX/HQ5JdHtxccIBtqnOnZhmDJ3vAYqJvSZ1KsEpmFoufsQ FF4BHeQOT3foE38dOYi1ZY5fF2qCn3+065HVe5qvgLPolAZdsynLt92uiQpAX43+lsiF 2rKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=KteNnStqsCqAGcdw9ggpAGeghm53Iiz3RiOfiuEXth4=; b=dvQq1kw9bi6SqP+s+mr24rmGf8SF+znSigltt9ZAoe/TRomRpn56Jmm2GkTP4kLGxK kgXn4nky/hbsLXK3ADKleG9NPo0GKooByTqWW8idkrG95qZpCnLqSDjQt/Dfi4VDQLt9 S3tmhgV7PhLzEbY6q7LT3WHzCc6yoZx4TSeE6ac3f9sgECGEonygELtzOGZlJBX/lXSB 1Qi8+TZODzP73fuSkkUpv0yOOAxkkUe+gZR50u60P3nPuWds/10fTB1Uaah4imObw3My 5hCXHCUxVY1JC1PCwLz3szIWwvNn7GnFK87aq4Lv/asNJB84q/Z/rsdP3Na1MfjstM5n JeXg== X-Gm-Message-State: AOAM5302uMdFmm3438679OPdI1wReP+R/0KLT7yVxrKsxLN9ooffBNKJ LhtgiWaj+VDnxEMBCPlEWjQ= X-Google-Smtp-Source: ABdhPJz6DOJ38Rs1B1GFNBSrSmJ5MkwTYCNw130+Arke2nttVtU8/7N5ZRwYUHNS4kq4iZURwTnEQA== X-Received: by 2002:a65:43c1:: with SMTP id n1mr10547707pgp.67.1595036331816; Fri, 17 Jul 2020 18:38:51 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id mv6sm3801237pjb.57.2020.07.17.18.38.50 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Jul 2020 18:38:51 -0700 (PDT) Date: Fri, 17 Jul 2020 18:38:50 -0700 From: Guenter Roeck To: Christoph Hellwig Subject: Re: [PATCH 1/6] syscalls: use uaccess_kernel in addr_limit_user_check Message-ID: <20200718013849.GA157764@roeck-us.net> References: <20200714105505.935079-1-hch@lst.de> <20200714105505.935079-2-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200714105505.935079-2-hch@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200717_213855_480497_A737B057 X-CRM114-Status: GOOD ( 11.06 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Nick Hu , linux-kernel@vger.kernel.org, Palmer Dabbelt , Greentime Hu , Paul Walmsley , Andrew Morton , Vincent Chen , Linus Torvalds , linux-riscv@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi, On Tue, Jul 14, 2020 at 12:55:00PM +0200, Christoph Hellwig wrote: > Use the uaccess_kernel helper instead of duplicating it. > > Signed-off-by: Christoph Hellwig This patch causes a severe hiccup with my mps2-an385 boot test. [ 8.545195] ------------[ cut here ]------------ [ 8.545294] WARNING: CPU: 0 PID: 1 at ./include/linux/syscalls.h:267 addr_limit_check_failed+0x11/0x24 [ 8.545376] Invalid address limit on user-mode return [ 8.545487] CPU: 0 PID: 1 Comm: init Not tainted 5.8.0-rc5-next-20200717 #1 [ 8.545603] Hardware name: MPS2 (Device Tree Support) [ 8.546053] [<2100af9d>] (unwind_backtrace) from [<2100a353>] (show_stack+0xb/0xc) [ 8.546240] [<2100a353>] (show_stack) from [<2100dadb>] (__warn+0x6f/0x80) [ 8.546311] [<2100dadb>] (__warn) from [<2100db1d>] (warn_slowpath_fmt+0x31/0x60) [ 8.546383] [<2100db1d>] (warn_slowpath_fmt) from [<2100a159>] (addr_limit_check_failed+0x11/0x24) [ 8.546464] [<2100a159>] (addr_limit_check_failed) from [<210080f3>] (ret_to_user_from_irq+0xf/0x18) [ 8.546567] Exception stack(0x21427fb0 to 0x21427ff8) [ 8.546649] 7fa0: 00000000 00000000 00000000 00000000 [ 8.546729] 7fc0: 00000000 00000000 00000000 00000000 00000000 00000000 21744f80 00000000 [ 8.546800] 7fe0: 00000000 21757fa8 00000000 21700b6c 01000000 00000000 [ 8.546910] ---[ end trace f1b0cd10cc3456dc ]--- This keeps happening until qemu aborts. Reverting the patch isn't possible since segment_eq() is gone in next-20200717. Guenter --- # bad: [aab7ee9f8ff0110bfcd594b33dc33748dc1baf46] Add linux-next specific files for 20200717 # good: [11ba468877bb23f28956a35e896356252d63c983] Linux 5.8-rc5 git bisect start 'HEAD' 'v5.8-rc5' # good: [4d55a7a1298d197755c1a0f4512f56917e938a83] Merge remote-tracking branch 'crypto/master' git bisect good 4d55a7a1298d197755c1a0f4512f56917e938a83 # good: [e63bf5dcce255302e355cb2277a3a39c83752c92] Merge remote-tracking branch 'devicetree/for-next' git bisect good e63bf5dcce255302e355cb2277a3a39c83752c92 # good: [94d932ec3afb923efd8c736974f8316413175a5b] Merge remote-tracking branch 'thunderbolt/next' git bisect good 94d932ec3afb923efd8c736974f8316413175a5b # good: [5ddd2e0dbe8fceb80b0b36bd38a32217be7a04a5] Merge remote-tracking branch 'livepatching/for-next' git bisect good 5ddd2e0dbe8fceb80b0b36bd38a32217be7a04a5 # bad: [40346f79983caf46fb92f779b0353422d43580a9] ipc/shm.c: Remove the superfluous break git bisect bad 40346f79983caf46fb92f779b0353422d43580a9 # good: [0b917599517f71ddef5f7274a8199a33cecd49b2] kasan: update required compiler versions in documentation git bisect good 0b917599517f71ddef5f7274a8199a33cecd49b2 # good: [701571ae06641cc0632d113a6d25f54ce651e723] mm,hwpoison: rework soft offline for free pages git bisect good 701571ae06641cc0632d113a6d25f54ce651e723 # bad: [1c21deffe923b068d2d297c248845ec93531d1bf] lib/test_bits.c: add tests of GENMASK git bisect bad 1c21deffe923b068d2d297c248845ec93531d1bf # bad: [9549375184b2cb4f63fa7917665acf9c44114499] uaccess: add force_uaccess_{begin,end} helpers git bisect bad 9549375184b2cb4f63fa7917665acf9c44114499 # good: [233d009c15719e43c53b73296144664e0bd59a2e] mm/memory_hotplug: introduce default dummy memory_add_physaddr_to_nid() git bisect good 233d009c15719e43c53b73296144664e0bd59a2e # good: [42889ca325dd735ce964838cff81a444637d9d01] mm: drop duplicated words in git bisect good 42889ca325dd735ce964838cff81a444637d9d01 # bad: [3b17e98704eedeeff41672b2f64cef1bbefbb8b2] nds32: use uaccess_kernel in show_regs git bisect bad 3b17e98704eedeeff41672b2f64cef1bbefbb8b2 # bad: [02dc30b876b111276fe7d83d492ddfc2b39b80e3] syscalls: use uaccess_kernel in addr_limit_user_check git bisect bad 02dc30b876b111276fe7d83d492ddfc2b39b80e3 # first bad commit: [02dc30b876b111276fe7d83d492ddfc2b39b80e3] syscalls: use uaccess_kernel in addr_limit_user_check _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv