From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B3EC433E0 for ; Sat, 18 Jul 2020 09:49:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85B5D20691 for ; Sat, 18 Jul 2020 09:49:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AveF4OB4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85B5D20691 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xf9ZDb2rLzgy14OqwkFFSmRBRxgROGlo+VYdtb3rGoQ=; b=AveF4OB4q6cc9awIdgo3Ry5gu 6WB5m2qz5Ka87QE3y3QfnEa742nCvSNe7KbswrwRa7y379K60NM84wZl3kWdy9WKIiTFhYNjGKRyp SI960Fgqp++WXzda3Uh4zD3TCEbSLXQueyE4wPSKMxtOoM+zY0ZaCU95bfnrDrNMY8BDsxtRdt9yN sctDLGVGUngArCBLNMNBupTe5TVYhcz38DcXvECoOYpHk4LeRQKfs3xY6XMmhJRl4gdmxd5gWGpl+ 05hvZxHawgMSjnrxW8gtzS2CRrp/ZefBhP8hOiAmbqdyapns+E48KwpaIxzkj5GVNOuy/Enq7P8xH ADQcqANzQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwjSj-0005PX-F1; Sat, 18 Jul 2020 09:48:57 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwjSg-0005O8-1s for linux-riscv@lists.infradead.org; Sat, 18 Jul 2020 09:48:55 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 0A28768BEB; Sat, 18 Jul 2020 11:48:46 +0200 (CEST) Date: Sat, 18 Jul 2020 11:48:46 +0200 From: Christoph Hellwig To: Guenter Roeck Subject: Re: [PATCH 1/6] syscalls: use uaccess_kernel in addr_limit_user_check Message-ID: <20200718094846.GA8593@lst.de> References: <20200714105505.935079-1-hch@lst.de> <20200714105505.935079-2-hch@lst.de> <20200718013849.GA157764@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200718013849.GA157764@roeck-us.net> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_054854_225197_06E2D4FB X-CRM114-Status: GOOD ( 12.17 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Nick Hu , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Palmer Dabbelt , Greentime Hu , Paul Walmsley , Andrew Morton , Vincent Chen , Linus Torvalds , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Jul 17, 2020 at 06:38:50PM -0700, Guenter Roeck wrote: > Hi, > > On Tue, Jul 14, 2020 at 12:55:00PM +0200, Christoph Hellwig wrote: > > Use the uaccess_kernel helper instead of duplicating it. > > > > Signed-off-by: Christoph Hellwig > > This patch causes a severe hiccup with my mps2-an385 boot test. I guess that is a nommu config? Can you try this patch? diff --git a/arch/arm/include/asm/uaccess.h b/arch/arm/include/asm/uaccess.h index b19c9bec1f7a63..cc7daf374a6eb6 100644 --- a/arch/arm/include/asm/uaccess.h +++ b/arch/arm/include/asm/uaccess.h @@ -263,7 +263,7 @@ extern int __put_user_8(void *, unsigned long long); */ #define USER_DS KERNEL_DS -#define uaccess_kernel() (true) +#define uaccess_kernel() (false) #define __addr_ok(addr) ((void)(addr), 1) #define __range_ok(addr, size) ((void)(addr), 0) #define get_fs() (KERNEL_DS) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv