linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Jerome Forissier <jerome@forissier.org>
To: tklauser@distanz.ch
Cc: jerome@forissier.org, linux-riscv@lists.infradead.org,
	aou@eecs.berkeley.edu, palmer@dabbelt.com,
	paul.walmsley@sifive.com
Subject: Re: [PATCH RESEND] riscv: don't specify -mno-save-restore when building with clang
Date: Wed, 29 Jul 2020 10:08:11 +0200	[thread overview]
Message-ID: <20200729080811.12111-1-jerome@forissier.org> (raw)
In-Reply-To: <20200729044143.tzok6p3nctqzms4w@distanz.ch>

> On 2020-07-28 at 18:06:36 +0200, Tobias Klauser <tklauser@distanz.ch> wrote:
> > On 2020-07-28 at 17:20:45 +0200, Palmer Dabbelt <palmer@dabbelt.com> wrote:
> > > On Tue, 28 Jul 2020 06:12:52 PDT (-0700), tklauser@distanz.ch wrote:
> > > > Clang doesn't support -msave-restore and -mno-save-restore. This avoids
> > > > the following message emitted by clang:
> > > > 
> > > >   '-save-restore' is not a recognized feature for this target (ignoring feature)
> > > > 
> > > > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> > > > ---
> > > > Resent due to infradead.org mailing list issues.
> > > > 
> > > >  arch/riscv/Makefile | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> > > > index fb6e37db836d..cd3720bc45e8 100644
> > > > --- a/arch/riscv/Makefile
> > > > +++ b/arch/riscv/Makefile
> > > > @@ -44,7 +44,9 @@ riscv-march-$(CONFIG_RISCV_ISA_C)	:= $(riscv-march-y)c
> > > >  KBUILD_CFLAGS += -march=$(subst fd,,$(riscv-march-y))
> > > >  KBUILD_AFLAGS += -march=$(riscv-march-y)
> > > > 
> > > > +ifndef CONFIG_CC_IS_CLANG
> > > >  KBUILD_CFLAGS += -mno-save-restore
> > > > +endif
> > > >  KBUILD_CFLAGS += -DCONFIG_PAGE_OFFSET=$(CONFIG_PAGE_OFFSET)
> > > > 
> > > >  ifeq ($(CONFIG_CMODEL_MEDLOW),y)
> > > 
> > > Thanks, this one didn't make it the first time.  Is there a reason we can't use
> > > cc-option here?  IIRC that's what we use for the other compiler options that
> > > may be unimplemented, and it has the advantage of avoiding encoding specific
> > > compilers into the build system.
> > 
> > Thanks for the hint. I don't know how I could've overlooked cc-option.
> > Will send a v2 using cc-option.
> 
> Looks like it's a bit more complicated:
> 
> Using just cc-option still leads to the warning being emitted, so I
> think the CONFIG_CC_IS_CLANG check is still needed (checked using clang

Shouldnt cc-option be fixed instead? The warning effectively means the option
is not supported, so why should cc-option pretend it is?

-- 
Jerome

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2020-07-29  8:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 13:12 [PATCH RESEND] riscv: don't specify -mno-save-restore when building with clang Tobias Klauser
2020-07-28 15:20 ` Palmer Dabbelt
2020-07-28 16:06   ` Tobias Klauser
2020-07-29  4:41     ` Tobias Klauser
2020-07-29  8:08       ` Jerome Forissier [this message]
2020-07-29  8:29         ` Tobias Klauser
2020-07-29  9:36           ` Jerome Forissier
2020-07-29  9:43             ` Jerome Forissier
2020-07-29  4:44 ` [PATCH v2] riscv: don't specify -mno-save-restore when building with clang < 11 Tobias Klauser
2020-07-31  3:58   ` Palmer Dabbelt
2020-07-31  8:16     ` Tobias Klauser
2020-07-31 16:16       ` Palmer Dabbelt
2020-08-01 10:30         ` Tobias Klauser
2020-08-03 20:28           ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200729080811.12111-1-jerome@forissier.org \
    --to=jerome@forissier.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=tklauser@distanz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).