From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E58FC433B4 for ; Mon, 12 Apr 2021 16:28:21 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D62F86137F for ; Mon, 12 Apr 2021 16:28:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D62F86137F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KHgdEkNxrZkeF2bzXlZy6SFi/aLc2E0YM8sGXnd8eGg=; b=jny8bNZzRe3OOXzVp9ZTRoLEb Y7vMuPZPOM9s56XmowpGN8Ti3y2tG5MzALzi3wIqta+Dj/RmuuxsUG5wPOdT1Xi+EnNBUptEB+NpZ BID9tvyQBYana0zm4QVJ5158Fdb8BJT3NfSRJRSqY5IImsgAEjT4WpJZCIvr8d01aZGq0JmF0xYsj SgBROfQjZaH4saXV3LJJXVRPkEsyC7r+RnClKVW6pKuZ9sZgnbXBzfnbYRk4+/EntlO+S7Bl8tiqK lIg9kCrOCKo9kf3NPoPJGnE+ZYbMHDe8AgHGKhEm/7JHXISJ6qNv9z7mgCO2qvZEnB5p86y+Ayepz QePWmXoGQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lVzQ3-007GJ8-10; Mon, 12 Apr 2021 16:28:11 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVzPy-007GHn-CJ for linux-riscv@desiato.infradead.org; Mon, 12 Apr 2021 16:28:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=zhXcnGPtaThQ0EPgsb1UBD4YuCOdWKjzWtwvIjN/9fk=; b=zVHJz23XG1v/PQkgLnZIjK5OkE TPZqUPzHgop9eLG/mzJLDuhN2/4AwQSuiXVuPDJpkXTNOr0/1Y6es9HeDnvUhnBJuHVUBvTDgEwTq HdglIOcfLjT59taAj85i0XtHENFqk0Ec1XTWeO5sanvPWjbN7kkSzSyugREtnbviY1Ktkv4/O+v3B OTsKy3tgQtIIWSzuRhOxMFZiNXKhlQN56UuE4479CKqn0/LA3laau5yR8is4TLfV64mi3jeXFNhG+ /g7n3ti7zoGRwDwer8oQ4TQhiRMMunJXmYgvnU84jnjyH9yMJ2eVvxeNHT9ssHw3k6Kj9HyXTCtzy X2jpc7rQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lVzPv-006Owo-LU for linux-riscv@lists.infradead.org; Mon, 12 Apr 2021 16:28:04 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6D5FB613EB; Mon, 12 Apr 2021 16:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618244883; bh=D4hR8mKvAir5lW8186XPQjpX5BXvw+gV6Vtd4glAfhI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EyTYvxW6Qs+cR2RCM2cwkpecXWB5tluRrKoUJP1EFSYI+Ctj2B9zMTyF2G1isLMPZ 9+7Z4lWYFeKiaGPBNVGPtcAZjHsUeKeFWbujQI+Xzv9UAmm7BbZ3eGVhjHLW+prucj 0cQ6S+LVCu7FthTSq5PvUjfF0HPXRVl7O3hBVcQrPh4aiyBS7Ah5EmOt/jJ+B6on8G wMEoymFCV4cPgkakQ1dW9L+TeXgJX36M3hZ7+Gbyc7OJbO7SQCrLJ50FV9yEsHglKX F/B74AgH8VqMaNmEgyeu/80wlMqNm+w4MpCxvTgmTw/ks3S11MB/P0HaCR6UwBrQC2 PrQsXYSOnylNA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Guenter Roeck , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH AUTOSEL 4.4 20/23] pcnet32: Use pci_resource_len to validate PCI resource Date: Mon, 12 Apr 2021 12:27:33 -0400 Message-Id: <20210412162736.316026-20-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210412162736.316026-1-sashal@kernel.org> References: <20210412162736.316026-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_092803_743026_8D73F8FB X-CRM114-Status: UNSURE ( 9.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org From: Guenter Roeck [ Upstream commit 66c3f05ddc538ee796321210c906b6ae6fc0792a ] pci_resource_start() is not a good indicator to determine if a PCI resource exists or not, since the resource may start at address 0. This is seen when trying to instantiate the driver in qemu for riscv32 or riscv64. pci 0000:00:01.0: reg 0x10: [io 0x0000-0x001f] pci 0000:00:01.0: reg 0x14: [mem 0x00000000-0x0000001f] ... pcnet32: card has no PCI IO resources, aborting Use pci_resouce_len() instead. Signed-off-by: Guenter Roeck Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/amd/pcnet32.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c index 7ccebae9cb48..b305903c91c4 100644 --- a/drivers/net/ethernet/amd/pcnet32.c +++ b/drivers/net/ethernet/amd/pcnet32.c @@ -1493,8 +1493,7 @@ pcnet32_probe_pci(struct pci_dev *pdev, const struct pci_device_id *ent) } pci_set_master(pdev); - ioaddr = pci_resource_start(pdev, 0); - if (!ioaddr) { + if (!pci_resource_len(pdev, 0)) { if (pcnet32_debug & NETIF_MSG_PROBE) pr_err("card has no PCI IO resources, aborting\n"); return -ENODEV; @@ -1506,6 +1505,8 @@ pcnet32_probe_pci(struct pci_dev *pdev, const struct pci_device_id *ent) pr_err("architecture does not support 32bit PCI busmaster DMA\n"); return err; } + + ioaddr = pci_resource_start(pdev, 0); if (!request_region(ioaddr, PCNET32_TOTAL_SIZE, "pcnet32_probe_pci")) { if (pcnet32_debug & NETIF_MSG_PROBE) pr_err("io address range already allocated\n"); -- 2.30.2 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv