From: Conor Dooley <mail@conchuod.ie>
To: Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>
Cc: Rob Herring <robh@kernel.org>,
Conor Dooley <conor.dooley@microchip.com>,
Jessica Clarke <jrtc27@jrtc27.com>,
qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
linux-riscv@lists.infradead.org
Subject: [PATCH v3 0/4] QEMU: Fix RISC-V virt & spike machines' dtbs
Date: Wed, 10 Aug 2022 19:46:08 +0100 [thread overview]
Message-ID: <20220810184612.157317-1-mail@conchuod.ie> (raw)
From: Conor Dooley <conor.dooley@microchip.com>
The device trees produced automatically for the virt and spike machines
fail dt-validate on several grounds. Some of these need to be fixed in
the linux kernel's dt-bindings, but others are caused by bugs in QEMU.
I mostly opted for what appeared to be the smallest change that would
fix the warnings, partly due to my inexperience with the QEMU codebase.
A "sister" patchset for the kernel will clear the remaining warnings.
Thanks to Rob Herring for reporting these issues [1],
Conor.
Changes since v2:
- move the syscon subnodes back to the top level instead of into the
syscon node
Changes since v1:
- drop patch 1
To reproduce the errors:
./build/qemu-system-riscv64 -nographic -machine virt,dumpdtb=qemu.dtb
dt-validate -p /path/to/linux/kernel/Documentation/devicetree/bindings/processed-schema.json qemu.dtb
(The processed schema needs to be generated first)
0 - https://lore.kernel.org/linux-riscv/20220805162844.1554247-1-mail@conchuod.ie/
1 - https://lore.kernel.org/linux-riscv/20220803170552.GA2250266-robh@kernel.org/
Conor Dooley (4):
hw/riscv: virt: fix uart node name
hw/riscv: virt: fix the plic's address cells
hw/riscv: virt: fix syscon subnode paths
hw/core: fix platform bus node name
hw/core/sysbus-fdt.c | 2 +-
hw/riscv/virt.c | 8 +++++---
include/hw/riscv/virt.h | 1 +
3 files changed, 7 insertions(+), 4 deletions(-)
base-commit: 2480f3bbd03814b0651a1f74959f5c6631ee5819
--
2.37.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next reply other threads:[~2022-08-10 18:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 18:46 Conor Dooley [this message]
2022-08-10 18:46 ` [PATCH v3 1/4] hw/riscv: virt: fix uart node name Conor Dooley
2022-08-10 18:46 ` [PATCH v3 2/4] hw/riscv: virt: fix the plic's address cells Conor Dooley
2022-08-10 18:46 ` [PATCH v3 3/4] hw/riscv: virt: fix syscon subnode paths Conor Dooley
2022-08-14 21:55 ` Alistair Francis
2022-08-10 18:46 ` [PATCH v3 4/4] hw/core: fix platform bus node name Conor Dooley
2022-08-22 3:34 ` [PATCH v3 0/4] QEMU: Fix RISC-V virt & spike machines' dtbs Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220810184612.157317-1-mail@conchuod.ie \
--to=mail@conchuod.ie \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=conor.dooley@microchip.com \
--cc=jrtc27@jrtc27.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).