From: Logan Gunthorpe <logang@deltatee.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
Paul Walmsley <paul.walmsley@sifive.com>
Cc: linux-riscv@lists.infradead.org,
Palmer Dabbelt <palmer@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH 2/2] riscv: Fix undefined reference to vmemmap_populate_basepages
Date: Wed, 23 Oct 2019 09:58:08 -0600 [thread overview]
Message-ID: <2f1d943a-6021-3a2c-1d04-2e5939925f86@deltatee.com> (raw)
In-Reply-To: <20191023032302.160388-2-wangkefeng.wang@huawei.com>
On 2019-10-22 9:23 p.m., Kefeng Wang wrote:
> Using CONFIG_SPARSEMEM_VMEMMAP instead of CONFIG_SPARSEMEM to fix
> following build issue.
>
> riscv64-linux-ld: arch/riscv/mm/init.o: in function 'vmemmap_populate':
> init.c:(.meminit.text+0x8): undefined reference to 'vmemmap_populate_basepages'
>
> Cc: Logan Gunthorpe <logang@deltatee.com>
> Fixes: d95f1a542c3d ("RISC-V: Implement sparsemem")
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Yup!
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
> ---
> arch/riscv/mm/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index 83f7d12042fb..a1ca6200c31f 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -458,7 +458,7 @@ void __init paging_init(void)
> zone_sizes_init();
> }
>
> -#ifdef CONFIG_SPARSEMEM
> +#ifdef CONFIG_SPARSEMEM_VMEMMAP
> int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node,
> struct vmem_altmap *altmap)
> {
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-10-23 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 3:23 [PATCH 1/2] riscv: Fix implicit declaration of 'page_to_section' Kefeng Wang
2019-10-23 3:23 ` [PATCH 2/2] riscv: Fix undefined reference to vmemmap_populate_basepages Kefeng Wang
2019-10-23 15:58 ` Logan Gunthorpe [this message]
2019-10-23 18:26 ` Paul Walmsley
2019-10-23 15:56 ` [PATCH 1/2] riscv: Fix implicit declaration of 'page_to_section' Logan Gunthorpe
2019-10-23 18:47 ` Paul Walmsley
2019-10-24 0:45 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f1d943a-6021-3a2c-1d04-2e5939925f86@deltatee.com \
--to=logang@deltatee.com \
--cc=aou@eecs.berkeley.edu \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).