From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C54D0C433EF for ; Fri, 15 Jul 2022 10:33:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mgfa7piCzMjcu+duleR70hTq1txQdQLoSdXtp01FdRA=; b=QeUcrq1hwqehRu yeB+x8tcSEluECB5gGGHq1KXdt/MLxxifMKI/WznUWb61uAp/2pA1098AKSx0oI3BrE56mX0hxUu7 QGw6h4054/TY7mTAfQUOnjH5CIA2LNzC2aAH6gXrvQpZ8m30u8jRTfKZxxcicYD05CfMC+9I41vvE V43pWbm+1HGwxfFDjVRPQAZHoDL66LPgcx4GnAtkBkQ4hrp25zF6NrgCgVuUxp6Nek2ZieaLvgnQs HLQ+lAuGWSQjsisYABSa+b9AIWoZsFAhiWwMVrBBnn2kL9Y1DmAb0L3c+VKW8JcNpo5+prYmfSmE1 iIa8QUsbMGP7VFxm/hWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCIdl-006MvI-7y; Fri, 15 Jul 2022 10:33:45 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCIdY-006MqJ-A4; Fri, 15 Jul 2022 10:33:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1657881212; x=1689417212; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=VXKpDS542CqJOJy/Gb88xarmtuzDn0bX6Mpn6ssk/zU=; b=Y6ouBr8r3q+y+yvnNR1FRJnvKejnxGC+SRMsbew1znEVcACHrxQRc5t2 yXKpPYhbJ+WOzsm5KxlaXG1HOGKoax4PbXlCHSipsOeh4EhpJ94EbfZjE XPuEpxfLNz4hiOHFo3dGDKPJSmowx+r9k2LMtRaN8aPotmdGNuht4NdZy GkWtASNLjZ4FQwue36mK/RxOl0aJdiN1bVq7S7i+hAMzrJm2SVLWV98Pz D9C1pdToZ0C3cWpf28YAYCEYETe9Uq51tlG/bK4hBCfnmYpJJLK5ubDx/ m/VKlgG3xhD5FAgMxtE4Xacf33VzRJJDwk8Y6sdxbvEHkzS7sr08fFHjM A==; X-IronPort-AV: E=Sophos;i="5.92,273,1650956400"; d="scan'208";a="167983728" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 15 Jul 2022 03:33:20 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Fri, 15 Jul 2022 03:33:20 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Fri, 15 Jul 2022 03:33:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QrsL+U36y950ax6H/Zitsf1H7jyNXO+C9smCxpQ+Zd0iEMjf19x9KlsBODDO/YxBX+ISbSb535jb8pozQ5fdxZK0/cMDVmEf1SYDliO1XH62qbW8Si9rlnfxoBEWPB65BUp3l9dm2CYSlrFFU6N9FEt6i5a/+Ih73QiNoqumcXXRWNw4A5lFzFtiwu0k46OZLDLytbQjASbKUKHhebKmjE/fwa4jXjtryIX/hd/6FUojUU52RW6DpahPZCxotQQNtUXHqfv8QucLQvFeF5dQoJTjhnu7tx3yrPhBK4RYG1V1WtJCF+MKFaqzAp84LZHmrJs/OByUPD0JhtOJ7hMpZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VXKpDS542CqJOJy/Gb88xarmtuzDn0bX6Mpn6ssk/zU=; b=CjHVZeS4cyrmSgUoLQarkbotrRwSeXrGBSLqIo/uFiATye8BaV+g1L+9lbiakfvxxoV62ppoUJdewkJr+yF0OpEysDxZiHFxnAwgTV+3AlQGleQGgLpLuIq4X099HCc79wYXyO9/8myVj0uhtXl9tfC8mP5hBeVwYDXTNrAt0RRHzq+sqt+sLlKcdaNL3D+1KeMP2uhdjYaqokzet20Vn6C6WfqpAdG9Fm4jBcwC9B3SUfBS4Pb/ohEYBRSLYg3h56wFQUPg7jIpagwPwnDJ+ppCJ8VAmWLGpf2T47o2Ofwa/9fsR8jkysEOMxGZ8nP90JEzfz5FwEDvz0pwz62mnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VXKpDS542CqJOJy/Gb88xarmtuzDn0bX6Mpn6ssk/zU=; b=dZQvxHusPsSAYt+WAMXTY88JLyleSMsRqQT599ukJ+uYDOIqzvbYk+nVrkVXIG0ZOG5PQyBHUYBNXNkR+QGme9KrWMchvzumDT97aERT+ZRLRFM6640Qbc48MesJLtf4Hbia8jMkKahtAkO7OSHvfYGF+hQ85nj62j4iNu3f/qs= Received: from CO1PR11MB5154.namprd11.prod.outlook.com (2603:10b6:303:99::15) by DM5PR11MB1625.namprd11.prod.outlook.com (2603:10b6:4:b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.13; Fri, 15 Jul 2022 10:33:17 +0000 Received: from CO1PR11MB5154.namprd11.prod.outlook.com ([fe80::357a:acc9:829e:bf7b]) by CO1PR11MB5154.namprd11.prod.outlook.com ([fe80::357a:acc9:829e:bf7b%7]) with mapi id 15.20.5438.014; Fri, 15 Jul 2022 10:33:17 +0000 From: To: , , , CC: , , , , , Subject: Re: [PATCH -next v2 1/2] cacheinfo: Use atomic allocation for percpu cache attributes Thread-Topic: [PATCH -next v2 1/2] cacheinfo: Use atomic allocation for percpu cache attributes Thread-Index: AQHYmDVjHKZFl0MGukuqHSdNWJS2ga1/PDyA Date: Fri, 15 Jul 2022 10:33:17 +0000 Message-ID: <388a12c8-7c8c-0a43-9b28-bbea880eea10@microchip.com> References: <20220715102609.2160689-1-sudeep.holla@arm.com> In-Reply-To: <20220715102609.2160689-1-sudeep.holla@arm.com> Accept-Language: en-IE, en-US Content-Language: en-IE X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 21be56b0-8254-4d24-8dac-08da664d6e41 x-ms-traffictypediagnostic: DM5PR11MB1625:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LbCCZZ6P3O07xTFjD/XyVqlBDMhZdXnVq2A8PEPZTDejCfgj96ePCS2QaI3GPycs5PRva3ShTIsQuX8jMIdUhFrkGTCAgsQf7EEnLB9/B6i+78XJ1jxPM5xq727zBpJZiPpwqHEa+VEE5S2A8yxIhP5T2M7JD4pSaXKsB1e6zMQKd9rdulG+GYb+GZ5dd5toCdJ9B2nvm4qdDt5p6A3PuLbDqiCSjO8gN26MVcy5i/D7M302MA6DnIC0pTWSP/UR13zZtKV1MHSOFYlN8LWLvTbQME0DixokIM2Ay2j5N7BqNtQU8IBDGbL3f64DCkyqPlnxnGYMYPwi9dJJlsuV1KyzBdDY7muBijm1dH4a/2sCVZ46f0AQUv+CwjhdK/Mr613n7MhRN8giOLTu+zaVMl/j3wTXdmU1SJ3ZhJvnCoksN34d90zerXb+nfZiMirUTagOy4e8gXRPWGELmyZI1G6cUypigdIs2ybT2M3o9vGE3Dgri0iSEplmQV0vBoey9es1EGw+LLGKlLGiY7O+O4eT/x9YkTXV/kGuKnpgMcvT9k5iCfEfQ1XG8ux0SkpuVEP4heYwqlWeRM6iPCqJKO9F7GMia/CYDbKxluJtfPsQbRPz4WFLXV2Ra7c0TnMyQGRnWB57hISz4Cio92Mp08jhpgtozoyQWV6PvA3CCtUY6OR717LjFn1dupqmUUHISJbWDcYZcHb1w4g089Sj4DcttNy1ycl2GRjLR60TH8e9cTEcq4HfNeidJHs7lThbqVZumxSLtpEFYxBLxYKiTm/HQeZFGpooOgXukjaewBbWWhFs2YE/2tQPKltfGV4LGE+GoOatnwiYVRxeWUgC5L8q2oLEXkqv+/hM9a8n95t+2GRPtOek8xE4xvKle9UD x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB5154.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(136003)(396003)(366004)(346002)(38100700002)(38070700005)(2906002)(86362001)(122000001)(54906003)(31696002)(8936002)(53546011)(91956017)(66556008)(478600001)(316002)(26005)(41300700001)(5660300002)(6486002)(6512007)(66946007)(66446008)(2616005)(186003)(8676002)(64756008)(31686004)(4326008)(36756003)(66476007)(71200400001)(83380400001)(76116006)(6506007)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dVNZMTFuMEhMb3JTUW9nUXBPNmh1cWw5eUNXMzgwT2h6Qm9LcTJrQlBjTG1j?= =?utf-8?B?SWc1M1ZsNGNVeVhiWWt5SVNjbW9aZXV4aXlDTlFPdi9SUVpzK3JpNDNTaVFK?= =?utf-8?B?cENyemRXbFQ3SlovR2ZHd1RpZU5ZUFF5U3l3bTkxdkNscG5kSWVZV0llc1d0?= =?utf-8?B?VXZJbE44dko1ZjFNOXNHMGZzL1R6cUppTUxteURITmZrUVFjVlJJWGFlNTRD?= =?utf-8?B?WXdBQTh1d0dsbTJTVmNHY0dsM09pOEdjYnBOVXJycmtCZlQxVGpJbDdrSDl4?= =?utf-8?B?NzNQTGlyQldJYkQ2WGpuMEFLUkNwRm5oZEpnQzQ0d3BvcVRmS0ZNeCtRSUV5?= =?utf-8?B?TFpqcUdUWExrRlhndFVhb0NIcUVtVCtIb2lGNXozZnhnSjcyQksyeHlwUHJ5?= =?utf-8?B?aEEzYlhrR2tidmVmSWg5b1k3MVROUndscEZDZE0zdittQ21RYTgvczF3T29a?= =?utf-8?B?TzFIbWhNeE5lZW9TY25BWm1lMXdCVGFZalIwaGV1cVhnb1RTNVpmOUZwOTR1?= =?utf-8?B?a0FFRFVPTnd5SE5ScjZhV1hEMGNTeDdpcGQwTkowTkZJaXIrOTFsR2V3anBx?= =?utf-8?B?cUVsV3dHbS85RVNJUEJsK05rdG5DeWVnbXhFcnZLUk1MZ0xMQm9uTm5seHkw?= =?utf-8?B?T3lSaTNsRVoxbmd2UEhlNVVMSlN4M3dJMldlUVVIOUZYUWFrZVEraGxCZU10?= =?utf-8?B?RUhXNlRqdFpGNXlnTjcyaTRZa0syRy90dzJBQnBrRStrdi9uL0t0My94dDF5?= =?utf-8?B?WUIwMUdKOGNvYlU1NjZGakR1RHNocmE1YktrekdZM3RPdVJlN0p0ekJKT1hm?= =?utf-8?B?QjFhS0dkVVl4OURuT25MRnlUKzRrZEpXNXpCSWZWeitiNXBHMDFta0FQRUov?= =?utf-8?B?THdQYUphOVhaU1FrMnF1WndwNnpBNWV5bmllbERDNEtJbmtjRmVPYWUxbThv?= =?utf-8?B?TTM1V2RvZ2pXcnV0VkNHSVZjRHVnQW9GYUVnYS9SSVNRUXRYa3dVTy8rKzZM?= =?utf-8?B?NTNKYVlaN0lFejZTVXRSbEx0MFJUNmVOTWl4MTZiTFp6NWs1Nll5b0NiZkNi?= =?utf-8?B?S2JpU0I4SjEwSTN4QUNEV2dQaW9JM0t5NG9JUVF2cGJoajhjMitQRWhXQzY0?= =?utf-8?B?azlkL3ppbWxBVXNyTVpubFA0K1Zmalc4a3lVeklVa0k2TmVzdEkzYVJPRytz?= =?utf-8?B?M2tENzF5Tmx6cXZ2ZTZaa0VVdDBobVNkY2orRmJCMkVOTklkL0JrTlRwa2FZ?= =?utf-8?B?M0ovSW44MytpcDRQcnJURytkL04vWHFOOGN3QXRHR3NKZmNyOGRIM0VJaC9k?= =?utf-8?B?MFowTmVIUFNVQVZ5VzVJZWk5bEVld0RlYjAybUpKTEhOdWZKL1FNcENTaEdt?= =?utf-8?B?S2JDRzR5V2NIV0RIMlB4b2RmZjFvQUdrWTlqb0FDY0doY0F3dU9xYW4wZWk4?= =?utf-8?B?d1JUVHQvaVVZNm9yZHBoanZpOHlhTk9lTHlWelJlOUJ0OTFJWjRMZE5HTmhP?= =?utf-8?B?bUdXd24vcDU1NXg1azVTWlpDNDM1WWhHTWdBOEl5OXBrYStpWUNYTXcwVUxB?= =?utf-8?B?ZTdUN0NQNno5TWdpYXIzT0RKejMvKzVqYmdReHUvdjYzV1AwMlQxczNDZUdK?= =?utf-8?B?N29DRjdoVEZsc2YySzFKQ29hbUlHcXVDMnlvRkdUOWVuMStqQkc1ckNZd3Yw?= =?utf-8?B?TllUZjloTjJMK1pkdHdMalpBbDBXdE5QN20zVTFNMDBPWXlVbUgxZHpGSEhx?= =?utf-8?B?TmtUaTJYZ3hnSzJneE5VYnkyeTIwTHluVWxxckhrMXJ5ei9JdEF4R2Juc1E5?= =?utf-8?B?YVI0bkxaMGpPU2hLQk0wTzRIYUFLVnlqTzlWUnAzdVhDbTBrMXFReEMrRHJl?= =?utf-8?B?aHZlWGFIMVV1cG9OQ054M2tTNjByTm1yeFJ2OGpMSmx2SzdkR2RYbWpQeXRX?= =?utf-8?B?c0U0WUZFZmp6QkorOXUyUnFNNmNkcERUNUFUS2dPc0t5VnNwMmZJOWNlMDB4?= =?utf-8?B?WHdnRSs0MWVueS91YWhiQUxOU2dUaVFWQzhzdnVQOEdmWDl5ZG5RZzNaT1ly?= =?utf-8?B?VUgxZWJSYnRDbldTWVJPMnYwQlIrYlN0OHZ0UCtGbnUzODh0eHNZZjRuS2Mw?= =?utf-8?Q?3Z+7ZlyEJux7VjNKZNzWrZboP?= Content-ID: <54EDD9651F36274E9F6921F6E633EDCE@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5154.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21be56b0-8254-4d24-8dac-08da664d6e41 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 10:33:17.4339 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H5lpwj5xnGdWsKHKhkGji6AbT3hSCbHT2IMyJR1tq371wnVFVfw3lyHIEs+jtsZZ5RSoViUVNxRd5jN1gpCBzHqGRz8ACGGLbDLY34p/RJ4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1625 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220715_033332_446434_01D50159 X-CRM114-Status: GOOD ( 21.15 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 15/07/2022 11:26, Sudeep Holla wrote: > On couple of architectures like RISC-V and ARM64, we need to detect > cache attribues quite early during the boot when the secondary CPUs > start. So we will call detect_cache_attributes in the atomic context > and since use of normal allocation can sleep, we will end up getting > "sleeping in the atomic context" bug splat. > > In order avoid that, move the allocation to use atomic version in > preparation to move the actual detection of cache attributes in the > CPU hotplug path which is atomic. > > Cc: Ionela Voinescu > Tested-by: Conor Dooley Since this was a conversion from comments on the other series: Acked-by: Conor Dooley > Signed-off-by: Sudeep Holla > --- > drivers/base/cacheinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Hi Greg, > > Can you apply these couple of patches directly if and when you are happy > with them ? > > Regards, > Sudeep > > v1->v2: This was added in v2 > > diff --git a/drivers/base/cacheinfo.c b/drivers/base/cacheinfo.c > index 65d566ff24c4..4b5cd08c5a65 100644 > --- a/drivers/base/cacheinfo.c > +++ b/drivers/base/cacheinfo.c > @@ -356,7 +356,7 @@ int detect_cache_attributes(unsigned int cpu) > return -ENOENT; > > per_cpu_cacheinfo(cpu) = kcalloc(cache_leaves(cpu), > - sizeof(struct cacheinfo), GFP_KERNEL); > + sizeof(struct cacheinfo), GFP_ATOMIC); > if (per_cpu_cacheinfo(cpu) == NULL) { > cache_leaves(cpu) = 0; > return -ENOMEM; > -- > 2.37.1 > _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv