From: <Nicolas.Ferre@microchip.com>
To: <yash.shah@sifive.com>, <davem@davemloft.net>,
<robh+dt@kernel.org>, <paul.walmsley@sifive.com>,
<netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
Cc: mark.rutland@arm.com, sachin.ghadi@sifive.com, ynezz@true.cz,
palmer@sifive.com, aou@eecs.berkeley.edu
Subject: Re: [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding
Date: Fri, 19 Jul 2019 12:02:27 +0000 [thread overview]
Message-ID: <443fd93a-ff6f-1641-89ec-f35f39de3688@microchip.com> (raw)
In-Reply-To: <1563534631-15897-1-git-send-email-yash.shah@sifive.com>
On 19/07/2019 at 13:10, Yash Shah wrote:
> As per the discussion with Nicolas Ferre, rename the compatible property
> to a more appropriate and specific string.
> LINK: https://lkml.org/lkml/2019/7/17/200
>
> Signed-off-by: Yash Shah <yash.shah@sifive.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> Documentation/devicetree/bindings/net/macb.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> index 63c73fa..0b61a90 100644
> --- a/Documentation/devicetree/bindings/net/macb.txt
> +++ b/Documentation/devicetree/bindings/net/macb.txt
> @@ -15,10 +15,10 @@ Required properties:
> Use "atmel,sama5d4-gem" for the GEM IP (10/100) available on Atmel sama5d4 SoCs.
> Use "cdns,zynq-gem" Xilinx Zynq-7xxx SoC.
> Use "cdns,zynqmp-gem" for Zynq Ultrascale+ MPSoC.
> - Use "sifive,fu540-macb" for SiFive FU540-C000 SoC.
> + Use "sifive,fu540-c000-gem" for SiFive FU540-C000 SoC.
> Or the generic form: "cdns,emac".
> - reg: Address and length of the register set for the device
> - For "sifive,fu540-macb", second range is required to specify the
> + For "sifive,fu540-c000-gem", second range is required to specify the
> address and length of the registers for GEMGXL Management block.
> - interrupts: Should contain macb interrupt
> - phy-mode: See ethernet.txt file in the same directory.
>
--
Nicolas Ferre
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-07-19 12:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 11:10 [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding Yash Shah
2019-07-19 11:10 ` [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000 Yash Shah
2019-07-19 12:05 ` Nicolas.Ferre
2019-07-22 4:39 ` Yash Shah
2019-08-13 18:42 ` Paul Walmsley
2019-08-20 9:10 ` Andreas Schwab
2019-08-20 10:16 ` Nicolas.Ferre
2019-07-22 20:02 ` Paul Walmsley
2019-07-22 21:46 ` Paul Walmsley
2019-07-19 11:10 ` [PATCH 3/3] riscv: dts: Add DT node for SiFive FU540 Ethernet controller driver Yash Shah
2019-07-19 11:53 ` Sagar Kadam
2019-07-19 13:26 ` Andrew Lunn
2019-07-22 8:27 ` Sagar Kadam
2019-07-22 21:48 ` Paul Walmsley
2019-08-12 23:33 ` Rob Herring
2019-07-19 12:02 ` Nicolas.Ferre [this message]
2019-07-22 19:59 ` [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding Paul Walmsley
2019-08-12 23:32 ` Rob Herring
2019-08-13 18:41 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443fd93a-ff6f-1641-89ec-f35f39de3688@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=aou@eecs.berkeley.edu \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sachin.ghadi@sifive.com \
--cc=yash.shah@sifive.com \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).