From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A205C433F5 for ; Mon, 8 Nov 2021 15:19:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B63FC6125F for ; Mon, 8 Nov 2021 15:19:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B63FC6125F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0dH5cpBPfSkdr5qTj4tfLUcdeCiEQpv/2sauteoun1c=; b=ZIGNkOUzQdJYwV yC+l6FOItWBhlSgIvewRzT7LG0LLngn+ANVH/UQ8YWemrSO9sONuibcLMc21k52QRKUBR6+E7igFl 08qbH8uyVMVCQet+DiYpULk7p1VnadLxdXs5cM/kZsaw63GVEfb9gIeVFXqXU3hkANjNunPW2i1hY GLGZ8Sve/EEO2fJ14o6n/dphCYuAFaxGJoO8loLVfMy9nZVdIYx0fPs9XplBRdwOY6UeJzh7Qhzr4 4ZU4H71Rg0aXNnOHkkK9NxkCtUUFARPCgZ/fyBLoBPiSzPG6PV/FQmgKdGcsS7UE3VWd3JgTWEbd7 2HzDYA4Ffnxir4v+exiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mk6Qr-00GpHE-Ai; Mon, 08 Nov 2021 15:19:37 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mk6Ql-00GpGI-Tp for linux-riscv@lists.infradead.org; Mon, 08 Nov 2021 15:19:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1636384772; x=1667920772; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=dy1RalEXNmMl6w+YQKBxcZkJM9HllmDSogGrGG9m/gI=; b=h5TVA0eGtrZACx4NQihXN5QKcQGIU/gb9BxNgQJ6EHmiienRQ4AuQJAl SZjkKWs9kRuTzzDIfqO//KnlwRPwQmciknjYrNU7H8Gu+/HmG6essoLXR XbwLwvVwua0BhmSwB1awnqBJ20OJoZsLFE/3T+SgVATMRftgRrw3t0Xzo 1Ddpv49oe1BSyidzkqDYIc8PPpAxNHOYIHkj3iOgegKvMOxIuHlJYs+So LhAm4DuWwvADL30YJLs0XLoiGc/+Kf0Nd5OEffRGBxWS2m/TOpd//lGVT uGZ8jh/4FYTpuyZMWUJGB0VCJ4sCGUdSeiCww/iHMcYjCCDW1iykTI9Vx g==; IronPort-SDR: R/CnJymjbmGEX5aOBh0dAsC/P3YNPXT4OGPRQRjiM/Rlig4tmWG3G/oMfLMz0/gAZ7P//qLnBs BhcHCqNBn2r1YpTjsIUfxiVpGHMLqkiE8BusE6Sodqp37yah5FlKEhlK75FwaYyzuqcTU54Zws IVzllZrUzjDbSpWmKN/deWFRWigZhSkN5jlw89ptBOtvuMXBxNbOV4AhuQeT+aEvn0suio7m7f EyrDKYAWGctxJe2sxW2DDjnP1bLeHbZTVGDPcRBEys/xsasaZSfI9XlPZ4+3z0oKSTw5YsN496 FZtdM+6ZJoefqQ+B0dSPwNwu X-IronPort-AV: E=Sophos;i="5.87,218,1631602800"; d="scan'208";a="138384696" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 08 Nov 2021 08:19:30 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Mon, 8 Nov 2021 08:19:30 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14 via Frontend Transport; Mon, 8 Nov 2021 08:19:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i0tlaKqimi4Xr5nmkTGas527YGN50ISlZBfNBoZlnJPptiiu06IkCv6T1+KwzH65uCtyoe4VeGwkIlxqgmcXJvdJMniNyIAY5K4viWAxulCUBwh8Yq1jJ9Xwbo8kXZ+S8s7l9hR4+XeYmTvybZWzoZRXBlTv+5gSo20smmcwA4qP/vDduXNHL6L3oRgLuUL6gLVT6CSfZExLn70IfLO7UkCuhoGzZKUxP1+omSuD32QDTz5eXjM3+LUO1DlxLh7WTbiQAKi3T+kMdnB/70NmVhiQbEEmgzvO7UWmESenKncOwaWILSTgO0nniG11JEsApNPFJH8oSAyzw4S+pZ1FFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dy1RalEXNmMl6w+YQKBxcZkJM9HllmDSogGrGG9m/gI=; b=AZvf1PxnG/9nhPzRI5S6yfB3vXjXJ5m2ZT6zh2oqlLFQe7WiZ1RZtFl48nHM34r+g5ZOMNFggq1uje577nwer5pcsy0dIpPPKGulANrlXBCSuJtnO8lSVe8pp+q1BMSb6dZplh2KsSHDTH3hKyQFUSfMk/Z9+j6jE/t63X3cDfYykJ3nJKYK6F3cB+vJ+RwoA8wojffWONd/kJYr0bRLaprO1hpas8AM5hjzDw3VGou2jLPYBCHIUHh0HtRgGxa0+zisy/4FZqdbAHqyBtUx1sQEXaSngP5CiEU8cfr+RKDlmLzTxON5942oREJHfP52eFaM+KRTrHW6DaPCV3fK/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dy1RalEXNmMl6w+YQKBxcZkJM9HllmDSogGrGG9m/gI=; b=iRICyxN5KURRaSVZ3sziEgQpSpdh4WfbG+RieMV/LxYWijr2ltINzcfzk/8xEzK/zjuBWh9Hs6zX21mEa/HsxUK0iyBqkI2Sq2yk2FUsm0youhCScEKCWvjcMHFt3NRTITyYxWqivU6/rDNtr8Lq/jVBiThIVIBHz2Ny+rjUptM= Received: from CO1PR11MB5154.namprd11.prod.outlook.com (2603:10b6:303:95::7) by MWHPR11MB1407.namprd11.prod.outlook.com (2603:10b6:300:26::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.15; Mon, 8 Nov 2021 15:19:28 +0000 Received: from CO1PR11MB5154.namprd11.prod.outlook.com ([fe80::ccb6:6f5a:9841:266d]) by CO1PR11MB5154.namprd11.prod.outlook.com ([fe80::ccb6:6f5a:9841:266d%7]) with mapi id 15.20.4669.016; Mon, 8 Nov 2021 15:19:28 +0000 From: To: List-Id: CC: , , , , , , , , , , , , , , , , Subject: Re: [PATCH] soc: add polarfire soc system controller Thread-Topic: [PATCH] soc: add polarfire soc system controller Thread-Index: AQHXuecsmqsF21x/+Uu/rugU1FwxCqvdh0SAgAAufICAACsgAIAcE4qA Date: Mon, 8 Nov 2021 15:19:27 +0000 Message-ID: <46f04c45-cd50-9484-de41-be8c390bf8e3@microchip.com> References: <79ae46c3-c028-2c99-2428-b601e4fb03d4@microchip.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-IE X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 authentication-results: arndb.de; dkim=none (message not signed) header.d=none;arndb.de; dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d38e587b-53c0-4c8e-7ddb-08d9a2cb27f2 x-ms-traffictypediagnostic: MWHPR11MB1407: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UmICr9NHAEIPMV25AY9HP07yCuK0wCa3WLpYmZtxqHF7RDpHhCY6WhUX1QEKFcJSW/jQzbGoXWapIJcPRg0PIb5wol+7SveyOntXsuucPv0Ygb/uKokrl4huvklrfjuGJ/NsJkLUI7RCWsLBXfYf9NwBJ5kdroKKEBeb//XtkGooAe1ULSwPnSkpaMJpjz3qHhJjQaQsYPsOCwPPXqo3xexJMDc6QAnGoOC/Es9rZ14s0VDzu2xgIw8ZIc6nAQUkcalSRhI/I6wi6fF/ehA32JlwBXLRe2Ub+pt18LaqUPWq/Sli3rRmGCn6FXxaXkSU07OswSfLa0qRbLdb6ps1tsHTENDGb6WN/dCdqssAXUou3NLQS5Gx5Wf4CwZtTrLMcbNgbDSl6DgLKddojUv544o88sUrgG9r0u3krNf4p2rhIa/SEboyAtXi01Hbo1cDw8Wc8WosyhOnmy0yOrMcVcmx32KQvFY7CKcjzu2/vOIjLTq3SRFd1beTZCuk0hxoHAAf+I1RTetb6XovaWG1jJyLJdXxSCqvgbYoVSfSkirw4bZI8VSnfOkrKP7m/5jmaMiwnxyFg4Ti0a+MhMw7t4UhQbBDd2prBfXmDZI+n3/02qxgpuEE71zBzTeG5Jq86QQBWYjCEpQGj8FTympN9fr2zsg1H3mYBcFTgwxysA+QkQMafQOMgNDeatfGHrYBB5JCu2ZxJrgACwK+eFPyMwCc1G8kkwMZP0MTnKfun2PRs7mzU7gD0HkHYZXqZZOuU6HGnnj6SmUkVj4rYYj71w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5154.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(71200400001)(186003)(2616005)(26005)(508600001)(38070700005)(36756003)(53546011)(31686004)(4326008)(5660300002)(6506007)(83380400001)(6916009)(122000001)(38100700002)(2906002)(31696002)(316002)(8936002)(66946007)(64756008)(6512007)(7416002)(54906003)(66556008)(66446008)(76116006)(91956017)(6486002)(86362001)(66476007)(8676002)(45980500001)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UnZ0dThXQXcwYUt3ejNsd21ocWFjMHVoaWhCZlQzclN3Ry80RDMwRGlUanM4?= =?utf-8?B?bVNqTTlLMm1vcEdDOEVKZ244Y2dzYUNOTnNhaE04V3d5KzRKcmtNOXVzZlNM?= =?utf-8?B?M0xUYm41Z1U1ODVnOWd6WXlFNXdJVzZYclhlZmY0N3VnOUg0ZjkxWkdsWFB4?= =?utf-8?B?Q1E0QkxXZXY2eXR5U2Rsa0l3NVdGTGI5RlNWY1I2UTA2RTMycXdrU1hVSzgz?= =?utf-8?B?Q00zYXlHZGNPREovTkZ1UzZzRFkrMVpuRzNKMWxPZTBiV3BReU12ZlVkY1BE?= =?utf-8?B?ai9hRjZ1Mm16YXFMZ0g5Y09VYkVTb3FRMXhFTk91eTB0WEpqN2JlZElvYXVG?= =?utf-8?B?d3dkdE9KVU50M3BJSkRwaTVHaVFIS0tKd3BVM203Ly9TbWc1Y3J0WjFMNXFv?= =?utf-8?B?Ri9kSmREZW16cjY0QXNmamYxdG9QcTV6K2xtVXBNMXd3dkw0VDdqV3NpTk9p?= =?utf-8?B?YnF2WURPK01sNGg1UzY1WFoySEtjSi95bUxpWnlRSEJqRUVMYURzZnB5a3kz?= =?utf-8?B?WUpUNVQ0Y290c1pZK2l4Zm02RFJaamxkU3Z5dllReDZrTllwQWE5a2l5S2w1?= =?utf-8?B?SldBekcyT09hTXVjZWFWVStmaWliVFN3K3NiKzRDV053K3dtRTNqOTNMSkR0?= =?utf-8?B?NDUzZWdLWVJxRGZzZzdSR1U2SUpic3Y5WEl1ckRMRkI3RDRiQWYzemZKYjlp?= =?utf-8?B?ZlEzRnVaaFFEWmd4VFBnTndaTXBJUlc1WUlja2lTVHpLa3FKTy9za3R3d3kr?= =?utf-8?B?SVBhYXJaamxudk5VNVRXTlNJVFFGeC9lck1tZk9MdU1PdzBNWEpBcHp6T2xW?= =?utf-8?B?R3BpWVhKLzdKNUNXcmJHbVUvTGZpU2pKekdGeDBjMTZLVGkwMXcxTUx2ZExE?= =?utf-8?B?L3o5L0EwaDgyeU5rTTRtc3N1V051YTZwelZMTTVEMll1eUh6MEZHeVRCV1BJ?= =?utf-8?B?R0d1ZlZPUEYweGY0cEMrdnNTN2ViVnZmcTRXeXNod2NPWHZtNmpLUzJOekJk?= =?utf-8?B?WlFzY1MyTjQrUTBIUFIwVHNSNEZHaWFCd0hyRU1PalZ3bkpTYmorWjU2ZkZN?= =?utf-8?B?YkgrNFgvZU1KZHNOa3dxMElKNDNyS1FNaXovYUV5Uyt2RUx2aktvQ2ZVM1gz?= =?utf-8?B?YU9WbXY5dVAyY1FIb0NsSjgrVVFaQ24wNkFlZG9ZUjlaOXlHUUdudUNKZE1t?= =?utf-8?B?ajVqSFlUeHYzbFE2NktIa2RXRTc5cVE4VzZoWWxKSDAvdWtCUVhPYnRsaEdY?= =?utf-8?B?Z1Z3YTVRdWhqejNpS3g2b2pLaXRkVElZbVRTREQxK0dCOW5qbzRhV0NYSmlD?= =?utf-8?B?YjU5Ymd4cjlMZ0RxRDRTZEhJT09rWkRrUWZZOUhhckZYMng3ZFhhcFFUZTdq?= =?utf-8?B?VmRQS3gySGtuZkhsOFBkNFkyeFQ2YUVqOW82ZnVXc28ybUJDSjc0RmI4ZGJC?= =?utf-8?B?QVplR3d5THVmK0xJSEZLdXFNV2w0TlkxOWtWZ1pLZHdSZUI2eFlxb3EzZ0Iv?= =?utf-8?B?ZW5zN0tuVFhCV2tlQnF5Q0diZlU3VzBLVDNpZ3hOajZpejVFVDE2aVRybWVm?= =?utf-8?B?TTNYRGgvWE1CZHU0Y01iK3dzbzRSSmhRQkZQQWNoVHpFSHBmSFkreUs2aXVn?= =?utf-8?B?N0J5TCtZbE5hSFd2KzVIb3U2U3hFVVR2UWJDR3VvRVluQmE0NTYyVEljMWpj?= =?utf-8?B?RGZaUnFEQlREWklpOUd6cTcwNHllRWF0Yk9PaXlKVTJoSmRQSytXTWJlQWU5?= =?utf-8?B?clVKb0NORG1mWFJsWEtEY3FBNzRNWUpTWHRNZSsxeVoxamdnZENoTDZHRGhR?= =?utf-8?B?cit1Nk5LOW1sSU44MFRkeW1hV2FpbzM2WEV3NGpxMkI3ZGljWlBFR1ZJbTNn?= =?utf-8?B?RkczbzRXbDVjSThwK1g1TXRMRHZCYU90SEFxUHVJeXFmK0lFcnpsMVFmVkZp?= =?utf-8?B?S0UrRHlvdUhhVFRWSG5ZS2diUVc5UE0yUmJsOXBvRnd1Qk5oM1gxT3pGRys3?= =?utf-8?B?dElDRk5qd2dJajlXZUo1bUZXUkJoaEhqaTY4YTBydEEwbC9pZG9Kemo3VGZx?= =?utf-8?B?UFZyT1NMKzRpRjRXc0hzL0VMamd1b3hGaDA1a2VXMXYremRBbThzaUFuQUlr?= =?utf-8?B?dEhuTWQ1OXdFMmhUNW44dU9Ccmw5eTFnWVdnNjdsWVh6M2J4ZEgwMmNLYjlT?= =?utf-8?B?MEZLbzZud0FPV2FtZkNHaWlhbnhBcGx1WWhMdzN4aW5XWlp2RWVLY2FQV2ta?= =?utf-8?B?WWtHRlpBYnV3WkhQZjVpV2FaaURnPT0=?= Content-ID: <47979C8CE5E995499F6876D8CF37196A@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5154.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d38e587b-53c0-4c8e-7ddb-08d9a2cb27f2 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2021 15:19:28.0117 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9BDHe1XVbQU+bj3iMzsGhuY8fvheufe0oFM/RTKoCNq7ANKGtpqZDHDx285ktCEMiBuK2V/MKkNkh8RoMQmowjwQM1vK+ZapT2/MQ30vXbw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1407 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_071932_103107_0A364061 X-CRM114-Status: GOOD ( 15.83 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 21/10/2021 19:34, Arnd Bergmann wrote: >>>> +int mpfs_blocking_transaction(struct mpfs_sys_controller *mpfs_client, void *msg) >>>> +{ >>>> + int ret; >>>> + >>>> + mutex_lock_interruptible(&transaction_lock); > > When you do a mutex_lock_interruptible(), you have to check its return code and > handle the interruption, usually by passing down -EINTR to the caller. > >>>> +struct mpfs_sys_controller * >>>> +mpfs_sys_controller_get(struct device_node *mss_node) >>>> +{ >>>> + struct platform_device *pdev = of_find_device_by_node(mss_node); >>>> + >>>> + if (!pdev) >>>> + return NULL; >>>> + >>>> + return platform_get_drvdata(pdev); >>>> +} >>>> +EXPORT_SYMBOL(mpfs_sys_controller_get); > > There should probably be a check in here to ensure that this is actually > a system controller and it's bound do this driver, rather than returning a > random device's driver data > > It might also help to make this take a phandle instead of a device node > for lookup, to spare the client the extra phandle to node conversion. Finally got around to this again, is it sufficient to just check that platform_get_drvdata returns non null, or should I also check if the pdev matches the drivers compatible strings? Only found one example of the latter and a mix of the former & what I had done when I went looking around at other drivers. Conor. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv