linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: jason@lakedaemon.net, Palmer Dabbelt <palmer@sifive.com>,
	linux-kernel@vger.kernel.org, alan.mikhak@sifive.com,
	Paul Walmsley <paul.walmsley@sifive.com>,
	tglx@linutronix.de, linux-riscv@lists.infradead.org
Subject: Re: [PATCH] irqchip: Skip contexts other supervisor in plic_init()
Date: Thu, 24 Oct 2019 08:27:52 +0100	[thread overview]
Message-ID: <67fff4d811c27017e7b34267365c8c0f@www.loen.fr> (raw)
In-Reply-To: <20191024070311.GA16652@infradead.org>

On 2019-10-24 08:03, Christoph Hellwig wrote:
> On Thu, Oct 24, 2019 at 07:51:16AM +0100, Marc Zyngier wrote:
>> > > > Will this need to change for RISC-V M-mode Linux support?
>> > > >
>> > > > 
>> https://lore.kernel.org/linux-riscv/20191017173743.5430-1-hch@lst.de/
>> > >
>> > > Yes.
>> >
>> > For M-mode we'll want to check IRQ_M_EXT above.  So we should just
>> > merge this patch ASAP and then for my rebased M-mode series I'll
>> > fix the check to do that for the M-Mode case, which is much 
>> cleaner
>> > than my hack.
>>
>> Does this need to be taken as a fix, potentially Cc to stable? Or is
>> that 5.5 material?
>
> So I though that the S-mode context were kinda aways to be sorted 
> before
> M-mode, but I can't find anything guranteeing it.  So I think this
> actually is a fix, and getting this queued up in the next -rc would
> really help me with the nommu stuff - otherwise we'd need to take it
> through the riscv tree for 5.5 to avoid conflicts.
>
> Btw, here is my:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> for the patch.

Thanks for that.

Alan, if you can respin this patch with an updated commit message, I'll 
queue
it with a couple of other nits I have lying around, and send it to 
Thomas by
the end of the week.

         M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

      reply	other threads:[~2019-10-24  7:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 16:22 [PATCH] irqchip: Skip contexts other supervisor in plic_init() Alan Mikhak
2019-10-23 18:54 ` Paul Walmsley
2019-10-23 21:34   ` Alan Mikhak
2019-10-24  2:21     ` Paul Walmsley
2019-10-23 22:07   ` Palmer Dabbelt
2019-10-24  1:30     ` Christoph Hellwig
2019-10-24  6:51       ` Marc Zyngier
2019-10-24  7:03         ` Christoph Hellwig
2019-10-24  7:27           ` Marc Zyngier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67fff4d811c27017e7b34267365c8c0f@www.loen.fr \
    --to=maz@kernel.org \
    --cc=alan.mikhak@sifive.com \
    --cc=hch@infradead.org \
    --cc=jason@lakedaemon.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@sifive.com \
    --cc=paul.walmsley@sifive.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).