From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97279C352A3 for ; Mon, 10 Feb 2020 10:46:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C59020842 for ; Mon, 10 Feb 2020 10:46:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Q4Nz7P5o"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="RdSNVpl3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C59020842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3VdT8leEAlfSLQpPQKoxenZVPWjYs1yN+U09thgTRJA=; b=Q4Nz7P5o1dkqXf CnqA7NtxI1vbGS477frKK8n56twajPJ1xuHZYYE5nDauUSUPBdoxJ40v4S20x3Fwf/3PPrKlXKQl6 QoyAKLZYfUpy8vVSiD/uwXRYpkYz6pJa0+sfoZLFscj5W4H539DEG2Kg8mZ301tmIfZ8qh5dXmCzO 4pcWIfXAzfLEnTQmRWHkRf/nXYwHohsS/jQZ5pv6gvSZeK7UefGkHKYAhHsRp3NjE0P29C0Hf+TqB PFAqOVWCkqBkfcdafBHb2rcRBlaCM3AQF9ppQVnwLnla4SzCw2w8Mhy26u8lPn/iihix9LrthyMjq u17RxGuyQ32UT8RBJtnQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j16aV-0008Cl-8e; Mon, 10 Feb 2020 10:46:47 +0000 Received: from pegase1.c-s.fr ([93.17.236.30]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j16aQ-0008C2-Uc; Mon, 10 Feb 2020 10:46:45 +0000 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48GMyn4XNDzB09b8; Mon, 10 Feb 2020 11:46:25 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=RdSNVpl3; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 2YKBWszaeG8b; Mon, 10 Feb 2020 11:46:25 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48GMyn31lmzB09b6; Mon, 10 Feb 2020 11:46:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1581331585; bh=3VdT8leEAlfSLQpPQKoxenZVPWjYs1yN+U09thgTRJA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=RdSNVpl3eRdV3gPJ7XDvUegm6wZGug8ejVpKq74HLxDjFS3pwYqC+BZGFoUQ1Oq78 SVulkxR8i/NmQfPxXj9q1ZP6MDJ4/eVa8ThwXr9rdv9XZ0ODywoTCAXN5cQTc5KVGa aEm6pzX4mgbIsgNXEcKTlXONuuV1vYFncq9hDwgQ= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 295478B7B8; Mon, 10 Feb 2020 11:46:29 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id VHUUj31ZCU6T; Mon, 10 Feb 2020 11:46:29 +0100 (CET) Received: from [172.25.230.102] (po15451.idsi0.si.c-s.fr [172.25.230.102]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 6A8808B7B5; Mon, 10 Feb 2020 11:46:23 +0100 (CET) Subject: Re: [PATCH V13] mm/debug: Add tests validating architecture page table helpers To: Russell King - ARM Linux admin References: <1580897674-16456-1-git-send-email-anshuman.khandual@arm.com> <202002060619.wEOdAZU1%lkp@intel.com> <78d3ce6b-e100-2561-6b09-124c29731d1a@arm.com> <20200209205231.44d098f8749e88190b8ba10c@linux-foundation.org> <955229f7-f161-f720-0e75-a3163f63817d@arm.com> <20200210100200.GB25745@shell.armlinux.org.uk> From: Christophe Leroy Message-ID: <7cb3a5bb-eaea-a01c-4047-e3c000b7ad1d@c-s.fr> Date: Mon, 10 Feb 2020 11:46:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200210100200.GB25745@shell.armlinux.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200210_024643_287587_21BDA9E7 X-CRM114-Status: GOOD ( 23.92 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , uclinux-h8-devel@lists.sourceforge.jp, linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Tetsuo Handa , Heiko Carstens , Michal Hocko , linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, Thomas Gleixner , linux-s390@vger.kernel.org, kbuild test robot , Yoshinori Sato , Max Filippov , Michael Ellerman , x86@kernel.org, Matthew Wilcox , Steven Price , Jason Gunthorpe , Geert Uytterhoeven , Gerald Schaefer , Mark Salter , Matt Turner , linux-snps-arc@lists.infradead.org, Ingo Molnar , linux-xtensa@linux-xtensa.org, Kees Cook , Anshuman Khandual , Masahiro Yamada , linux-alpha@vger.kernel.org, Aurelien Jacquiot , linux-c6x-dev@linux-c6x.org, Mark Brown , Ivan Kokshaysky , Paul Walmsley , "Kirill A . Shutemov" , Dan Williams , Guan Xuetao , Vlastimil Babka , Richard Henderson , linux-arm-kernel@lists.infradead.org, Chris Zankel , Michal Simek , kbuild-all@lists.01.org, Brian Cain , Ard Biesheuvel , Greg Kroah-Hartman , Dave Hansen , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Palmer Dabbelt , Vineet Gupta , Martin Schwidefsky , Qian Cai , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org Le 10/02/2020 à 11:02, Russell King - ARM Linux admin a écrit : > On Mon, Feb 10, 2020 at 07:38:38AM +0100, Christophe Leroy wrote: >> >> >> Le 10/02/2020 à 06:35, Anshuman Khandual a écrit : >>> >>> >>> On 02/10/2020 10:22 AM, Andrew Morton wrote: >>>> On Thu, 6 Feb 2020 13:49:35 +0530 Anshuman Khandual wrote: >>>> >>>>> >>>>> On 02/06/2020 04:40 AM, kbuild test robot wrote: >>>>>> Hi Anshuman, >>>>>> >>>>>> Thank you for the patch! Yet something to improve: >>>>>> >>>>>> [auto build test ERROR on powerpc/next] >>>>>> [also build test ERROR on s390/features linus/master arc/for-next v5.5] >>>>>> [cannot apply to mmotm/master tip/x86/core arm64/for-next/core next-20200205] >>>>>> [if your patch is applied to the wrong git tree, please drop us a note to help >>>>>> improve the system. BTW, we also suggest to use '--base' option to specify the >>>>>> base tree in git format-patch, please see https://stackoverflow.com/a/37406982] >>>>>> >>>>>> url: https://github.com/0day-ci/linux/commits/Anshuman-Khandual/mm-debug-Add-tests-validating-architecture-page-table-helpers/20200205-215507 >>>>>> base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next >>>>>> config: ia64-allmodconfig (attached as .config) >>>>>> compiler: ia64-linux-gcc (GCC) 7.5.0 >>>>>> reproduce: >>>>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>>>>> chmod +x ~/bin/make.cross >>>>>> # save the attached .config to linux build tree >>>>>> GCC_VERSION=7.5.0 make.cross ARCH=ia64 >>>>>> >>>>>> If you fix the issue, kindly add following tag >>>>>> Reported-by: kbuild test robot >>>>>> >>>>>> All error/warnings (new ones prefixed by >>): >>>>>> >>>>>> In file included from include/asm-generic/pgtable-nopud.h:8:0, >>>>>> from arch/ia64/include/asm/pgtable.h:586, >>>>>> from include/linux/mm.h:99, >>>>>> from include/linux/highmem.h:8, >>>>>> from mm/debug_vm_pgtable.c:14: >>>>>> mm/debug_vm_pgtable.c: In function 'pud_clear_tests': >>>>>>>> include/asm-generic/pgtable-nop4d-hack.h:47:32: error: implicit declaration of function '__pgd'; did you mean '__p4d'? [-Werror=implicit-function-declaration] >>>>>> #define __pud(x) ((pud_t) { __pgd(x) }) >>>>>> ^ >>>>>>>> mm/debug_vm_pgtable.c:141:8: note: in expansion of macro '__pud' >>>>>> pud = __pud(pud_val(pud) | RANDOM_ORVALUE); >>>>>> ^~~~~ >>>>>>>> include/asm-generic/pgtable-nop4d-hack.h:47:22: warning: missing braces around initializer [-Wmissing-braces] >>>>>> #define __pud(x) ((pud_t) { __pgd(x) }) >>>>>> ^ >>>>>>>> mm/debug_vm_pgtable.c:141:8: note: in expansion of macro '__pud' >>>>>> pud = __pud(pud_val(pud) | RANDOM_ORVALUE); >>>>>> ^~~~~ >>>>>> cc1: some warnings being treated as errors >>>>> >>>>> This build failure is expected now given that we have allowed DEBUG_VM_PGTABLE >>>>> with EXPERT without platform requiring ARCH_HAS_DEBUG_VM_PGTABLE. This problem >>>>> i.e build failure caused without a platform __pgd(), is known to exist both on >>>>> ia64 and arm (32bit) platforms. Please refer https://lkml.org/lkml/2019/9/24/314 >>>>> for details where this was discussed earlier. >>>>> >>>> >>>> I'd prefer not to merge a patch which is known to cause build >>>> regressions. Is there some temporary thing we can do to prevent these >>>> errors until arch maintainers(?) get around to implementing the >>>> long-term fixes? >>> >>> We could explicitly disable CONFIG_DEBUG_VM_PGTABLE on ia64 and arm platforms >>> which will ensure that others can still use the EXPERT path. >>> >>> config DEBUG_VM_PGTABLE >>> bool "Debug arch page table for semantics compliance" >>> depends on MMU >>> depends on !(IA64 || ARM) >>> depends on ARCH_HAS_DEBUG_VM_PGTABLE || EXPERT >>> default n if !ARCH_HAS_DEBUG_VM_PGTABLE >>> default y if DEBUG_VM >>> >> >> On both ia32 and arm, the fix is trivial. >> >> Can we include the fix within this patch, just the same way as the >> mm_p4d_folded() fix for x86 ? > > Why should arm include a macro for something that nothing (apart from > this checker) requires? If the checker requires it but the rest of > the kernel does not, it suggests that the checker isn't actually > correct, and the results can't be relied upon. > As far as I can see, the problem is that arm opencodes part of the API instead of including asm-generic/pgtable-nopmd.h Here, the ARM has 2 levels, ie only PGD and PTE. But instead of defining __pgd and __pte and getting everything else from asm-generic, it defines a __pmd then redefines the folded levels like the pud, etc ... That's exactly what the checker aims at detecting: architectures than do not properly use the standard linux page table structures. Christophe