From: "chenjiahao (C)" <chenjiahao16@huawei.com>
To: Simon Horman <horms@kernel.org>
Cc: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<conor.dooley@microchip.com>, <guoren@kernel.org>,
<heiko@sntech.de>, <bjorn@rivosinc.com>, <alex@ghiti.fr>,
<akpm@linux-foundation.org>, <atishp@rivosinc.com>,
<bhe@redhat.com>, <thunder.leizhen@huawei.com>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<kexec@lists.infradead.org>, <linux-doc@vger.kernel.org>
Subject: Re: [PATCH -next 1/2] riscv: kdump: Implement crashkernel=X,[high,low]
Date: Mon, 27 Mar 2023 20:50:33 +0800 [thread overview]
Message-ID: <8bf91bee-e51c-90f6-b522-1db4094966f4@huawei.com> (raw)
In-Reply-To: <ZBhvhBTQhAnN5qdm@kernel.org>
On 2023/3/20 22:36, Simon Horman wrote:
> On Tue, Mar 21, 2023 at 04:42:43AM +0800, Chen Jiahao wrote:
>> On riscv, the current crash kernel allocation logic is trying to
>> allocate within 32bit addressible memory region by default, if
>> failed, try to allocate without 4G restriction.
>>
>> In need of saving DMA zone memory while allocating a relatively large
>> crash kernel region, allocating the reserved memory top down in
>> high memory, without overlapping the DMA zone, is a mature solution.
>> Here introduce the parameter option crashkernel=X,[high,low].
>>
>> We can reserve the crash kernel from high memory above DMA zone range
>> by explicitly passing "crashkernel=X,high"; or reserve a memory range
>> below 4G with "crashkernel=X,low".
>>
>> Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
> Some minor nits, but I don't think there is any need to respin for them.
>
> Reviewed-by: Simon Horman <horms@kernel.org>
I will send another version and clean up these by the way, thanks.
Chen, Jiahao
>
> ...
>
>> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
>> index 478d6763a01a..5def2174b243 100644
>> --- a/arch/riscv/mm/init.c
>> +++ b/arch/riscv/mm/init.c
> ...
>
>> @@ -1201,16 +1242,25 @@ static void __init reserve_crashkernel(void)
>> */
>> crash_base = memblock_phys_alloc_range(crash_size, PMD_SIZE,
>> search_start,
>> - min(search_end, (unsigned long) SZ_4G));
>> + min(search_end, (unsigned long) dma32_phys_limit));
> nit: While here, you could drop the space before 'ma32_phys_limit'.
> Or perhaps use min_t, which seems appropriate here.
>
>> if (crash_base == 0) {
>> /* Try again without restricting region to 32bit addressible memory */
>> crash_base = memblock_phys_alloc_range(crash_size, PMD_SIZE,
>> - search_start, search_end);
>> + search_start, search_end);
>> if (crash_base == 0) {
>> pr_warn("crashkernel: couldn't allocate %lldKB\n",
>> crash_size >> 10);
>> return;
>> }
>> +
>> + if (!crash_low_size)
>> + crash_low_size = DEFAULT_CRASH_KERNEL_LOW_SIZE;
>> + }
>> +
>> + if ((crash_base > dma32_phys_limit - crash_low_size) &&
>> + crash_low_size && reserve_crashkernel_low(crash_low_size)) {
> nit: The line above should be aligned one character to the left
> (remove one space in the indent).
>
>> + memblock_phys_free(crash_base, crash_size);
>> + return;
>> }
>>
>> pr_info("crashkernel: reserved 0x%016llx - 0x%016llx (%lld MB)\n",
> ...
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-03-27 12:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 20:42 [PATCH -next 0/2] support allocating crashkernel above 4G explicitly on riscv Chen Jiahao
2023-03-20 20:42 ` [PATCH -next 1/2] riscv: kdump: Implement crashkernel=X,[high,low] Chen Jiahao
2023-03-20 14:36 ` Simon Horman
2023-03-27 12:50 ` chenjiahao (C) [this message]
2023-03-21 1:42 ` Leizhen (ThunderTown)
2023-03-27 12:54 ` chenjiahao (C)
2023-03-20 20:42 ` [PATCH -next 2/2] docs: kdump: Update the crashkernel description for riscv Chen Jiahao
2023-03-20 14:37 ` Simon Horman
2023-03-21 1:45 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bf91bee-e51c-90f6-b522-1db4094966f4@huawei.com \
--to=chenjiahao16@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=atishp@rivosinc.com \
--cc=bhe@redhat.com \
--cc=bjorn@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=guoren@kernel.org \
--cc=heiko@sntech.de \
--cc=horms@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).