From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EB2BC4167B for ; Fri, 30 Dec 2022 16:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mDCKOklRnUvUF/wIFZ0RYOXmlbM08m7e0hM4iDzkwdc=; b=cXVAhJC6152b7T nfook2Cg8OwKhGO7TtG681PeuK3ySfjuIn3JRkqoeW2HaYAy+QMHg2OoibdscXiwGrGZPJGvXzWj2 SuJKlxu2atuMKMQrA3y6gctIizQ9Ztt+5pU/gSjkIPKKt3EQ4bktRaFhvSas2EN4ZNI/JBqUkVMeZ XjavfYoHqofDBtHxssPbAcAdAnaIpXwRTvouBX+y1ubx06z5W/lPlB1FSSd/149M2FPgZLZLa769T djq4zpovaoXfmkKziwDn9z6dofhxRKU0XAxCU1bvwx5z1sIC2TKOxForN1QKs1sVt+Xb+TQUBFkYv W6pD17EwdVF8bGcIUxyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBI9t-00Az6a-On; Fri, 30 Dec 2022 16:23:01 +0000 Received: from mail-yw1-x112e.google.com ([2607:f8b0:4864:20::112e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBI3J-00AwaO-9i for linux-riscv@lists.infradead.org; Fri, 30 Dec 2022 16:16:15 +0000 Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-43ea87d0797so302742217b3.5 for ; Fri, 30 Dec 2022 08:16:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FnbzJ38SiTMk4847/vwLYPGHC/qFlBB6CHAWt+Sx6jU=; b=HJfvsBEzTBP/BxwBvEdQyzNMUgAlsDyG6SXDo+qyExU5ctM0d9wj7NqfFaT2B8AXRI 2jm4ZWDBLtTEqPZuKaO2WsQfEUIVZE+e2ycMELhAS4+XUsO2FktVj2Ubj3xGGP4UleCB eCKJ4EjqEIOQhPNJGw1LYwzXhQ81IitFOr5xvU0W/9vC65/Tn+lr6vGmVlADXBKYuXlm yHDGubayghoMOSPAFVdRtA7n8aVu9sNWCo38LzJF6UaAip4Wfc2ojpXFa0UoNEqSfX5x /ikIOcP+JMbPsEtiAO2hsUPmD336b8H0broOpycJPKH8Ne9q7QtBEpusqwET6jl0Wb4F elPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FnbzJ38SiTMk4847/vwLYPGHC/qFlBB6CHAWt+Sx6jU=; b=W7mCrdT3ZqGi3t1lLmK++vJjivrCrrO9YLERC78vuIdxy+mm4lmZDuUk5dV0gGUIJW if5+DVIvOESTCi91bXgx0d2WY6Tfiqifiox+JzSgabA6bZWcXH20MvjSoGvuQR1M0i+f 63I12P3/w/AO1WISmXM5eTC4nSttU0w40LzrmEx0r6Ao1xUDbMSPRUUUkrc6npQIb1hC L6jyB1al9GeD0HAuEU/g8DoKrnd1yH4lbMP+xZ+ZR3CJL6quvUHHnI04lK1K0oTF/JNF lgL/im0f94qJaHJnzKZKjpRfCame1kz70yOWDsCr3Y+kaIjTVRLEhGQaxktKEWY9buzN YaeA== X-Gm-Message-State: AFqh2konNjfs3M9fVePuCKCZhGGlq9DLc06Es4KkZTfwL/hOJOGcAKzX Ud1HEUDASPXLzJOB+WJ9U0VoLXQIuxuMPMExdNE= X-Google-Smtp-Source: AMrXdXuCkHZ3DWflaIvrxe7Cf05vdnMjYH02YAXYvvvd5YNWHZo4sZIP5vT2TNt8L4lR9pAyna/CFeODawxtXhq9dOM= X-Received: by 2002:a81:844f:0:b0:47a:a99f:9da9 with SMTP id u76-20020a81844f000000b0047aa99f9da9mr1858518ywf.258.1672416966188; Fri, 30 Dec 2022 08:16:06 -0800 (PST) MIME-Version: 1.0 References: <20220829205219.283543-1-geomatsi@gmail.com> In-Reply-To: From: "Lad, Prabhakar" Date: Fri, 30 Dec 2022 16:15:39 +0000 Message-ID: Subject: Re: [RFC PATCH 1/1] riscv: mm: notify remote harts about mmu cache updates To: Sergey Matyukevich Cc: linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, Anup Patel , Atish Patra , Albert Ou , Palmer Dabbelt , Paul Walmsley , Guo Ren , Alexandre Ghiti , Heiko Stuebner , Sergey Matyukevich , Geert Uytterhoeven , Conor Dooley X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221230_081613_376703_B89F3985 X-CRM114-Status: GOOD ( 47.34 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi Sergey, On Sat, Dec 24, 2022 at 11:48 AM Sergey Matyukevich wrote: > > Hi Prabhakar, > > > > > > > > > > > > Current implementation of update_mmu_cache function performs local TLB > > > > > > > > > > > flush. It does not take into account ASID information. Besides, it does > > > > > > > > > > > not take into account other harts currently running the same mm context > > > > > > > > > > > or possible migration of the running context to other harts. Meanwhile > > > > > > > > > > > TLB flush is not performed for every context switch if ASID support > > > > > > > > > > > is enabled. > > > > > > > > > > > > > > > > > > > > > > Patch [1] proposed to add ASID support to update_mmu_cache to avoid > > > > > > > > > > > flushing local TLB entirely. This patch takes into account other > > > > > > > > > > > harts currently running the same mm context as well as possible > > > > > > > > > > > migration of this context to other harts. > > > > > > > > > > > > > > > > > > > > > > For this purpose the approach from flush_icache_mm is reused. Remote > > > > > > > > > > > harts currently running the same mm context are informed via SBI calls > > > > > > > > > > > that they need to flush their local TLBs. All the other harts are marked > > > > > > > > > > > as needing a deferred TLB flush when this mm context runs on them. > > > > > > > > > > > > > > > > > > > > > > [1] https://lore.kernel.org/linux-riscv/20220821013926.8968-1-tjytimi@163.com/ > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Sergey Matyukevich > > > > > > > > > > > --- > > > > > > > > > > > arch/riscv/include/asm/mmu.h | 2 ++ > > > > > > > > > > > arch/riscv/include/asm/pgtable.h | 2 +- > > > > > > > > > > > arch/riscv/include/asm/tlbflush.h | 18 ++++++++++++++++++ > > > > > > > > > > > arch/riscv/mm/context.c | 10 ++++++++++ > > > > > > > > > > > arch/riscv/mm/tlbflush.c | 28 +++++++++++----------------- > > > > > > > > > > > 5 files changed, 42 insertions(+), 18 deletions(-) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > [ 133.008752] Hardware name: Renesas SMARC EVK based on r9a07g043f01 (DT) > > > > > > > > > > [ 133.015338] Call Trace: > > > > > > > > > > [ 133.017778] [] dump_backtrace+0x1c/0x24 > > > > > > > > > > [ 133.023174] [] show_stack+0x2c/0x38 > > > > > > > > > > [ 133.028214] [] dump_stack_lvl+0x3c/0x54 > > > > > > > > > > [ 133.033597] [] dump_stack+0x14/0x1c > > > > > > > > > > [ 133.038633] [] panic+0x102/0x29a > > > > > > > > > > [ 133.043409] [] do_exit+0x704/0x70a > > > > > > > > > > [ 133.048362] [] do_group_exit+0x24/0x70 > > > > > > > > > > [ 133.053659] [] get_signal+0x68a/0x6dc > > > > > > > > > > [ 133.058874] [] do_work_pending+0xd6/0x44e > > > > > > > > > > [ 133.064427] [] resume_userspace_slow+0x8/0xa > > > > > > > > > > [ 133.070249] ---[ end Kernel panic - not syncing: Attempted to kill > > > > > > > > > > init! exitcode=0x0000000b ]--- > > > > > > > > > > > > > > > > > > > > If I revert this patch [0] bonnie++ works as expected. > > > > > > > > > > > > > > > > > > > > Any pointers on what could be the issue here? > > > > > > > > > > > > > > > > > > > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git/commit/?h=for-next&id=4bd1d80efb5af640f99157f39b50fb11326ce641 > > > > > > > > > > > > > > > > > > > > Cheers, > > > > > > > > > > Prabhakar > > > > > > > > > > > > > > > > > > Good catch. Thanks for reporting ! Discussion around the issue and > > > > > > > > > possible ways to fix it can be found in the following email thread: > > > > > > > > > > > > > > > > > > https://lore.kernel.org/linux-riscv/20221111075902.798571-1-guoren@kernel.org/ > > > > > > > > > > > > > > > > > > Could you please apply the patch from Guo Ren instead of [0] and check > > > > > > > > > if you have any issues with your test ? Besides, could you please share > > > > > > > > > your kernel configuration and the actual bonnie++ params from emmc_t_002.sh script ? > > > > > > > > > > > > > > > > > Thanks for the pointer, I'll undo my changes and test Guo's patch. > > > > > > > > > > > > > > > > I have pasted the script here [0] and attached config. > > > > > > > > > > > > > > > > [0] https://paste.debian.net/hidden/a7a769b5/ > > > > > > > > > > > > > > Thanks for the script and config. Could you please also share the > > > > > > > following information: > > > > > > > - how many cores your system has > > > > > > The Renesas RZ/Five SoC has a single Andes AX45MP core. > > > > > > > > > > > > > - does your system support ASID > > > > > > > > > > > > > With a quick look at [0] It does support ASID, unless there is a way > > > > > > to disable it. > > > > > > > > > > > > [0] http://www.andestech.com/wp-content/uploads/AX45MP-1C-Rev.-5.0.0-Datasheet.pdf > > > > > > > > > > So you have a single-core system, but your kernel configuration enables > > > > > CONFIG_SMP. Additional 'deferred TLB flush' logic is dropped at build > > > > > time if CONFIG_SMP is disabled. On the other hand, system should not > > > > > fail that way even if SMP is enabled. > > > > > > > > > I enabled CONFIG_SMP while doing some testing of PMA code and indeed > > > > enabling this config should not introduce a failure. > > > > > > > > > Let me double-check if anything can go wrong if cpumasks may have only > > > > > a single cpu. Another suspect is a change in update_mmu_cache: probably > > > > > making it asid-specific (and thus more granular) was a bad idea. > > > > > > > > > Thanks. > > > > > > > > BTW I tested the patch [0] which you pointed out and that fixes the > > > > issues seen earlier. > > > > > > > > [0] https://patchwork.kernel.org/project/linux-riscv/patch/20221111075902.798571-1-guoren@kernel.org/ > > > > > > All looks good with cpumasks in the single-core case. So deferred TLB > > > flush logic is not even executed in your case. So the root cause > > > should be in update_mmu_cache change. > > > > > > May I ask you to repeat the original emmc test on your platform from > > > for-next (i.e. with [0] and without [1]) with the following partial revert: > > > > > > : diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h > > > : index ec6fb83349ce..92ec2d9d7273 100644 > > > : --- a/arch/riscv/include/asm/pgtable.h > > > : +++ b/arch/riscv/include/asm/pgtable.h > > > : @@ -415,7 +415,7 @@ static inline void update_mmu_cache(struct vm_area_struct *vma, > > > : * Relying on flush_tlb_fix_spurious_fault would suffice, but > > > : * the extra traps reduce performance. So, eagerly SFENCE.VMA. > > > : */ > > > : - flush_tlb_page(vma, address); > > > : + local_flush_tlb_page(address); > > > : } > > > : > > > : static inline void update_mmu_cache_pmd(struct vm_area_struct *vma, > > > > > I tested your above proposed changes and I am no longer seeing an > > issue on my platform. > > Great. I will send a fixup after I double-check on several other > hardware platforms. Thanks for testing ! > Actuall, I did hit an issue now with your proposed changes with bonnie++ again! [ 1873.355279] EXT4-fs (sda1): mounted filesystem 050ad3b9-b571-4b4c-9500-db56feed01ab with ordered data mode. Quota mode: disabled. Using uid:0, gid:0. Writing with putc()...done Writing intelligently...done Rewriting...done Reading with getc()...[ 2682.180114] sd-resolve[126]: unhandled signal 11 code 0x1 at 0x0000000000000000 in libc-2.28.so[3fbe503000+ff000] [ 2682.190552] CPU: 0 PID: 126 Comm: sd-resolve Not tainted 6.2.0-rc1-00111-g7bcd7d932cf6 #189 [ 2682.198917] Hardware name: Renesas SMARC EVK based on r9a07g043f01 (DT) [ 2682.205536] epc : 0000003fbe568004 ra : 0000003fbe569440 sp : 0000003fbe417b10 [ 2682.212770] gp : 0000002ab8d18b88 tp : 0000003fbe41e810 t0 : 0000000000000022 [ 2682.219987] t1 : 0000003fbdbf1e4c t2 : 0000003fbe417290 s0 : 00000000000000e0 [ 2682.227219] s1 : 0000000000000000 a0 : 0000000000000000 a1 : 8080808080808080 [ 2682.234433] a2 : 0000003fb80019f0 a3 : 0000003fbe41e8f0 a4 : 0000000000000008 [ 2682.241648] a5 : 0000000000000000 a6 : fefefefefefefeff a7 : 0000000000000039 [ 2682.248863] s2 : 0000003fbe417b37 s3 : 0000003fbe417e48 s4 : 0000000000000001 [ 2682.256082] s5 : 0000003fbe417eb0 s6 : 00000000000000e0 s7 : 0000003fbdbf2f2a [ 2682.263297] s8 : ffffffffffffffff s9 : fffffffffffffffd s10: ffffffffffffffff [ 2682.270511] s11: fffffffffffffffe t3 : 0000000000000000 t4 : 000000077ce2ea37 [ 2682.277733] t5 : 000000000000003f t6 : 0000000000000000 [ 2682.283046] status: 0000000200004020 badaddr: 0000000000000000 cause: 000000000000000d [ 2682.441183] audit: type=1701 audit(1671222620.403:17): auid=4294967295 uid=995 gid=994 ses=4294967295 pid=124 comm="sd-resolve" exe="/lib/systemd/systemd-timesyncd" sig=11 res=1 done Reading intelligently...done Let me know if you want me to share my branch. Cheers, Prabhakar _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv